Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1590547523 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -1073,4 +1151,13 @@ class ZkMigrationIntegrationTest { kraftCluster.close()

Re: [PR] KAFKA-15845: Detect leaked Kafka clients and servers with LeakTestingExtension [kafka]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #14783: URL: https://github.com/apache/kafka/pull/14783#issuecomment-2095133166 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15524, KAFKA-15917: Wait for zombie sink tasks' consumers to commit offsets before trying to modify their offsets in integration tests [kafka]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #15302: URL: https://github.com/apache/kafka/pull/15302#issuecomment-2095133015 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15722: KRaft support in RackAwareAutoTopicCreationTest [kafka]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #15318: URL: https://github.com/apache/kafka/pull/15318#issuecomment-2095133001 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Updated] (KAFKA-16670) KIP-848 : Consumer will not receive assignment forever because of concurrent issue.

2024-05-05 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sanghyeok An updated KAFKA-16670: - Description: *Related Code* * Consumer get assignment Successfully : **

[jira] [Created] (KAFKA-16670) KIP-848 : Consumer will not receive assignment forever because of concurrent issue.

2024-05-05 Thread sanghyeok An (Jira)
sanghyeok An created KAFKA-16670: Summary: KIP-848 : Consumer will not receive assignment forever because of concurrent issue. Key: KAFKA-16670 URL: https://issues.apache.org/jira/browse/KAFKA-16670

[jira] [Commented] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-05-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843599#comment-17843599 ] PoAn Yang commented on KAFKA-16223: --- Yes, I will try to send a PR ASAP. Thanks. > Replace EasyMock

[jira] [Commented] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-05-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843596#comment-17843596 ] Chia-Ping Tsai commented on KAFKA-16223: [~yangpoan] Could you please take over remaining

Re: [PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (2/3) [kafka]

2024-05-05 Thread via GitHub
chia7712 merged PR #15841: URL: https://github.com/apache/kafka/pull/15841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-16659) KafkaConsumer#position() does not respect wakup when group protocol is CONSUMER

2024-05-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16659. Fix Version/s: 3.8.0 Resolution: Fixed > KafkaConsumer#position() does not respect

Re: [PR] KAFKA-16659: KafkaConsumer#position() does not respect wakup when group protocol is CONSUMER [kafka]

2024-05-05 Thread via GitHub
chia7712 merged PR #15853: URL: https://github.com/apache/kafka/pull/15853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16659: KafkaConsumer#position() does not respect wakup when group protocol is CONSUMER [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on PR #15853: URL: https://github.com/apache/kafka/pull/15853#issuecomment-2095025582 ``` ./gradlew cleanTest :connect:runtime:test --tests org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testAlterSinkConnectorOffsetsOverriddenConsumerGroupId

Re: [PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on PR #15571: URL: https://github.com/apache/kafka/pull/15571#issuecomment-2095022237 I have trigged QA again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590457683 ## core/src/test/java/kafka/test/annotation/ClusterTest.java: ## @@ -44,4 +44,5 @@ String listener() default ""; MetadataVersion metadataVersion() default

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1590455114 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig, cleanerManager.removeMetrics() } +

Re: [PR] KAFKA-16652: add unit test for ClusterTemplate offering zero ClusterConfig [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15862: URL: https://github.com/apache/kafka/pull/15862#discussion_r1590454147 ## core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java: ## @@ -33,16 +31,22 @@ public class ClusterTestExtensionsUnitTest { void

Re: [PR] KAFKA-16652: add unit test for ClusterTemplate offering zero ClusterConfig [kafka]

2024-05-05 Thread via GitHub
soarez commented on code in PR #15862: URL: https://github.com/apache/kafka/pull/15862#discussion_r1590420247 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -119,23 +116,34 @@ public Stream provideTestTemplateInvocationContex return

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-05 Thread via GitHub
soarez commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1590415617 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -159,6 +159,7 @@ class LogCleaner(initialConfig: CleanerConfig, cleaners += cleaner

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-05 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1590396620 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -467,13 +474,42 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo *

Re: [PR] KAFKA-14517: Implement regex subscriptions [kafka]

2024-05-05 Thread via GitHub
Phuc-Hong-Tran commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-2094904127 Fyi @JimmyWang6, I have taken over this ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1590370017 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,374 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-14517: Implement regex subscriptions [kafka]

2024-05-05 Thread via GitHub
JimmyWang6 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-2094886153 > hi @JimmyWang6, are you still working on this? @Phuc-Hong-Tran I apologize for the delay in finishing this issue. I will continue to work on this recently, and sorry for any

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2024-05-05 Thread via GitHub
ashmeet13 commented on code in PR #12988: URL: https://github.com/apache/kafka/pull/12988#discussion_r1590353376 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -530,6 +530,14 @@ public void

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2024-05-05 Thread via GitHub
ashmeet13 commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-2094870332 Down are the configs for each type with whether - 1. Is it a custom default for KS but is editable by the user 2. Or, is it a fixed value controlled by KS ### Producer

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2024-05-05 Thread via GitHub
ashmeet13 commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-2094869760 Hi @mjsax, apologies for the extremely absent behavior on this PR. I have gone ahead and implemented the changes. The tests are pending and currently working on them. Detailing the

Re: [PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (2/3) [kafka]

2024-05-05 Thread via GitHub
hgeraldino commented on PR #15841: URL: https://github.com/apache/kafka/pull/15841#issuecomment-2094865173 Thanks @chia7712 for your comments. This PR migrates another 13 test cases to Mockito, I expect the remaining 12 cases to be covered in one last pull request -- This is an

[jira] [Assigned] (KAFKA-16669) Remove extra collection copy when genrating DescribeAclsResource

2024-05-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16669: -- Assignee: Chia Chuan Yu (was: Chia-Ping Tsai) > Remove extra collection copy when

[jira] [Commented] (KAFKA-16669) Remove extra collection copy when genrating DescribeAclsResource

2024-05-05 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843570#comment-17843570 ] Chia Chuan Yu commented on KAFKA-16669: --- Hi, [~chia7712]  Can I have this one? Thanks! > Remove

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15865: URL: https://github.com/apache/kafka/pull/15865#discussion_r1590318726 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java: ## @@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time,

Re: [PR] KAFKA-14785: Connect offset read REST API [kafka]

2024-05-05 Thread via GitHub
yashmayya commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1590316538 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java: ## @@ -141,24 +145,13 @@ private static String noClientId() {

[jira] [Created] (KAFKA-16669) Remove extra collection copy when genrating DescribeAclsResource

2024-05-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16669: -- Summary: Remove extra collection copy when genrating DescribeAclsResource Key: KAFKA-16669 URL: https://issues.apache.org/jira/browse/KAFKA-16669 Project: Kafka

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-05 Thread via GitHub
yashmayya commented on PR #15865: URL: https://github.com/apache/kafka/pull/15865#issuecomment-2094813303 Context - https://github.com/apache/kafka/pull/13434#discussion_r1590212654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-05 Thread via GitHub
gaurav-narula commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1590315633 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -159,6 +159,7 @@ class LogCleaner(initialConfig: CleanerConfig, cleaners += cleaner

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-05 Thread via GitHub
gaurav-narula commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1590313031 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig, cleanerManager.removeMetrics()

Re: [PR] KAFKA-9401: Reduce contention for Fetch requests [kafka]

2024-05-05 Thread via GitHub
gaurav-narula commented on code in PR #15836: URL: https://github.com/apache/kafka/pull/15836#discussion_r1590274476 ## core/src/main/scala/kafka/server/FetchSession.scala: ## @@ -787,9 +803,37 @@ class FetchSessionCache(private val maxEntries: Int, } } } +object

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590273427 ## core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java: ## @@ -42,4 +42,5 @@ boolean autoStart() default true; // Set default server

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu commented on PR #15861: URL: https://github.com/apache/kafka/pull/15861#issuecomment-2094744565 updated and `./gradlew clean core:test --tests ClusterTestExtensionsTest --tests ClusterConfigTest` passed -- This is an automated message from the Apache Git Service. To respond

[PR] Wall-Clock based Windowing / Suppression [kafka]

2024-05-05 Thread via GitHub
eichingertim opened a new pull request, #15864: URL: https://github.com/apache/kafka/pull/15864 The change adds the possibility to suppress events during windowing based on WALL_CLOCK_TIME instead of STREAM_CLOCK_TIME. **Problem Statement**: In our use case we needed this

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590270528 ## core/src/test/java/kafka/test/annotation/ClusterConfigDisplayTag.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590270405 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -152,6 +154,9 @@ public MetadataVersion metadataVersion() { public Map> perBrokerOverrideProperties()

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590267358 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -152,6 +154,9 @@ public MetadataVersion metadataVersion() { public Map>

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590267137 ## core/src/test/java/kafka/test/annotation/ClusterConfigDisplayTag.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590266910 ## core/src/test/java/kafka/test/annotation/ClusterTest.java: ## @@ -44,4 +44,5 @@ String listener() default ""; MetadataVersion metadataVersion()

Re: [PR] [WIP] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590262208 ## core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java: ## @@ -42,4 +42,5 @@ boolean autoStart() default true; // Set default server

[PR] KAFKA-16652: add unit test for ClusterTemplate offering zero ClusterConfig [kafka]

2024-05-05 Thread via GitHub
TaiJuWu opened a new pull request, #15862: URL: https://github.com/apache/kafka/pull/15862 *More detailed description of your change, refactor processClusterTemplate and add unit test for empty config *Summary of testing strategy (including rationale) ### Committer

[PR] [WIP] Kafka-16668: improve cluster test [kafka]

2024-05-05 Thread via GitHub
johnnychhsu opened a new pull request, #15861: URL: https://github.com/apache/kafka/pull/15861 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1590222768 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java: ## @@ -430,7 +430,7 @@ private void printStates(Map states) {

Re: [PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-05-05 Thread via GitHub
ocadaruma commented on PR #15571: URL: https://github.com/apache/kafka/pull/15571#issuecomment-2094651947 @chia7712 Thank you for pointing out. Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-05-05 Thread via GitHub
ocadaruma commented on code in PR #15571: URL: https://github.com/apache/kafka/pull/15571#discussion_r1590220877 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1558,4 +1561,68 @@ public void testSSLEngineCloseInboundInvokedOnClose()

Re: [PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15571: URL: https://github.com/apache/kafka/pull/15571#discussion_r1590217930 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1558,4 +1561,68 @@ public void testSSLEngineCloseInboundInvokedOnClose()

Re: [PR] MINOR: Replaced Utils.join() with JDK API. [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15823: URL: https://github.com/apache/kafka/pull/15823#discussion_r1590216139 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -536,7 +537,7 @@ private static ArgumentParser argParser() {