[jira] [Updated] (KAFKA-16692) InvalidRequestException: ADD_PARTITIONS_TO_TXN with version 4 which is not enabled when

2024-05-08 Thread Johnson Okorie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnson Okorie updated KAFKA-16692: --- Affects Version/s: 3.6.1 (was: 3.6.2) > InvalidRequestException:

[jira] [Updated] (KAFKA-16692) InvalidRequestException: ADD_PARTITIONS_TO_TXN with version 4 which is not enabled when

2024-05-08 Thread Johnson Okorie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnson Okorie updated KAFKA-16692: --- Description: We have a kafka cluster running on version 3.5.2 that we are upgrading to

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-08 Thread via GitHub
gaurav-narula commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2100220810 > Before merging this PR, I want to know which `timerTask` gets hanging when shutdown. Do you have any idea? I don't unfortunately but I see you're trying to investigate that

[jira] [Created] (KAFKA-16692) InvalidRequestException: ADD_PARTITIONS_TO_TXN with version 4 which is not enabled when

2024-05-08 Thread Johnson Okorie (Jira)
Johnson Okorie created KAFKA-16692: -- Summary: InvalidRequestException: ADD_PARTITIONS_TO_TXN with version 4 which is not enabled when Key: KAFKA-16692 URL: https://issues.apache.org/jira/browse/KAFKA-16692

Re: [PR] KAFKA-16643 Fix chaos modifier [kafka]

2024-05-08 Thread via GitHub
chia7712 commented on PR #15890: URL: https://github.com/apache/kafka/pull/15890#issuecomment-2100176348 @gongxuanzhang thanks for this patch. Could you take a look at https://issues.apache.org/jira/browse/KAFKA-10787? Personally, we should introduce the new checkstyle file. And then we

Re: [PR] KAFKA-10199: Handle assignment with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
lucasbru commented on code in PR #15882: URL: https://github.com/apache/kafka/pull/15882#discussion_r1593738288 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -544,69 +585,78 @@ private void handleReassignedActiveTask(final Task

Re: [PR] MINOR: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-08 Thread via GitHub
chia7712 commented on code in PR #15868: URL: https://github.com/apache/kafka/pull/15868#discussion_r1593737692 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java: ## @@ -115,11 +112,11 @@ public void

[jira] [Commented] (KAFKA-16643) Add ModifierOrder checkstyle rule

2024-05-08 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844598#comment-17844598 ] xuanzhang gong commented on KAFKA-16643: I have finished this modification task

Re: [PR] Allowing WriteTxnMarkers API to run with AlterCluster permissions [kafka]

2024-05-08 Thread via GitHub
sidyag commented on code in PR #15837: URL: https://github.com/apache/kafka/pull/15837#discussion_r1593693523 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging { } @Test - def

Re: [PR] KAFKA-14588 [2/N] ConfigCommandTest rewritten in java [kafka]

2024-05-08 Thread via GitHub
chia7712 commented on code in PR #15873: URL: https://github.com/apache/kafka/pull/15873#discussion_r1593681340 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-05-08 Thread via GitHub
clolov commented on code in PR #15673: URL: https://github.com/apache/kafka/pull/15673#discussion_r1593670905 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -717,7 +717,7 @@ public void testUnregisterBroker() throws Throwable {

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-05-08 Thread via GitHub
clolov commented on code in PR #15673: URL: https://github.com/apache/kafka/pull/15673#discussion_r1593668135 ## metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java: ## @@ -283,7 +283,7 @@ private static Stream

Re: [PR] KAFKA-16679 merge unit test down to the class of integration test [kafka]

2024-05-08 Thread via GitHub
showuon commented on code in PR #15884: URL: https://github.com/apache/kafka/pull/15884#discussion_r1593636792 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) { int pos =

[PR] KAFKA-10199: Shutdown with new remove operation in state updater [kafka]

2024-05-08 Thread via GitHub
cadonna opened a new pull request, #15894: URL: https://github.com/apache/kafka/pull/15894 Uses the new remove operation of the state updater that returns a future to shutdown the task manager. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Comment Edited] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-08 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844579#comment-17844579 ] FTR edited comment on KAFKA-16687 at 5/8/24 8:09 AM: - Update: Testing longer for

[jira] [Resolved] (KAFKA-16640) Replace TestUtils#resource by scala.util.Using

2024-05-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16640. Fix Version/s: 3.8.0 Resolution: Fixed > Replace TestUtils#resource by

Re: [PR] KAFKA-16640: Replace TestUtils#resource by scala.util.Using [kafka]

2024-05-08 Thread via GitHub
chia7712 merged PR #15881: URL: https://github.com/apache/kafka/pull/15881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-08 Thread via GitHub
cadonna merged PR #15871: URL: https://github.com/apache/kafka/pull/15871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-08 Thread via GitHub
rishiraj88 commented on code in PR #15871: URL: https://github.com/apache/kafka/pull/15871#discussion_r1593553420 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -623,6 +623,21 @@ private void addToTasksToClose(final Map> futures,

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-08 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844579#comment-17844579 ] FTR commented on KAFKA-16687: - Update: Testing longer for 3.6.0, the resident memory of Java App proccess

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-08 Thread via GitHub
lucasbru merged PR #15874: URL: https://github.com/apache/kafka/pull/15874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-08 Thread via GitHub
lucasbru commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099949443 https://confluent-kafka-branch-builder-system-test-results-v2.s3-us-west-2.amazonaws.com/trunk/2024-05-07--001./report.html -- This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-16511) Leaking tiered segments

2024-05-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16511: -- Fix Version/s: 3.7.1 > Leaking tiered segments > --- > > Key:

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593525765 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-08 Thread via GitHub
showuon merged PR #15817: URL: https://github.com/apache/kafka/pull/15817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-08 Thread via GitHub
showuon commented on PR #15817: URL: https://github.com/apache/kafka/pull/15817#issuecomment-2099912904 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593511224 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-05-08 Thread via GitHub
raminqaf commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1593500243 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -221,41 +199,28 @@ private void emitNonJoinedOuterRecords(

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

[jira] [Comment Edited] (KAFKA-16656) Using a custom replication.policy.separator with DefaultReplicationPolicy

2024-05-08 Thread Lenin Joseph (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844529#comment-17844529 ] Lenin Joseph edited comment on KAFKA-16656 at 5/8/24 6:47 AM: -- Hi

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

Re: [PR] KAFKA-16679 merge unit test down to the class of integration test [kafka]

2024-05-08 Thread via GitHub
KevinZTW commented on code in PR #15884: URL: https://github.com/apache/kafka/pull/15884#discussion_r1593470507 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) { int pos =

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-08 Thread via GitHub
kamalcph commented on PR #15825: URL: https://github.com/apache/kafka/pull/15825#issuecomment-2099844734 > Thanks for the PR. One question: So when we temporarily set high-watermark as ` LogOffsetMetadata(0)` for the leader, we're waiting for the high-watermark gets updated after followers

[PR] KAFKA-16691: [connect:transform] Support nested field paths on TimestampConverter [kafka]

2024-05-08 Thread via GitHub
jeqo opened a new pull request, #15893: URL: https://github.com/apache/kafka/pull/15893 [KAFKA-16691] --- ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

<    1   2