jolshan merged PR #15971:
URL: https://github.com/apache/kafka/pull/15971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847482#comment-17847482
]
bboyleonp commented on KAFKA-16791:
---
Hi [~chia7712], I am interested in this one. May I take it?
ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1605660608
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -472,23 +482,74 @@ public GroupAssignment assign(final
ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1605659907
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -472,23 +482,74 @@ public GroupAssignment assign(final
ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1605659120
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -472,23 +482,74 @@ public GroupAssignment assign(final
ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1605656530
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -472,23 +482,74 @@ public GroupAssignment assign(final
ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1605639072
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -472,23 +482,74 @@ public GroupAssignment assign(final
kirktrue commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2118579935
@lianetm @cadonna—I believe I have addressed all the actionable feedback.
Are there additional concerns about this PR that prevent it from being merged?
Thanks.
--
This is an
kirktrue commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2118578191
> Hey @cadonna, the tricky bit is that, for some events, the request
managers do expire requests too, so in this flow you described:
>
> > The event is processed in the
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605528394
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
jeffkbkim commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1605535757
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -59,7 +59,7 @@ public class
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605530429
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605530429
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605528394
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605525333
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
jeffkbkim commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605519141
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -61,8 +61,11 @@ public
dongnuo123 opened a new pull request, #15988:
URL: https://github.com/apache/kafka/pull/15988
This patch implements the heartbeat api to the members that use the classic
protocol in a ConsumerGroup.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
Dongnuo Lyu created KAFKA-16793:
---
Summary: Heartbeat API for upgrading ConsumerGroup
Key: KAFKA-16793
URL: https://issues.apache.org/jira/browse/KAFKA-16793
Project: Kafka
Issue Type: Sub-task
chia7712 merged PR #15865:
URL: https://github.com/apache/kafka/pull/15865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaurav-narula commented on code in PR #15987:
URL: https://github.com/apache/kafka/pull/15987#discussion_r1605472276
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -475,9 +478,7 @@ public void
chia7712 merged PR #15933:
URL: https://github.com/apache/kafka/pull/15933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15723.
Fix Version/s: 3.8.0
Resolution: Fixed
> KRaft support in ListOffsetsRequestTest
>
chia7712 merged PR #15980:
URL: https://github.com/apache/kafka/pull/15980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16544.
Fix Version/s: 3.8
Resolution: Fixed
> DescribeTopicsResult#allTopicIds and
chia7712 merged PR #15979:
URL: https://github.com/apache/kafka/pull/15979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15942:
URL: https://github.com/apache/kafka/pull/15942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16792:
---
Summary: Enable consumer unit tests that fail to fetch offsets only for new
consumer with
[
https://issues.apache.org/jira/browse/KAFKA-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-16764:
--
Assignee: appchemist
> New consumer should throw InvalidTopicException on poll when
[
https://issues.apache.org/jira/browse/KAFKA-16764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847427#comment-17847427
]
Lianet Magrans commented on KAFKA-16764:
Sure! Thanks for helping out! Follow-up on the PR.
>
Lianet Magrans created KAFKA-16792:
--
Summary: Enable related unit tests that fail only for new consumer
with to poll(0)
Key: KAFKA-16792
URL: https://issues.apache.org/jira/browse/KAFKA-16792
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16792:
---
Summary: Enable related unit tests that fail to fetch offsets only for new
consumer with to
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16792:
---
Description:
Enable the following unit tests for the new async consumer in
Chia-Ping Tsai created KAFKA-16791:
--
Summary: Add thread detection to ClusterTestExtensions
Key: KAFKA-16791
URL: https://issues.apache.org/jira/browse/KAFKA-16791
Project: Kafka
Issue
jeffkbkim opened a new pull request, #15987:
URL: https://github.com/apache/kafka/pull/15987
DelayEventAccumulator should return immediately if there are no events in
the queue. Also removed some unused fields inside EventProcessorThread
### Committer Checklist (excluded from commit
chia7712 merged PR #15982:
URL: https://github.com/apache/kafka/pull/15982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15977:
URL: https://github.com/apache/kafka/pull/15977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15984:
URL: https://github.com/apache/kafka/pull/15984#discussion_r1605427011
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1872,7 +1872,7 @@ object TestUtils extends Logging {
mimaison commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1605420401
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -1538,7 +1563,80 @@ class LogValidatorTest {
assertEquals(e.recordErrors.size, 3)
}
-
jeffkbkim commented on PR #15970:
URL: https://github.com/apache/kafka/pull/15970#issuecomment-2118184548
RangeAssignor baseline
```
Benchmark (memberCount)
(partitionsToMemberRatio) (topicCount) Mode CntScoreError Units
dajac commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1605415364
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -147,6 +147,11 @@ public static class DeadlineAndEpoch {
[
https://issues.apache.org/jira/browse/KAFKA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847392#comment-17847392
]
Muralidhar Basani commented on KAFKA-16790:
---
Even though brokerMetadataPublisher is
[
https://issues.apache.org/jira/browse/KAFKA-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847391#comment-17847391
]
Johnson Okorie commented on KAFKA-16692:
Hi [~jolshan], I wanted to express my sincere thanks
rreddy-22 commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1605382569
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -147,6 +147,11 @@ public static class DeadlineAndEpoch {
junrao commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1605350575
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -110,40 +111,43 @@ public String toString() {
protected void
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1605371498
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -62,10 +63,10 @@ public class ClusterTestExtensionsTest {
}
// Static methods can
[
https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847386#comment-17847386
]
Phuc Hong Tran commented on KAFKA-14517:
[~lianetm] I’m in the process of implementing this one
[
https://issues.apache.org/jira/browse/KAFKA-16788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847385#comment-17847385
]
Ashok commented on KAFKA-16788:
---
[~gharris1727] Thanks. yes, I am working on the fix. I will raise a PR
[
https://issues.apache.org/jira/browse/KAFKA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847384#comment-17847384
]
Muralidhar Basani commented on KAFKA-16790:
---
[~christo_lolov] can I look into this issue ?
>
chia7712 merged PR #15976:
URL: https://github.com/apache/kafka/pull/15976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847383#comment-17847383
]
Greg Harris commented on KAFKA-16788:
-
Nice find [~ashok89]! Are you interested in working on a fix
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1605365153
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chia7712 commented on code in PR #15946:
URL: https://github.com/apache/kafka/pull/15946#discussion_r1605361253
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -240,28 +215,61 @@ public void startBroker(int brokerId) {
@Override
[
https://issues.apache.org/jira/browse/KAFKA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-16790:
--
Description:
BrokerMetadataPublisher#onMetadataUpdate calls ReplicaManager#applyDelta (1)
[
https://issues.apache.org/jira/browse/KAFKA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-16790:
--
Description:
BrokerMetadataPublisher#onMetadataUpdate calls ReplicaManager#applyDelta (1)
prestona commented on PR #15910:
URL: https://github.com/apache/kafka/pull/15910#issuecomment-2118027385
Hi @gharris1727, hopefully the latest commits address your review comments.
Once again, really appreciate all your feedback and suggestions.
--
This is an automated message from the
Christo Lolov created KAFKA-16790:
-
Summary: Calls to RemoteLogManager are made before it is configured
Key: KAFKA-16790
URL: https://issues.apache.org/jira/browse/KAFKA-16790
Project: Kafka
junrao commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1605313096
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -1538,7 +1563,80 @@ class LogValidatorTest {
assertEquals(e.recordErrors.size, 3)
}
-
jsancio opened a new pull request, #15986:
URL: https://github.com/apache/kafka/pull/15986
DRAFT
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
[
https://issues.apache.org/jira/browse/KAFKA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16763.
Fix Version/s: 3.8.0
Resolution: Fixed
> Upgrade to scala 2.12.19 and scala
chia7712 merged PR #15958:
URL: https://github.com/apache/kafka/pull/15958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847369#comment-17847369
]
Lianet Magrans commented on KAFKA-14517:
hey [~phuctran], [~dajac] , I would like to take on
[
https://issues.apache.org/jira/browse/KAFKA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16774:
---
Fix Version/s: 3.8.0
> fix flaky
[
https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-16758:
--
Assignee: Lianet Magrans
> Extend Consumer#close with option to leave the group or
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847366#comment-17847366
]
Chia-Ping Tsai commented on KAFKA-15197:
It seems that behavior is expected.
The check assumes
dajac commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1605223809
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -65,4 +65,33 @@ protected static Set
[
https://issues.apache.org/jira/browse/KAFKA-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847352#comment-17847352
]
Justine Olshan commented on KAFKA-16692:
[~soarez] I'd like to try to get this fix into 3.7.1
[
https://issues.apache.org/jira/browse/KAFKA-16333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847348#comment-17847348
]
Muralidhar Basani commented on KAFKA-16333:
---
Agree. thanks.
> Removed Deprecated methods
lianetm commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2117763853
Hey @cadonna, the tricky bit is that, for some events, the request managers
do expire requests too, so in this flow you described:
> The event is processed in the
appchemist commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2117739675
@lianetm & @philipnee PTAL
`testSubscriptionOnInvalidTopic` is still disabled for new consumer.
I couldn't make the changes because `MockMetadataUpdater` is being used
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847334#comment-17847334
]
Lucas Brutschy edited comment on KAFKA-12679 at 5/17/24 2:26 PM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847334#comment-17847334
]
Lucas Brutschy edited comment on KAFKA-12679 at 5/17/24 2:20 PM:
-
Hey
mimaison commented on PR #15985:
URL: https://github.com/apache/kafka/pull/15985#issuecomment-2117717230
@viktorsomogyi IIRC you volunteered to do the migration work to log4j2 a
while back. Are you still able/willing to do so for Kafka 4.0?
@jlprat As there's a chance 3.8 will be the
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-12679:
---
Fix Version/s: 3.8.0
(was: 3.7.0)
> Rebalancing a restoring or
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847334#comment-17847334
]
Lucas Brutschy commented on KAFKA-12679:
Hey [~coltmcnealy-lh]. It is true that the state
[
https://issues.apache.org/jira/browse/KAFKA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16762.
-
Fix Version/s: 3.8.0
Reviewer: David Jacot
Resolution: Fixed
> SyncGroup API
mimaison opened a new pull request, #15985:
URL: https://github.com/apache/kafka/pull/15985
As per KIP-719, KafkaLog4jAppender is now deprecated and will be removed in
Kafka 4.0. Users should migrate to the log4j2 Kafka Appender
### Committer Checklist (excluded from commit message)
dajac merged PR #15954:
URL: https://github.com/apache/kafka/pull/15954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16784:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> Migrate
gaurav-narula opened a new pull request, #15984:
URL: https://github.com/apache/kafka/pull/15984
Updates `TestUtils::verifyNoUnexpectedThreads` to check for all event queue
threads instead of the incorrect QuorumController thread.
Also updated `KafkaEventQueueTest` to use
mimaison commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2117661783
@linzihao1999 Can you follow up this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lianetm commented on PR #15965:
URL: https://github.com/apache/kafka/pull/15965#issuecomment-2117652874
Thanks for the helpful comment @lucasbru , addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lianetm commented on code in PR #15965:
URL: https://github.com/apache/kafka/pull/15965#discussion_r1605041571
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala:
##
@@ -84,29 +84,87 @@ class PlaintextConsumerCallbackTest extends
mimaison commented on PR #15277:
URL: https://github.com/apache/kafka/pull/15277#issuecomment-2117650240
@highluck Can you address the pending comments and rebase on trunk to
resolve the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1605020116
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoin.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation
cadonna commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1604937635
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -187,17 +157,25 @@ public void process(final Record record) {
Gaurav Narula created KAFKA-16789:
-
Summary: Thread leak detection checks for incorrect
QuorumController thread name
Key: KAFKA-16789
URL: https://issues.apache.org/jira/browse/KAFKA-16789
Project:
[
https://issues.apache.org/jira/browse/KAFKA-16789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-16789:
-
Assignee: Gaurav Narula
> Thread leak detection checks for incorrect QuorumController
[
https://issues.apache.org/jira/browse/KAFKA-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847294#comment-17847294
]
Muralidhar Basani commented on KAFKA-16448:
---
Thanks [~mjsax]
[~lmunoz] if there any sub
[
https://issues.apache.org/jira/browse/KAFKA-16784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847272#comment-17847272
]
PoAn Yang commented on KAFKA-16784:
---
Hi [~chia7712], I'm interested in this issue. May I take it?
lucasbru commented on PR #14216:
URL: https://github.com/apache/kafka/pull/14216#issuecomment-2117519600
@mimaison -- Let me test this. Yes, I see that also the version of requests
inside ducktape was reverted:
FrankYang0529 opened a new pull request, #15983:
URL: https://github.com/apache/kafka/pull/15983
* Replace `TopicBasedRemoteLogMetadataManagerWrapperWithHarness` with
`RemoteLogMetadataManagerTestUtils#builder` in `RemoteLogMetadataManagerTest`.
* Use `ClusterTestExtention` for
mimaison commented on PR #14216:
URL: https://github.com/apache/kafka/pull/14216#issuecomment-2117500715
Thanks @lucasbru !
I wonder if we also need to bump ducktape to 0.11.4 as it's seems previous
versions depend on requests<2.31.0:
lucasbru commented on PR #14216:
URL: https://github.com/apache/kafka/pull/14216#issuecomment-2117489283
@mimaison I remember I had problems running the system tests with that
version, but I don't think I intended merging the version change. Sorry for
that, I'll test the newer version and
gaurav-narula opened a new pull request, #15982:
URL: https://github.com/apache/kafka/pull/15982
Ensures we close resources even if an exception is thrown within a test.
Also added an `@AfterAll` to ensure threads aren't leaked from the test class.
### Committer Checklist (excluded
vamossagar12 commented on PR #15305:
URL: https://github.com/apache/kafka/pull/15305#issuecomment-2117312634
Thanks @gharris1727 for another round of review. I have made the changes.
Please review when you have some time.
--
This is an automated message from the Apache Git Service.
To
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1604768491
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java:
##
@@ -267,6 +268,20 @@ public String memberId() {
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1604767686
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -850,6 +855,46 @@ public void testRequestTimeouts()
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1604759527
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerRebalanceListener.java:
##
@@ -36,4 +37,15 @@ public interface
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1604757990
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -2704,6 +2704,11 @@ public void onRevoked(String
Ashok created KAFKA-16788:
-
Summary: Resource leakage due to absence of close() call on
connector start failure
Key: KAFKA-16788
URL: https://issues.apache.org/jira/browse/KAFKA-16788
Project: Kafka
1 - 100 of 114 matches
Mail list logo
