[PR] KAFKA-16784: Migrate TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest to use ClusterTestExtensions [kafka]

2024-05-18 Thread via GitHub
FrankYang0529 opened a new pull request, #15992: URL: https://github.com/apache/kafka/pull/15992 * Replace `TopicBasedRemoteLogMetadataManagerHarness` with `RemoteLogMetadataManagerTestUtils#builder` in `TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest`. * Use

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-05-18 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847617#comment-17847617 ] Kuan Po Tseng commented on KAFKA-16414: --- c.c. [~showuon] , any thoughts on this one ? Would be

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-05-18 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847616#comment-17847616 ] Kuan Po Tseng commented on KAFKA-16414: --- I'm still waiting for other Kafka PMC members/committers

Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]

2024-05-18 Thread via GitHub
brandboat commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605934347 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic

Re: [PR] KAFKA-15307: Update/errors for deprecated config [kafka]

2024-05-18 Thread via GitHub
mjsax commented on code in PR #14448: URL: https://github.com/apache/kafka/pull/14448#discussion_r1605892956 ## docs/streams/developer-guide/config-streams.html: ## @@ -261,10 +261,10 @@ num.standby.replicasstatestore.cache.max.bytes Medium -Maximum

Re: [PR] MINOR: Fix warnings in streams javadoc [kafka]

2024-05-18 Thread via GitHub
mjsax commented on PR #15955: URL: https://github.com/apache/kafka/pull/15955#issuecomment-2118998403 Thanks for the cleanup! Highly appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-18 Thread via GitHub
rreddy-22 commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1605859034 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -59,7 +59,7 @@ public class

Re: [PR] KAFKA-16789: Fix thread leak detection for event handler threads [kafka]

2024-05-18 Thread via GitHub
chia7712 commented on PR #15984: URL: https://github.com/apache/kafka/pull/15984#issuecomment-2118911871 I will merge this PR after QA gets work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-16790) Calls to RemoteLogManager are made before it is configured

2024-05-18 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847584#comment-17847584 ] Muralidhar Basani commented on KAFKA-16790: --- After abit further digging ->

Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]

2024-05-18 Thread via GitHub
chia7712 commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605853497 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic

[jira] [Assigned] (KAFKA-16791) Add thread detection to ClusterTestExtensions

2024-05-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16791: -- Assignee: bboyleonp (was: Chia-Ping Tsai) > Add thread detection to

[jira] [Commented] (KAFKA-15242) FixedKeyProcessor testing is unusable

2024-05-18 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847562#comment-17847562 ] Matej Sprysl commented on KAFKA-15242: -- Since `FixedKeyProcessor` and `FixedKeyRecord`, and even

[jira] [Comment Edited] (KAFKA-15242) FixedKeyProcessor testing is unusable

2024-05-18 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847562#comment-17847562 ] Matej Sprysl edited comment on KAFKA-15242 at 5/18/24 4:15 PM: --- Since

[PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]

2024-05-18 Thread via GitHub
brandboat opened a new pull request, #15991: URL: https://github.com/apache/kafka/pull/15991 https://github.com/apache/kafka/commit/0bf830fc9c3915bc99b6e487e6083dabd593c5d3 moved DefaultMessageFormatter package from `kafka.tools` to `org.apache.kafka.tools.consumer` ### Committer

[jira] [Assigned] (KAFKA-16786) New consumer subscribe should not require the deprecated partition.assignment.strategy

2024-05-18 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16786: -- Assignee: Phuc Hong Tran > New consumer subscribe should not require the deprecated

Re: [PR] KAFKA-16429: Enhance all configs which can trigger rolling of new segment [kafka]

2024-05-18 Thread via GitHub
brandboat commented on PR #15990: URL: https://github.com/apache/kafka/pull/15990#issuecomment-2118751316 Apologies for the late pr, gentle ping @showuon , @chia7712 , @jeqo . Could you take a look when you are available ? Many thanks  -- This is an automated message from the Apache

[PR] KAFKA-16429: Enhance all configs which can trigger rolling of new segment [kafka]

2024-05-18 Thread via GitHub
brandboat opened a new pull request, #15990: URL: https://github.com/apache/kafka/pull/15990 related to https://issues.apache.org/jira/browse/KAFKA-16429. Update the document about broker/topic side retention and segment configurations. ### Committer Checklist (excluded from

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-18 Thread via GitHub
chiacyu commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1605700828 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig, cleanerManager.removeMetrics() Review

[PR] KAFKA-16223: Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest [kafka]

2024-05-18 Thread via GitHub
chiacyu opened a new pull request, #15989: URL: https://github.com/apache/kafka/pull/15989 This pr cleans the powermock and easymock in KafkaConfigBackingStoreTest and I also write the corresponding tests with Mockito. Thanks. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-18 Thread via GitHub
TaiJuWu commented on code in PR #15916: URL: https://github.com/apache/kafka/pull/15916#discussion_r1605682673 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -122,31 +115,57 @@ public Stream provideTestTemplateInvocationContex return