[jira] [Created] (KAFKA-16811) Punctuate Ratio metric almost impossible to track

2024-05-21 Thread Sebastien Viale (Jira)
Sebastien Viale created KAFKA-16811: --- Summary: Punctuate Ratio metric almost impossible to track Key: KAFKA-16811 URL: https://issues.apache.org/jira/browse/KAFKA-16811 Project: Kafka Issue

[jira] [Commented] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848471#comment-17848471 ] Luke Chen commented on KAFKA-16807: --- Set as blocker for v3.7.1 and v3.8.0 since users

[jira] [Updated] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16807: -- Priority: Blocker (was: Minor) > DescribeLogDirsResponseData#results#topics have unexpected topics ha

[jira] [Updated] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16807: -- Fix Version/s: 3.8.0 3.7.1 > DescribeLogDirsResponseData#results#topics have unexpe

Re: [PR] KAFKA-15541: Add num-open-iterators metric [kafka]

2024-05-21 Thread via GitHub
mjsax commented on PR #15975: URL: https://github.com/apache/kafka/pull/15975#issuecomment-2123976338 Merged to `trunk` to make progress on the implementation of the KIP. About testing: I agree that we might not need to test every method which creates an iterator, but it would be grea

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15541: Add num-open-iterators metric [kafka]

2024-05-21 Thread via GitHub
mjsax merged PR #15975: URL: https://github.com/apache/kafka/pull/15975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
showuon commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123949904 Forgot to say, thanks for closing all the `ConsumerGroupService` instances. I can't believe we leak these resources before. -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
showuon commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123948788 One high-level question: I found after this change, we increased the test case numbers from 492 -> 660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we really need

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609312616 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15908: URL: https://github.com/apache/kafka/pull/15908#discussion_r1609296852 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -92,6 +94,7 @@ static void generator(ClusterGenerator clusterGene

[jira] [Commented] (KAFKA-16810) Improve kafka-consumer-perf-test to benchmark single partition

2024-05-21 Thread Harsh Panchal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848455#comment-17848455 ] Harsh Panchal commented on KAFKA-16810: --- PR: https://github.com/apache/kafka/pull/

[jira] [Created] (KAFKA-16810) Improve kafka-consumer-perf-test to benchmark single partition

2024-05-21 Thread Harsh Panchal (Jira)
Harsh Panchal created KAFKA-16810: - Summary: Improve kafka-consumer-perf-test to benchmark single partition Key: KAFKA-16810 URL: https://issues.apache.org/jira/browse/KAFKA-16810 Project: Kafka

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
omkreddy merged PR #15927: URL: https://github.com/apache/kafka/pull/15927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Aesthetic, Uniformity Changes and Reducing warnings [kafka]

2024-05-21 Thread via GitHub
rreddy-22 opened a new pull request, #16026: URL: https://github.com/apache/kafka/pull/16026 Went through all the files in the group coordinator module and fixed up a few minor warnings and cleaned up a few leftover errors. Also fixed the formatting to make it more uniform -- This is

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1609228927 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,16 +2114,12 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _ =>

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on PR #15825: URL: https://github.com/apache/kafka/pull/15825#issuecomment-2123824613 @junrao @showuon Thanks for the review! Addressed all the review comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609227442 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new OffsetOutOfRangeException

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609227180 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new OffsetOutOfRangeException

[jira] [Commented] (KAFKA-16662) UnwritableMetadataException: Metadata has been lost

2024-05-21 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848436#comment-17848436 ] Jianbin Chen commented on KAFKA-16662: -- After I deleted all of the __cluster_metada

Re: [PR] KAFKA-16783: Migrate RemoteLogMetadataManagerTest to new test infra [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on PR #15983: URL: https://github.com/apache/kafka/pull/15983#issuecomment-2123808122 > I think we can file another PR to improve it, either we add a future.get(30 sec), or we set a global @timeout tag on the test class to limit the waiting time. I love the idea ab

[jira] [Commented] (KAFKA-16662) UnwritableMetadataException: Metadata has been lost

2024-05-21 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848434#comment-17848434 ] Jianbin Chen commented on KAFKA-16662: -- When I executed ./bin/kafka-features.sh --b

[jira] [Resolved] (KAFKA-16783) Migrate RemoteLogMetadataManagerTest to new test infra

2024-05-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16783. --- Fix Version/s: 3.8.0 Resolution: Fixed > Migrate RemoteLogMetadataManagerTest to new test inf

Re: [PR] KAFKA-16783: Migrate RemoteLogMetadataManagerTest to new test infra [kafka]

2024-05-21 Thread via GitHub
showuon merged PR #15983: URL: https://github.com/apache/kafka/pull/15983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-16662) UnwritableMetadataException: Metadata has been lost

2024-05-21 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848431#comment-17848431 ] Jianbin Chen commented on KAFKA-16662: -- Could someone please pay attention to this

Re: [PR] KAFKA-16308 [1/N]: Create FeatureVersion interface and add `--feature` flag and handling to StorageTool [kafka]

2024-05-21 Thread via GitHub
artemlivshits commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1609158284 ## core/src/main/scala/kafka/server/BrokerFeatures.scala: ## @@ -75,16 +75,19 @@ object BrokerFeatures extends Logging { } def defaultSupportedFeatures(un

Re: [PR] KAFKA-16783: Migrate RemoteLogMetadataManagerTest to new test infra [kafka]

2024-05-21 Thread via GitHub
showuon commented on PR #15983: URL: https://github.com/apache/kafka/pull/15983#issuecomment-2123794220 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Comment Edited] (KAFKA-16662) UnwritableMetadataException: Metadata has been lost

2024-05-21 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848424#comment-17848424 ] Jianbin Chen edited comment on KAFKA-16662 at 5/22/24 3:10 AM: ---

Re: [PR] KAFKA-16771 First log directory printed twice when formatting storage [kafka]

2024-05-21 Thread via GitHub
gongxuanzhang commented on code in PR #16010: URL: https://github.com/apache/kafka/pull/16010#discussion_r1609198047 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,19 +452,20 @@ object StorageTool extends Logging { stream.println("All of the log director

[jira] [Commented] (KAFKA-16662) UnwritableMetadataException: Metadata has been lost

2024-05-21 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848424#comment-17848424 ] Jianbin Chen commented on KAFKA-16662: -- I have encountered the same issue. Can anyo

Re: [PR] KAFKA-16669: Remove extra collection copy when generating DescribeAclsResource [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15924: URL: https://github.com/apache/kafka/pull/15924#discussion_r1609187500 ## core/src/main/scala/kafka/server/AclApis.scala: ## @@ -69,7 +69,7 @@ class AclApis(authHelper: AuthHelper, case Some(auth) => val filter = describeAc

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609081346 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16795: Fix broken compatibility in kafka.tools.NoOpMessageFormatter, kafka.tools.DefaultMessageFormatter, and kafka.tools.LoggingMessageFormatter [kafka]

2024-05-21 Thread via GitHub
brandboat commented on PR #16020: URL: https://github.com/apache/kafka/pull/16020#issuecomment-2123611516 > The benefit of this approach is that we don't need to add removed class back. WDYT? This one is way better, thanks ! -- This is an automated message from the Apache Git Serv

[jira] [Commented] (KAFKA-16798) Mirrormaker2 dedicated mode - sync.group.offsets.interval not working

2024-05-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848404#comment-17848404 ] Greg Harris commented on KAFKA-16798: - Hi [~sektor.coder] thanks for the ticket! Th

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1609062958 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -105,12 +106,19 @@ private KafkaBasedLog createBackingStore(MirrorCheck

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-05-21 Thread via GitHub
junrao commented on PR #15673: URL: https://github.com/apache/kafka/pull/15673#issuecomment-2123590782 @clolov : 3.8.0 feature freeze is about 1 week away. It would be useful to get this PR in before the 3.8 branch is cut. Any updates on this PR? What's an example of the failed test? --

Re: [PR] KAFKA-16541 Fix potential leader-epoch checkpoint file corruption [kafka]

2024-05-21 Thread via GitHub
junrao commented on code in PR #15993: URL: https://github.com/apache/kafka/pull/15993#discussion_r1609025456 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -2095,7 +2101,8 @@ object UnifiedLog extends Logging { } /** - * If the recordVersion is >= RecordVers

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on PR #16006: URL: https://github.com/apache/kafka/pull/16006#issuecomment-2123537218 Tests should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on PR #15910: URL: https://github.com/apache/kafka/pull/15910#issuecomment-2123528226 @gharris1727 I gave up and used the ugly try. That warning is not occurring in every test... But I went all the way in `OffsetSyncStoreTest` as I prefer consistency to beauty.

Re: [PR] KAFKA-16626: Lazily convert subscribed topic names to topic ids [kafka]

2024-05-21 Thread via GitHub
jeffkbkim commented on PR #15970: URL: https://github.com/apache/kafka/pull/15970#issuecomment-2123510093 @dajac thanks for the review. I have addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
junrao commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608986312 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new OffsetOutOfRangeException(s

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
junrao commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608984545 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new OffsetOutOfRangeException(s

[jira] [Comment Edited] (KAFKA-16779) Kafka retains logs past specified retention

2024-05-21 Thread Nicholas Feinberg (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847997#comment-17847997 ] Nicholas Feinberg edited comment on KAFKA-16779 at 5/21/24 9:41 PM: --

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608965614 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() { @Test

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608959573 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() { @Test

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608950503 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package org.apache.kafka.streams.pro

[PR] KAFKA-16809: Run Javadoc in CI [kafka]

2024-05-21 Thread via GitHub
gharris1727 opened a new pull request, #16025: URL: https://github.com/apache/kafka/pull/16025 Until now, javadoc warnings can be added in PRs, and are only noticed when someone else runs `./gradlew javadoc`. Now introducing problems in javadocs will immediately fail the PR CI build, notify

Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub
gharris1727 merged PR #15940: URL: https://github.com/apache/kafka/pull/15940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub
gharris1727 commented on PR #15940: URL: https://github.com/apache/kafka/pull/15940#issuecomment-2123422940 Build passes, CI test failures appear unrelated, and this passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608934073 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

[jira] [Assigned] (KAFKA-16558) Implement HeartbeatRequestState.toStringBase()

2024-05-21 Thread Brenden DeLuna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden DeLuna reassigned KAFKA-16558: -- Assignee: Brenden DeLuna (was: Kirk True) > Implement HeartbeatRequestState.toString

[jira] [Assigned] (KAFKA-16557) Fix OffsetFetchRequestState.toString()

2024-05-21 Thread Brenden DeLuna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden DeLuna reassigned KAFKA-16557: -- Assignee: Brenden DeLuna (was: Kirk True) > Fix OffsetFetchRequestState.toString() >

[jira] [Assigned] (KAFKA-16000) Migrate MembershipManagerImplTest away from ConsumerTestBuilder

2024-05-21 Thread Brenden DeLuna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden DeLuna reassigned KAFKA-16000: -- Assignee: Brenden DeLuna (was: Kirk True) > Migrate MembershipManagerImplTest away f

[jira] [Assigned] (KAFKA-15999) Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder

2024-05-21 Thread Brenden DeLuna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden DeLuna reassigned KAFKA-15999: -- Assignee: Brenden DeLuna (was: Kirk True) > Migrate HeartbeatRequestManagerTest away

[jira] [Assigned] (KAFKA-16001) Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder

2024-05-21 Thread Brenden DeLuna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brenden DeLuna reassigned KAFKA-16001: -- Assignee: Brenden DeLuna > Migrate ConsumerNetworkThreadTest away from ConsumerTestBu

[jira] [Updated] (KAFKA-16001) Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder

2024-05-21 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16001: --- Description: We should: # Remove spy calls to the dependencies # Remove ConsumerNetworkThreadTest

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
apourchet commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608924234 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package org.apache.kafka.streams.proces

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16006: URL: https://github.com/apache/kafka/pull/16006#discussion_r1608921813 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -350,11 +347,7 @@ class ZkMetadataCache( override def getAliveBrokerNode(brokerId: Int, l

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
apourchet commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608918902 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package org.apache.kafka.streams.proces

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on PR #16008: URL: https://github.com/apache/kafka/pull/16008#issuecomment-2123394515 > Are there any tests that we should add or do the existing test cover this functionality? I think there are some that cover it already, but I added a test of controller failover i

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608917448 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] KAFKA-15045: (KIP-924 pt. 8) Added TopicPartitionAssignmentInfo [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on code in PR #16024: URL: https://github.com/apache/kafka/pull/16024#discussion_r1608911390 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TopicPartitionAssignmentInfo.java: ## @@ -0,0 +1,45 @@ +package org.apache.kafka.streams.pro

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
dongnuo123 commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608908254 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4209,31 +4241,67 @@ private void removePendingSyncMember(

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608907673 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() { @Tes

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608907374 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -313,4 +314,8 @@ class KafkaRaftManager[T]( override def leaderAndEpoch: LeaderAndEpoch = { client.le

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
dongnuo123 commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608907132 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4274,6 +4342,77 @@ private void validateClassicGroupHeartbeat

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608896699 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() { @Tes

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608906143 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -366,4 +368,16 @@ public static VoterSet fromInetSocketAddresses(String listener, Map idToNo

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608904666 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2548,6 +2549,10 @@ public OptionalLong highWatermark() { } } +public Option

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-21 Thread via GitHub
jsancio commented on code in PR #16006: URL: https://github.com/apache/kafka/pull/16006#discussion_r1608902290 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -350,11 +347,7 @@ class ZkMetadataCache( override def getAliveBrokerNode(brokerId: Int, l

Re: [PR] KAFKA-15045: (KIP-924 pt. 6) Post process new assignment structure [kafka]

2024-05-21 Thread via GitHub
ableegoldman merged PR #16002: URL: https://github.com/apache/kafka/pull/16002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15045: (KIP-924 pt. 6) Post process new assignment structure [kafka]

2024-05-21 Thread via GitHub
ableegoldman commented on PR #16002: URL: https://github.com/apache/kafka/pull/16002#issuecomment-2123367972 Test failures are unrelated, merging to trunk Worth noting that the `org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConvergenceTest` did fail, which may s

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
jsancio commented on code in PR #16008: URL: https://github.com/apache/kafka/pull/16008#discussion_r1608891761 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2548,6 +2549,10 @@ public OptionalLong highWatermark() { } } +public Option

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608897877 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608896699 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -82,77 +86,131 @@ public void testOffsetTranslation() { @Tes

[jira] [Created] (KAFKA-16809) Run javadoc build in CI

2024-05-21 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16809: --- Summary: Run javadoc build in CI Key: KAFKA-16809 URL: https://issues.apache.org/jira/browse/KAFKA-16809 Project: Kafka Issue Type: Task Components:

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608875582 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -329,6 +334,17 @@ public void testCommitAsyncWithFencedExceptio

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608870767 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -329,6 +334,17 @@ public void testCommitAsyncWithFencedException

Re: [PR] KAFKA-16713: Define initial set of RPCs for KIP-932 [kafka]

2024-05-21 Thread via GitHub
AndrewJSchofield commented on PR #16022: URL: https://github.com/apache/kafka/pull/16022#issuecomment-2123317868 Yes, we will wait until we cut the 3.8 branch before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-16586) Test TaskAssignorConvergenceTest failing

2024-05-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848363#comment-17848363 ] A. Sophie Blee-Goldman commented on KAFKA-16586: By the way – if this te

[jira] [Commented] (KAFKA-16586) Test TaskAssignorConvergenceTest failing

2024-05-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848358#comment-17848358 ] A. Sophie Blee-Goldman commented on KAFKA-16586: Note: when reporting an

Re: [PR] KAFKA-16516: Fix the controller node provider for broker to control channel [kafka]

2024-05-21 Thread via GitHub
cmccabe commented on PR #16008: URL: https://github.com/apache/kafka/pull/16008#issuecomment-2123296527 I have re-run all the test failures locally, and they all passed (they were flakes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16343: Add unit tests of foreignKeyJoin classes [kafka]

2024-05-21 Thread via GitHub
wcarlson5 merged PR #15564: URL: https://github.com/apache/kafka/pull/15564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-21 Thread via GitHub
rreddy-22 commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1608849959 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -516,16 +522,78 @@ public Assignment targetAssignment(String

Re: [PR] KAFKA-16343: Add unit tests of foreignKeyJoin classes [kafka]

2024-05-21 Thread via GitHub
wcarlson5 commented on PR #15564: URL: https://github.com/apache/kafka/pull/15564#issuecomment-2123293255 The failing tests are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-21 Thread via GitHub
rreddy-22 commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1608849959 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -516,16 +522,78 @@ public Assignment targetAssignment(String

[jira] [Commented] (KAFKA-16586) Test TaskAssignorConvergenceTest failing

2024-05-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848351#comment-17848351 ] A. Sophie Blee-Goldman commented on KAFKA-16586: Failed again:   {code:

[jira] [Commented] (KAFKA-14517) Implement regex subscriptions

2024-05-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848348#comment-17848348 ] Lianet Magrans commented on KAFKA-14517: Sure, I'll assign it to me then. Thanks

[jira] [Assigned] (KAFKA-14517) Implement regex subscriptions

2024-05-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-14517: -- Assignee: Lianet Magrans (was: Phuc Hong Tran) > Implement regex subscriptions > ---

  1   2   3   >