frankvicky opened a new pull request, #16163:
URL: https://github.com/apache/kafka/pull/16163
Fix the bug where the group downgrade to a classic one when a member leaves,
even though the consumer group size is still larger than `classicGroupMaxSize`.
### Committer Checklist (excluded
chiacyu commented on code in PR #15989:
URL: https://github.com/apache/kafka/pull/15989#discussion_r1623158977
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,141 @@ public void
testRestoreRestartReq
dajac commented on PR #16145:
URL: https://github.com/apache/kafka/pull/16145#issuecomment-2143311247
@dongnuo123 There are failed tests that seem related to the patch. Could you
please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Rohan Desai created KAFKA-16876:
---
Summary: TaskManager.handleRevocation doesn't handle errors thrown
from task.prepareCommit
Key: KAFKA-16876
URL: https://issues.apache.org/jira/browse/KAFKA-16876
Proje
chia7712 commented on code in PR #15989:
URL: https://github.com/apache/kafka/pull/15989#discussion_r1623140655
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1315,4 +1451,22 @@ private Map structToMap(Struct str
chia7712 commented on code in PR #15989:
URL: https://github.com/apache/kafka/pull/15989#discussion_r1623140561
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,141 @@ public void
testRestoreRestartRe
ganesh-sadanala commented on code in PR #16080:
URL: https://github.com/apache/kafka/pull/16080#discussion_r1623138681
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -101,7 +101,13 @@ public class MirrorSourceConfig extends
Mirror
ganesh-sadanala opened a new pull request, #16162:
URL: https://github.com/apache/kafka/pull/16162
This pull request changes the method to calculate the `punctuate-ratio`
metric. The current implementation calculates the metric after the last record
of the poll loop. After a puntuate, the v
ganesh-sadanala commented on code in PR #16080:
URL: https://github.com/apache/kafka/pull/16080#discussion_r1623135976
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -101,7 +101,13 @@ public class MirrorSourceConfig extends
Mirror
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2143262308
out of curiosity, do we have IT for that option? I grep code base and it
seems the related ITs are running with old coordinator/protocol. For example:
1.
https://github.com/apach
m1a2st commented on PR #16042:
URL: https://github.com/apache/kafka/pull/16042#issuecomment-2143228875
I already rebased the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
m1a2st commented on PR #16155:
URL: https://github.com/apache/kafka/pull/16155#issuecomment-2143228699
Ok, I resolved the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
chia7712 commented on PR #16155:
URL: https://github.com/apache/kafka/pull/16155#issuecomment-2143225807
@m1a2st Could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on PR #16042:
URL: https://github.com/apache/kafka/pull/16042#issuecomment-2143225345
@m1a2st Could you rebase code to include newest fixes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623081838
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -245,55 +251,46 @@ private AssignmentState(final Ap
frankvicky commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1622619577
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -298,7 +298,7 @@ private void sendUnsentRequests(final Timer t
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623079947
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -173,6 +178,7 @@ private static void assignStandby(
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623078889
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -40,13 +41,17 @@
import org.apache.kafka.streams.p
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623064697
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -263,6 +267,8 @@ public
Optional user
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623063757
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -29,20 +32,47 @@ public class AssignmentConfigs {
private
[
https://issues.apache.org/jira/browse/KAFKA-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-15045:
---
Description:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-924%3A+cu
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623054265
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -29,32 +33,59 @@ public class AssignmentConfigs {
private fi
A. Sophie Blee-Goldman created KAFKA-16875:
--
Summary: Replace ClientState with TaskAssignment when creating
individual consumer Assignments
Key: KAFKA-16875
URL: https://issues.apache.org/jira/browse/KAFK
A. Sophie Blee-Goldman created KAFKA-16874:
--
Summary: Remove old TaskAssignor interface
Key: KAFKA-16874
URL: https://issues.apache.org/jira/browse/KAFKA-16874
Project: Kafka
Issue T
A. Sophie Blee-Goldman created KAFKA-16873:
--
Summary: Remove StreamsConfig.INTERNAL_TASK_ASSIGNOR_CLASS
Key: KAFKA-16873
URL: https://issues.apache.org/jira/browse/KAFKA-16873
Project: Kafka
A. Sophie Blee-Goldman created KAFKA-16872:
--
Summary: Remove ClientState class
Key: KAFKA-16872
URL: https://issues.apache.org/jira/browse/KAFKA-16872
Project: Kafka
Issue Type: Sub-
A. Sophie Blee-Goldman created KAFKA-16871:
--
Summary: Clean up internal AssignmentConfigs class in Streams
Key: KAFKA-16871
URL: https://issues.apache.org/jira/browse/KAFKA-16871
Project: Kafk
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623057182
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -40,13 +41,17 @@
import org.apache.kafka.streams.proc
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623054265
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -29,32 +33,59 @@ public class AssignmentConfigs {
private fi
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1623047318
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -29,32 +33,59 @@ public class AssignmentConfigs {
private
Greg Harris created KAFKA-16870:
---
Summary: Values.parseString returns objects which fail
ConnectSchema.validateValue
Key: KAFKA-16870
URL: https://issues.apache.org/jira/browse/KAFKA-16870
Project: Kafk
A. Sophie Blee-Goldman created KAFKA-16869:
--
Summary: Rewrite HighAvailabilityTaskAssignor to implement the new
TaskAssignor interface
Key: KAFKA-16869
URL: https://issues.apache.org/jira/browse/KAFKA-168
A. Sophie Blee-Goldman created KAFKA-16868:
--
Summary: Post KIP-924 StreamsPartitionAssignor code cleanup
Key: KAFKA-16868
URL: https://issues.apache.org/jira/browse/KAFKA-16868
Project: Kafka
gharris1727 opened a new pull request, #16161:
URL: https://github.com/apache/kafka/pull/16161
The SchemaBuilder interface allows for objects with null valueSchema and/or
keySchema to be constructed. These currently cause the validateValue to throw
an NPE on non-empty containers. This chang
edoardocomar commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1623013225
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransac
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar reassigned KAFKA-16570:
-
Assignee: Edoardo Comar (was: Justine Olshan)
> FenceProducers API returns "unexpected
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1623011371
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* Think carefully before y
CalvinConfluent commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622979418
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* Think carefully
CalvinConfluent commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622977589
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* Think carefully
CalvinConfluent commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622977589
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* Think carefully
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622968644
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -55,7 +55,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
.build()
[
https://issues.apache.org/jira/browse/KAFKA-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-16856:
-
Assignee: Muralidhar Basani
> Zookeeper - Add new exception
> -
A. Sophie Blee-Goldman created KAFKA-16867:
--
Summary: Streams should run tag-based standby assignment based on
rack ids
Key: KAFKA-16867
URL: https://issues.apache.org/jira/browse/KAFKA-16867
[
https://issues.apache.org/jira/browse/KAFKA-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-16248:
---
Assignee: Alieh Saeedi
> Kafka consumer should cache leader offset ranges
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851200#comment-17851200
]
Chia-Ping Tsai commented on KAFKA-16698:
[~muralibasani] Could you file PR with
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851197#comment-17851197
]
Chia-Ping Tsai commented on KAFKA-16639:
I have shipped the PR into trunk and 3.
[
https://issues.apache.org/jira/browse/KAFKA-16864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16864.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Copy on write in the Optimized Uniform Assignor
[
https://issues.apache.org/jira/browse/KAFKA-16860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16860.
-
Resolution: Fixed
> Introduce `group.version` feature flag
> ---
dajac merged PR #16088:
URL: https://github.com/apache/kafka/pull/16088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16639.
Resolution: Fixed
> AsyncKafkaConsumer#close does not send heartbeat to leave group
>
chia7712 merged PR #16017:
URL: https://github.com/apache/kafka/pull/16017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1622909655
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3852,6 +3853,17 @@ class KafkaApis(val requestChannel: RequestChannel,
if (exception != null) {
ahuang98 opened a new pull request, #16160:
URL: https://github.com/apache/kafka/pull/16160
See https://github.com/apache/kafka/pull/15986 for description and all
comment history, this addresses some of the comments from that PR (anything
with 👀)
Specifically,
https://github.com/apa
dajac commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1622897443
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -832,7 +855,20 @@ public void validateOffsetFetch(
t
chia7712 commented on code in PR #15862:
URL: https://github.com/apache/kafka/pull/15862#discussion_r1622894813
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -17,29 +17,64 @@
package kafka.test.junit;
+import kafka.test.ClusterConfig;
imp
dajac merged PR #16149:
URL: https://github.com/apache/kafka/pull/16149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac merged PR #16120:
URL: https://github.com/apache/kafka/pull/16120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2142887987
I confirmed that the failed tests are not related. Merging to trunk and to
3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dajac commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2142885524
testTopicPartitionsArgWithInternalIncluded does not fail locally. It is also
a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
andreit-geomotiv opened a new pull request, #16159:
URL: https://github.com/apache/kafka/pull/16159
Kafka Connect single message transform for inserting field with current
system timestamp value.
```
"transforms": "insertCurrentTimestamp",
"transforms.insertCurrentTimestamp.type
sebastienviale commented on PR #16148:
URL: https://github.com/apache/kafka/pull/16148#issuecomment-2142880744
hum, may be a check is needed. If yes, I will create another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2142879003
@riedelmax Thanks for the patch. Could you please extend unit and
integration tests to cover this change?
--
This is an automated message from the Apache Git Service.
To respond to the me
jlprat commented on PR #16150:
URL: https://github.com/apache/kafka/pull/16150#issuecomment-2142879659
Hi @jolshan
According to KIP-1012
(https://cwiki.apache.org/confluence/display/KAFKA/KIP-1012%3A+The+need+for+a+Kafka+3.8.x+release)
we agreed to have a version in the 3.x series with
ganesh-sadanala commented on code in PR #16080:
URL: https://github.com/apache/kafka/pull/16080#discussion_r1622879301
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -101,7 +101,13 @@ public class MirrorSourceConfig extends
Mirror
ganesh-sadanala commented on code in PR #16080:
URL: https://github.com/apache/kafka/pull/16080#discussion_r1622872574
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -101,7 +101,13 @@ public class MirrorSourceConfig extends
Mirror
mjsax commented on PR #16148:
URL: https://github.com/apache/kafka/pull/16148#issuecomment-2142860090
Just wondering. This seems to also apply to `all-latency-max` and the other
metrics over iterators, ie, range?
--
This is an automated message from the Apache Git Service.
To respond to t
mjsax commented on PR #16148:
URL: https://github.com/apache/kafka/pull/16148#issuecomment-2142858494
Thanks for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mjsax merged PR #16148:
URL: https://github.com/apache/kafka/pull/16148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
AyoubOm commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1622840595
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -58,8 +60,21 @@ public void addChild(final ProcessorNode
child) {
publi
riedelmax opened a new pull request, #16158:
URL: https://github.com/apache/kafka/pull/16158
Last PR for KAFKA-14509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sebastienviale commented on code in PR #16148:
URL: https://github.com/apache/kafka/pull/16148#discussion_r1622820325
##
docs/ops.html:
##
@@ -3143,7 +3143,7 @@
dongnuo123 commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1622806164
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -806,7 +809,29 @@ public void validateOffsetCommit(
dongnuo123 commented on code in PR #16145:
URL: https://github.com/apache/kafka/pull/16145#discussion_r1622804714
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -806,7 +809,29 @@ public void validateOffsetCommit(
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851171#comment-17851171
]
Justine Olshan commented on KAFKA-16570:
Hey [~ecomar], thanks. If you don't min
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1622789214
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -55,7 +55,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
.build()
jolshan commented on PR #16150:
URL: https://github.com/apache/kafka/pull/16150#issuecomment-2142758803
Hmmm. I'm not sure I follow the reasoning for bumping to 3.9 rather than
4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
gharris1727 commented on code in PR #16080:
URL: https://github.com/apache/kafka/pull/16080#discussion_r1622763556
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -101,7 +101,13 @@ public class MirrorSourceConfig extends
MirrorConn
dajac commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2142740321
It looks like testDescribeQuorumReplicationSuccessfu also fails for other
PRs:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16154/1/tests.
testTopicP
dajac commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2142730589
Will do when I get back to my computer. They indeed look suspicious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jolshan commented on PR #16120:
URL: https://github.com/apache/kafka/pull/16120#issuecomment-2142726604
Failures look like usual suspects, but can we confirm the 4.0 ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
edoardocomar commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1622769486
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransac
gharris1727 merged PR #16025:
URL: https://github.com/apache/kafka/pull/16025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1622743028
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransact
mjsax commented on code in PR #16148:
URL: https://github.com/apache/kafka/pull/16148#discussion_r1622742983
##
docs/ops.html:
##
@@ -3143,7 +3143,7 @@
mjsax commented on code in PR #16148:
URL: https://github.com/apache/kafka/pull/16148#discussion_r1622740601
##
docs/ops.html:
##
@@ -3143,7 +3143,7 @@
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1622739622
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1622737514
##
core/src/test/java/kafka/admin/AclCommandIntegrationTest.java:
##
@@ -0,0 +1,453 @@
+package kafka.admin;
+
+import kafka.test.ClusterInstance;
+import kafka.test.a
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1622734164
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new AclBin
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1622734164
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new AclBin
dajac commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1622733949
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet<>
chia7712 merged PR #16152:
URL: https://github.com/apache/kafka/pull/16152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #16133:
URL: https://github.com/apache/kafka/pull/16133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #16155:
URL: https://github.com/apache/kafka/pull/16155#discussion_r1622712633
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -62,7 +63,7 @@ static List forConsumerGroupCoordinator() {
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1622591542
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -481,10 +479,24 @@ private static int getCrossRackTrafficCost(f
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851160#comment-17851160
]
Ganesh Sadanala edited comment on KAFKA-16811 at 5/31/24 4:53 PM:
cmccabe commented on PR #15945:
URL: https://github.com/apache/kafka/pull/15945#issuecomment-2142641154
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1622699466
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851160#comment-17851160
]
Ganesh Sadanala edited comment on KAFKA-16811 at 5/31/24 4:47 PM:
jolshan commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1622699466
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -159,9 +158,7 @@ default Set supportedGroupProtocols() {
Set supportedGroupProtocols = new HashSet
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851160#comment-17851160
]
Ganesh Sadanala commented on KAFKA-16811:
-
[~sebviale] I have completed the impl
1 - 100 of 224 matches
Mail list logo
