ocadaruma commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1623844071
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -575,9 +575,9 @@ InMemoryLeaderEpochCheckpoint
getLeaderEpochCheckpoint(UnifiedLog log, long star
omkreddy merged PR #16022:
URL: https://github.com/apache/kafka/pull/16022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiandu reassigned KAFKA-16879:
--
Assignee: jiandu
> SystemTime should use singleton mode
>
>
>
qinghui-xu commented on PR #7139:
URL: https://github.com/apache/kafka/pull/7139#issuecomment-2144362990
It turns out the patch is no more relevant with the refactorings in recent
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
qinghui-xu closed pull request #7139: KAFKA-8735: Check properties file
existence first
URL: https://github.com/apache/kafka/pull/7139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
omkreddy commented on PR #16022:
URL: https://github.com/apache/kafka/pull/16022#issuecomment-2144356482
Test failures are not related to this PR:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16022/6/tests
--
This is an automated message from the Apac
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiandu updated KAFKA-16879:
---
Description:
Currently, the {{SystemTime}} class, which provides system time-related
functionalities such a
jiandu created KAFKA-16879:
--
Summary: SystemTime should use singleton mode
Key: KAFKA-16879
URL: https://issues.apache.org/jira/browse/KAFKA-16879
Project: Kafka
Issue Type: Improvement
satishd commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1623787269
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -179,6 +182,7 @@ public Optional serverConfigName(String configName)
{
publi
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1623777938
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1123,6 +1133,17 @@ public long maybeUpdate(long now) {
// Beware that the behav
kamalcph commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144269279
I would prefer the other way around:
1. `KafkaConfig.remoteLogManagerConfig().enableRemoteStorageSystem()` sounds
like a setter which reduces the code readability
2. `isRemoteLo
satishd commented on PR #16132:
URL: https://github.com/apache/kafka/pull/16132#issuecomment-2144267407
@clolov Is it open for review or you start planning to add more changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Alexander-Aghili commented on PR #15857:
URL: https://github.com/apache/kafka/pull/15857#issuecomment-2144259480
Apologizes for the delay. I changed the code so that the tests passed
locally. Let me know if that resolved the issue.
--
This is an automated message from the Apache Git Servi
satishd commented on PR #16131:
URL: https://github.com/apache/kafka/pull/16131#issuecomment-2144254775
Retriggered the build to start the build/tests again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
satishd commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1623765428
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -239,6 +244,13 @@ private void removeMetrics() {
remoteStorageReaderThreadPool.removeMetric
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851514#comment-17851514
]
Ganesh Sadanala edited comment on KAFKA-16876 at 6/3/24 4:21 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851514#comment-17851514
]
Ganesh Sadanala edited comment on KAFKA-16876 at 6/3/24 4:21 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851514#comment-17851514
]
Ganesh Sadanala commented on KAFKA-16876:
-
[~rohanpd] Thank your for confirming
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851499#comment-17851499
]
Rohan Desai commented on KAFKA-16876:
-
[~ganesh_6] I don't have that stack trace unf
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851490#comment-17851490
]
Ganesh Sadanala edited comment on KAFKA-16876 at 6/3/24 3:56 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851490#comment-17851490
]
Ganesh Sadanala edited comment on KAFKA-16876 at 6/3/24 3:34 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851490#comment-17851490
]
Ganesh Sadanala commented on KAFKA-16876:
-
[~rohanpd] Can you share the `TaskMan
github-actions[bot] commented on PR #15280:
URL: https://github.com/apache/kafka/pull/15280#issuecomment-2144213214
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15321:
URL: https://github.com/apache/kafka/pull/15321#issuecomment-2144213180
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16859.
Fix Version/s: 3.9.0
Resolution: Fixed
> Cleanup check if tiered storage is enabled
chia7712 merged PR #16153:
URL: https://github.com/apache/kafka/pull/16153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144174063
@chia7712 I changed it , plz take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144167371
@gongxuanzhang Could you please update the description to share the tips of
"how to test this PR"?
--
This is an automated message from the Apache Git Service.
To respond to the messag
gongxuanzhang opened a new pull request, #16172:
URL: https://github.com/apache/kafka/pull/16172
This PR is sub PR from https://github.com/apache/kafka/pull/16097.
In order not to modify large-scale code, we plan add it step by step in
module.
The first is 'transaction-coordinator' 's
Chia-Ping Tsai created KAFKA-16878:
--
Summary: Remove powermock from code base
Key: KAFKA-16878
URL: https://issues.apache.org/jira/browse/KAFKA-16878
Project: Kafka
Issue Type: Sub-task
soarez commented on PR #16118:
URL: https://github.com/apache/kafka/pull/16118#issuecomment-2144080705
@showuon thanks for testing and sharing this.
In those logs the controller is rejecting the assignment with a
`NOT_LEADER_OR_FOLLOWER` because the partition has been moved away from
philipnee commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2144015771
hi @brenden20 - left some comments. lmk what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
philipnee commented on PR #16124:
URL: https://github.com/apache/kafka/pull/16124#issuecomment-2144015658
hi @brenden20 - left some comments. lmk what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623649872
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -339,6 +358,15 @@ void testRunOnceInvokesReaper() {
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623649732
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -339,6 +358,15 @@ void testRunOnceInvokesReaper() {
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648674
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -231,10 +254,7 @@ public void testAssignmentChangeEvent() {
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648578
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -207,7 +230,7 @@ public void testResetPositionsProcessFailu
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648474
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648058
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647935
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +52,105 @@
import static org.junit.jupiter.api.Asse
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647643
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +52,105 @@
import static org.junit.jupiter.api.Asse
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647362
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -74,68 +52,105 @@
import static org.junit.jupiter.api.Asse
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647091
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -16,33 +16,19 @@
*/
package org.apache.kafka.clients.con
philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646860
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -152,6 +152,34 @@ public void cleanup() {
}
philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646783
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -483,6 +483,23 @@ public void resetTimer() {
thi
philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646688
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -152,6 +152,34 @@ public void cleanup() {
}
philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646632
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -152,6 +152,34 @@ public void cleanup() {
}
philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623645864
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -452,7 +452,7 @@ private void handleFatalFailure(Throwable er
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623645517
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623645445
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644884
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -106,6 +106,9 @@ public class CommitRequestManagerTest {
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644884
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -106,6 +106,9 @@ public class CommitRequestManagerTest {
chia7712 commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623644649
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry impleme
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644470
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1289,5 +1293,11 @@ static class MemberInfo {
this.
[
https://issues.apache.org/jira/browse/KAFKA-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12572.
Fix Version/s: 3.9.0
Resolution: Fixed
fixed by
https://github.com/apache/kafka/co
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623643756
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
chia7712 merged PR #16097:
URL: https://github.com/apache/kafka/pull/16097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623643756
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
chia7712 merged PR #16171:
URL: https://github.com/apache/kafka/pull/16171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623643481
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry impleme
muralibasani commented on PR #16168:
URL: https://github.com/apache/kafka/pull/16168#issuecomment-2144003438
@chia7712 would you like to take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623639224
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623637352
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623637352
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
chia7712 commented on PR #13931:
URL: https://github.com/apache/kafka/pull/13931#issuecomment-2143994107
@joobisb any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623637352
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623637352
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
ganesh-sadanala commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623637352
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry
chia7712 commented on code in PR #16169:
URL: https://github.com/apache/kafka/pull/16169#discussion_r1623634685
##
clients/src/test/java/org/apache/kafka/common/network/DefaultChannelMetadataRegistry.java:
##
@@ -22,9 +22,10 @@ public class DefaultChannelMetadataRegistry impleme
cmccabe commented on PR #16160:
URL: https://github.com/apache/kafka/pull/16160#issuecomment-2143980581
There are some test failures in `KafkaRaftClientTest`and `StorageToolTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
frankvicky commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1623486299
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##
@@ -140,6 +141,35 @@ public void testEnsureTimerSetOnAdd() {
brandboat commented on PR #16171:
URL: https://github.com/apache/kafka/pull/16171#issuecomment-2143900050
gentle ping @chia7712 , sorry about this one. Could you take another look
when you are available ?
--
This is an automated message from the Apache Git Service.
To respond to the messa
brandboat opened a new pull request, #16171:
URL: https://github.com/apache/kafka/pull/16171
This is something leaving behind in
https://github.com/apache/kafka/pull/16170
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
chia7712 commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1623465952
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##
@@ -140,6 +141,35 @@ public void testEnsureTimerSetOnAdd() {
[
https://issues.apache.org/jira/browse/KAFKA-16785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16785.
Fix Version/s: 3.9.0
Resolution: Fixed
> Migrate TopicBasedRemoteLogMetadataManager
chia7712 merged PR #16170:
URL: https://github.com/apache/kafka/pull/16170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851416#comment-17851416
]
MOHD KAIF KHAN commented on KAFKA-16871:
[~ableegoldman] So far here's what I ha
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623408115
##
README.md:
##
@@ -227,11 +227,16 @@ There are two code quality analysis tools that we
regularly run, spotbugs and ch
Checkstyle enforces a consistent coding
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623408115
##
README.md:
##
@@ -227,11 +227,16 @@ There are two code quality analysis tools that we
regularly run, spotbugs and ch
Checkstyle enforces a consistent coding
chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623401990
##
README.md:
##
@@ -227,11 +227,16 @@ There are two code quality analysis tools that we
regularly run, spotbugs and ch
Checkstyle enforces a consistent coding style
chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623401990
##
README.md:
##
@@ -227,11 +227,16 @@ There are two code quality analysis tools that we
regularly run, spotbugs and ch
Checkstyle enforces a consistent coding style
chia7712 merged PR #16164:
URL: https://github.com/apache/kafka/pull/16164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gaurav-narula commented on code in PR #16165:
URL: https://github.com/apache/kafka/pull/16165#discussion_r1623392339
##
core/src/test/java/kafka/server/LogManagerIntegrationTest.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16877:
--
Assignee: Kuan Po Tseng (was: Chia-Ping Tsai)
> Migrate RemoteLogSegmentLifecycleTes
[
https://issues.apache.org/jira/browse/KAFKA-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851405#comment-17851405
]
Kuan Po Tseng commented on KAFKA-16877:
---
I'm willing to take over this. Many thank
brandboat opened a new pull request, #16170:
URL: https://github.com/apache/kafka/pull/16170
related to https://issues.apache.org/jira/browse/KAFKA-16785
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382628
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382520
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382281
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623381407
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623380991
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -227,8 +275,8 @@ public void testPollEnsureEmptyPendingReque
Chia-Ping Tsai created KAFKA-16877:
--
Summary: Migrate RemoteLogSegmentLifecycleTest to use new test
infra
Key: KAFKA-16877
URL: https://issues.apache.org/jira/browse/KAFKA-16877
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16807.
Resolution: Fixed
> DescribeLogDirsResponseData#results#topics have unexpected topics havi
[
https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16807:
---
Fix Version/s: 3.9.0
> DescribeLogDirsResponseData#results#topics have unexpected topics hav
chia7712 merged PR #16042:
URL: https://github.com/apache/kafka/pull/16042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15830:
URL: https://github.com/apache/kafka/pull/15830#issuecomment-2143770889
@pasharik Could you please take a look at failed tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2143755742
Hi @mjsax requesting a review on this PR.
There is one open case still that I am not sure how we should handle - it's
the check @ableegoldman mentioned in here comment
[here](htt
dajac commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143747462
Sure. I can review it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143746525
@frankvicky @dajac thanks for all your responses. I will take a look at this
PR later. @dajac it would be great if this PR can have reviews from you :)
--
This is an automated message
dajac commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143745346
@frankvicky Thanks for this! As I said, I am fine with merging the fix. We
should definitely keep it. I just wanted to signal that there is an ongoing
effort from @dongnuo123 to add integra
1 - 100 of 106 matches
Mail list logo
