dajac opened a new pull request, #16185:
URL: https://github.com/apache/kafka/pull/16185
The time taken to compute a new assignment is critical. This patches
extending the existing logging to log it too. This is very useful information
to have.
### Committer Checklist (excluded from
showuon commented on PR #16118:
URL: https://github.com/apache/kafka/pull/16118#issuecomment-2146749642
I was trying to know the root cause of this problem, that why does it fail
after upgrade, but not fail without upgrade. My understanding is that because
before upgrade, the topic image do
[
https://issues.apache.org/jira/browse/KAFKA-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-16715.
--
Resolution: Fixed
> Create KafkaShareConsumer interface
>
dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1625434453
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java:
##
@@ -271,18 +277,17 @@ public void testCreateAssignment
dajac commented on PR #16144:
URL: https://github.com/apache/kafka/pull/16144#issuecomment-2146713066
Merged to trunk and to 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dajac merged PR #16144:
URL: https://github.com/apache/kafka/pull/16144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146691340
> We have some integration tests in ConsumerGroupDescribeRequestTest
thanks for this reminder. I neglect that before :(
--
This is an automated message from the Apache Git Servic
chia7712 merged PR #16173:
URL: https://github.com/apache/kafka/pull/16173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146678085
@chia7712 im not sure if I understand you correctlu. We have some
integration tests in `ConsumerGroupDescribeRequestTest`
--
This is an automated message from the Apache Git Service.
riedelmax commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1625394359
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146676215
@dajac thanks for checking so quickly. I will have time on friday to do the
integration tet
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Chia-Ping Tsai created KAFKA-16885:
--
Summary: Consider renaming
RemoteLogManagerConfig#enableRemoteStorageSystem to
RemoteLogManagerConfig#isRemoteStorageSystemEnabled
Key: KAFKA-16885
URL: https://issues.apache
chia7712 commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2146674263
I file the ticket https://issues.apache.org/jira/browse/KAFKA-16885. We can
have more discussion on there.
--
This is an automated message from the Apache Git Service.
To respond to th
chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1625383681
##
build.gradle:
##
@@ -47,9 +47,11 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifac
[ https://issues.apache.org/jira/browse/KAFKA-4094 ]
Abhi deleted comment on KAFKA-4094:
-
was (Author: JIRAUSER305362):
Hi [~jkreps]
Can you describe this issue more and also mention which component it belongs to?
As per my understanding, you need the
rreddy-22 commented on PR #16068:
URL: https://github.com/apache/kafka/pull/16068#issuecomment-2146608185
**Trunk**
```
Benchmark (memberCount)
(partitionsToMemberRatio) (topicCount) Mode Cnt Score Error Units
TargetAssignmentBuilderBenchmark.bu
rreddy-22 commented on PR #16068:
URL: https://github.com/apache/kafka/pull/16068#issuecomment-2146607344
Trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
FrankYang0529 commented on PR #15675:
URL: https://github.com/apache/kafka/pull/15675#issuecomment-2146578561
@chia7712 I address all comments. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
jolshan commented on PR #16181:
URL: https://github.com/apache/kafka/pull/16181#issuecomment-2146534437
Cherrypicked to 3.8 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
jolshan merged PR #16181:
URL: https://github.com/apache/kafka/pull/16181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2146529487
@jeqo
Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
brandboat commented on code in PR #16180:
URL: https://github.com/apache/kafka/pull/16180#discussion_r1625299519
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogSegmentLifecycleTest.java:
##
@@ -197,333 +206,159 @@ public void
testRemoteLog
kamalcph commented on code in PR #16180:
URL: https://github.com/apache/kafka/pull/16180#discussion_r1625298782
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogSegmentLifecycleTest.java:
##
@@ -197,333 +206,159 @@ public void
testRemoteLogS
omkreddy merged PR #16134:
URL: https://github.com/apache/kafka/pull/16134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
github-actions[bot] commented on PR #15450:
URL: https://github.com/apache/kafka/pull/15450#issuecomment-2146521360
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625290704
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
showuon commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1625271623
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() {
assertEquals(1, rlmFet
gongxuanzhang commented on PR #16176:
URL: https://github.com/apache/kafka/pull/16176#issuecomment-2146474883
@chia7712 plz take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
tisonkun commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1625260173
##
clients/src/main/resources/common/message/BrokerHeartbeatRequest.json:
##
@@ -30,6 +30,8 @@
{ "name": "WantFence", "type": "bool", "versions": "0+",
"ab
frankvicky commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1625253815
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -293,12 +293,10 @@ private void closeInternal(final Duration t
brandboat commented on code in PR #16180:
URL: https://github.com/apache/kafka/pull/16180#discussion_r1625252312
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogSegmentLifecycleTest.java:
##
@@ -197,333 +206,159 @@ public void
testRemoteLog
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851864#comment-17851864
]
jiandu commented on KAFKA-16879:
thank you
> SystemTime should use singleton mode
> ---
rreddy-22 commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1625229200
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -9863,8 +9863,8 @@ public void
testConsumerGroupHeartbeatW
gharris1727 commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625228386
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,7 +30,7 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
+Tim
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851862#comment-17851862
]
黃竣陽 edited comment on KAFKA-16879 at 6/4/24 1:37 AM:
-
Pardon me, I m
gongxuanzhang commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1625220935
##
build.gradle:
##
@@ -799,7 +800,7 @@ subprojects {
skipConfigurations = [ "zinc" ]
}
- if (project.name in spotlessApplyModules) {
+ if (JavaVersio
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2146397207
@chia7712 complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851862#comment-17851862
]
黃竣陽 commented on KAFKA-16879:
-
sorry, I miss that you want to handle this issue by yourself,
m1a2st closed pull request #16179: KAFKA-16879: SystemTime should use singleton
mode
URL: https://github.com/apache/kafka/pull/16179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
m1a2st commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625217653
##
clients/src/main/java/org/apache/kafka/common/utils/SystemTime.java:
##
@@ -26,6 +26,18 @@
*/
public class SystemTime implements Time {
+/**
+ * use the
m1a2st commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625215483
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,7 +30,7 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
+Time SYS
junrao commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1625209745
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -305,22 +341,23 @@ public Map.Entry endOffsetFor(int
requestedEpoch,
gharris1727 commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625208358
##
clients/src/main/java/org/apache/kafka/common/utils/SystemTime.java:
##
@@ -26,6 +26,18 @@
*/
public class SystemTime implements Time {
+/**
+ * use
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851860#comment-17851860
]
jiandu edited comment on KAFKA-16879 at 6/4/24 1:07 AM:
[~m1a2st
[
https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851860#comment-17851860
]
jiandu commented on KAFKA-16879:
Sorry, you should choose to handle issues that have no
gharris1727 commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625205338
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,7 +30,7 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
+Tim
ocadaruma commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1625200232
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -305,22 +341,23 @@ public Map.Entry endOffsetFor(int
requestedEpoc
ocadaruma commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1625200232
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -305,22 +341,23 @@ public Map.Entry endOffsetFor(int
requestedEpoc
ocadaruma commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1625196957
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -608,25 +613,23 @@ public boolean isCancelled() {
}
/**
- * Returns the leader epo
edoardocomar commented on PR #16151:
URL: https://github.com/apache/kafka/pull/16151#issuecomment-2146353225
> If someone wants to raise the timeout for this one operation, I don't
think that we should require them to increase the client-global
request.timeout.ms.
I agree to that. Hopefu
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2146344557
@gongxuanzhang please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
junrao commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1625162518
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -42,10 +45,15 @@
*
* Leader Epoch = epoch assigned to each leader
apoorvmittal10 opened a new pull request, #16184:
URL: https://github.com/apache/kafka/pull/16184
The PR adds skeleton code for Share Fetch and Acknowledge RPCs. The changes
include:
1. Defining RPCs in KafkaApis.scala
2. Added new SharePartitionManager class which handles the RPCs han
kirktrue commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2146294482
@lianetm @cadonna—this is ready for another review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jolshan opened a new pull request, #16183:
URL: https://github.com/apache/kafka/pull/16183
This change includes adding transaction.version (part of KIP-1022)
New transaction version 1 is introduced to support writing flexible fields
in transaction state log messages.
Transactio
chia7712 commented on PR #16169:
URL: https://github.com/apache/kafka/pull/16169#issuecomment-2146219949
> Did we mean to totally remove the null check here?
Pardon me, the topic is related to "update" of cipherInformation, and this
PR has fixed that.
If you prefer to either ke
gharris1727 commented on PR #16161:
URL: https://github.com/apache/kafka/pull/16161#issuecomment-2146189325
Hey @C0urante @yashmayya Could either of you PTAL? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -270,30 +326,27 @@ void testPollResultTimer() {
void tes
[
https://issues.apache.org/jira/browse/KAFKA-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-16105.
-
Resolution: Fixed
> Reassignment of tiered topics is failing due to RemoteStorageException
> ---
gharris1727 commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2146174509
Thank you @AnatolyPopov for the PR, and thanks @showuon and @kamalcph for
your reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -270,30 +326,27 @@ void testPollResultTimer() {
void tes
jsancio commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1625072194
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,77 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEquals(
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625074887
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -306,6 +309,113 @@ class RaftManagerTest {
}
+ class ReconfigurationTestContext(
Review Com
lianetm commented on PR #16140:
URL: https://github.com/apache/kafka/pull/16140#issuecomment-2146155510
Hey @brenden20, very nice improvement! Left a few comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -270,30 +326,27 @@ void testPollResultTimer() {
void tes
[
https://issues.apache.org/jira/browse/KAFKA-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16105:
Fix Version/s: 3.8.0
3.7.1
3.9.0
> Reassignment of tiered to
cmccabe merged PR #15986:
URL: https://github.com/apache/kafka/pull/15986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-16362.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Fix type-unsafety in KStreamKStreamJoin caused b
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625060556
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -270,30 +326,27 @@ void testPollResultTimer() {
void tes
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625059147
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -289,10 +289,11 @@ private void closeInternal(final Duration time
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16792:
--
Description:
Enable the following unit tests for the new async consumer in KafkaConsumerTest:
- testC
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625054713
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850215#comment-17850215
]
Kirk True edited comment on KAFKA-16792 at 6/3/24 9:09 PM:
---
Th
jsancio commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625049639
##
clients/src/main/java/org/apache/kafka/clients/admin/RaftVoterEndpoint.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850215#comment-17850215
]
Kirk True edited comment on KAFKA-16792 at 6/3/24 9:03 PM:
---
Th
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625048146
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw
jsancio commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625041690
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -318,4 +329,28 @@ class KafkaRaftManager[T](
override def voterNode(id: Int, listener: String): Option[Nod
ableegoldman commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1625023687
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -527,35 +531,44 @@ private ApplicationState buildApplica
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625034602
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625032096
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw
gharris1727 merged PR #15165:
URL: https://github.com/apache/kafka/pull/15165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
[
https://issues.apache.org/jira/browse/KAFKA-16884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851809#comment-17851809
]
Muralidhar Basani commented on KAFKA-16884:
---
[~gharris1727] agree with you abo
C0urante commented on PR #16122:
URL: https://github.com/apache/kafka/pull/16122#issuecomment-2146088065
Thanks @mimaison and apologies for the failing test. This should be ready
now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
C0urante commented on PR #16053:
URL: https://github.com/apache/kafka/pull/16053#issuecomment-2146086988
Thanks @gharris1727! I've updated the patch to apply to both distributed and
standalone mode, and fixed failing unit tests.
I've also tweaked the logic so that applied connector co
jolshan commented on PR #16169:
URL: https://github.com/apache/kafka/pull/16169#issuecomment-2146083639
Did we mean to totally remove the null check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
gharris1727 commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2146082430
Test failures appear unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/KAFKA-16884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851807#comment-17851807
]
Greg Harris commented on KAFKA-16884:
-
I don't think the builder pattern is a good f
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625013334
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -1080,4 +1083,39 @@ class ControllerApis(
requestThrottleMs => new
AssignReplicasToDirsRespons
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625013008
##
clients/src/main/java/org/apache/kafka/clients/admin/RaftVoterEndpoint.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625003964
##
core/src/test/resources/log4j.properties:
##
@@ -18,8 +18,8 @@ log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.
Muralidhar Basani created KAFKA-16884:
-
Summary: Refactor RemoteLogManagerConfig with a Builder
Key: KAFKA-16884
URL: https://issues.apache.org/jira/browse/KAFKA-16884
Project: Kafka
Issu
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1625003607
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -318,4 +329,28 @@ class KafkaRaftManager[T](
override def voterNode(id: Int, listener: String): Option[Nod
C0urante commented on PR #16001:
URL: https://github.com/apache/kafka/pull/16001#issuecomment-2146046642
Closing in favor of https://github.com/apache/kafka/pull/16053, which is
simpler, more effective, and requires no changes to the config topic or
internal REST API.
--
This is an autom
C0urante closed pull request #16001: KAFKA-9228: Restart tasks on runtime-only
connector config changes
URL: https://github.com/apache/kafka/pull/16001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624997659
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -747,21 +748,19 @@ public void
testOffsetCommitSyncTimeoutNo
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624996705
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java:
##
@@ -210,7 +194,7 @@ private NetworkClientDelegate.UnsentReque
cmccabe commented on code in PR #16058:
URL: https://github.com/apache/kafka/pull/16058#discussion_r1624993551
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1320,6 +1320,16 @@ public ListClientMetricsResourcesResult
listClientMetricsResour
1 - 100 of 310 matches
Mail list logo
