[
https://issues.apache.org/jira/browse/KAFKA-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani reassigned KAFKA-16863:
-
Assignee: Muralidhar Basani
> Consider removing `default.` prefix for exception
[
https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853340#comment-17853340
]
Chia Chuan Yu commented on KAFKA-16918:
---
Hi, [~showuon]
Can I have this one plea
mimaison commented on code in PR #16236:
URL: https://github.com/apache/kafka/pull/16236#discussion_r1631941972
##
build.gradle:
##
@@ -826,7 +819,6 @@ subprojects {
toolVersion = versions.jacoco
}
- // NOTE: Jacoco Gradle plugin does not support "offline
[
https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853346#comment-17853346
]
Luke Chen commented on KAFKA-16918:
---
Assigned to you. Thanks [~chiacyu] !
> TestUtils
[
https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16918:
-
Assignee: Chia Chuan Yu
> TestUtils#assertFutureThrows should use future.get with timeout
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853361#comment-17853361
]
Igor Soarez commented on KAFKA-15961:
-
Saw another failure here
[https://ci-builds.
[
https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853362#comment-17853362
]
Igor Soarez commented on KAFKA-15914:
-
Another failure here
[https://ci-builds.apac
soarez commented on PR #16251:
URL: https://github.com/apache/kafka/pull/16251#issuecomment-2155991204
Thanks for reviewing @showuon.
Only three failed tests on JDK21, all passing locally, all unrelated:
* KAFKA-16919 - testNoCheckpointsIfNoRecordsAreMirrored() –
org.apache.kaf
soarez merged PR #16251:
URL: https://github.com/apache/kafka/pull/16251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
Igor Soarez created KAFKA-16919:
---
Summary: Flaky test testNoCheckpointsIfNoRecordsAreMirrored() –
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest
Key: KAFKA-16919
URL: https://issues.
chia7712 commented on PR #16233:
URL: https://github.com/apache/kafka/pull/16233#issuecomment-2156005210
@dajac Could you please rebase code to include #16249?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2156005444
@gongxuanzhang could you please rebase code to include #16249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2156005905
@FrankYang0529 please rebase code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156006198
@riedelmax please rebase code to have the fix #16249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
chia7712 commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632032059
##
storage/src/test/java/org/apache/kafka/server/log/OffsetIndexTest.java:
##
@@ -0,0 +1,271 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632032964
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
public
chia7712 commented on code in PR #16242:
URL: https://github.com/apache/kafka/pull/16242#discussion_r1632034986
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,8 +30,6 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
Review Com
Igor Soarez created KAFKA-16920:
---
Summary: Flaky test testControlledShutdown() -
kafka.server.BrokerLifecycleManagerTest
Key: KAFKA-16920
URL: https://issues.apache.org/jira/browse/KAFKA-16920
Project:
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16920:
Description:
Several tests failed in this pipeline because {{testControlledShutdown}} did
not cle
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16920:
Description:
Several tests failed in this pipeline because {{testControlledShutdown}} did
not cle
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156027791
Hi @chia7712 , I will take look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853368#comment-17853368
]
Igor Soarez commented on KAFKA-15963:
-
Failed again in
[https://ci-builds.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853369#comment-17853369
]
Igor Soarez commented on KAFKA-15197:
-
This failed again in
[https://ci-builds.apac
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632040486
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
[
https://issues.apache.org/jira/browse/KAFKA-16383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853370#comment-17853370
]
Igor Soarez commented on KAFKA-16383:
-
This failed again in
[https://ci-builds.apac
[
https://issues.apache.org/jira/browse/KAFKA-16383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16383:
Component/s: connect
> fix flaky test IdentityReplicationIntegrationTest.testReplicateFromLatest()
[
https://issues.apache.org/jira/browse/KAFKA-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853371#comment-17853371
]
Igor Soarez commented on KAFKA-16402:
-
Failed again in
https://ci-builds.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853373#comment-17853373
]
Igor Soarez commented on KAFKA-15789:
-
Failed again in
https://ci-builds.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853374#comment-17853374
]
Igor Soarez commented on KAFKA-8115:
Failed again
https://ci-builds.apache.org/blue/
soarez commented on PR #16232:
URL: https://github.com/apache/kafka/pull/16232#issuecomment-2156032172
@showuon thank you for reviewing this.
Failed tests pass locally, and are unrelated to this change:
* KAFKA-16383
org.apache.kafka.connect.mirror.integration.IdentityReplicati
soarez merged PR #16232:
URL: https://github.com/apache/kafka/pull/16232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853376#comment-17853376
]
Igor Soarez commented on KAFKA-16667:
-
[~davidarthur] is this still relevant for 3.7
[
https://issues.apache.org/jira/browse/KAFKA-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-16920:
-
Assignee: Gaurav Narula
> Flaky test testControlledShutdown() - kafka.server.BrokerLife
chia7712 commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632043139
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632043299
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853377#comment-17853377
]
Igor Soarez commented on KAFKA-16667:
-
I'm removing the 3.7.1 tag for now. Please ad
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16667:
Fix Version/s: (was: 3.7.1)
> KRaftMigrationDriver gets stuck after successive failovers
> ---
gaurav-narula opened a new pull request, #16252:
URL: https://github.com/apache/kafka/pull/16252
Tests in BrokerLifecycleManagerTest do not close BrokerLifecycleManager if
an assertion fails. This change ensures `manager.close()` is always invoked in
a finally block thereby preventing poten
FrankYang0529 commented on code in PR #16236:
URL: https://github.com/apache/kafka/pull/16236#discussion_r1632046626
##
build.gradle:
##
@@ -826,7 +819,6 @@ subprojects {
toolVersion = versions.jacoco
}
- // NOTE: Jacoco Gradle plugin does not support "off
FrankYang0529 commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156043620
> #16249 is merged. FYI.
Rebased it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-215601
> @FrankYang0529 please rebase code :)
Thanks for reminder. Rebased it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632052511
##
storage/src/test/java/org/apache/kafka/server/log/OffsetMapTest.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632052689
##
storage/src/test/java/org/apache/kafka/server/log/OffsetMapTest.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2156061341
> @gongxuanzhang could you please rebase code to include #16249
Okay, next we wait for CI
--
This is an automated message from the Apache Git Service.
To respond to the mess
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632055803
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2156063782
Hi @chia7712 , I do some changes based on comments, PTAL 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dujian0068 commented on code in PR #16242:
URL: https://github.com/apache/kafka/pull/16242#discussion_r1632056246
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -30,8 +30,6 @@
*/
public interface Time {
-Time SYSTEM = new SystemTime();
Review C
[
https://issues.apache.org/jira/browse/KAFKA-16893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853388#comment-17853388
]
Fan Yang commented on KAFKA-16893:
--
Here's the KIP:
[KIP-1055: Introducing Round-Robin
[ https://issues.apache.org/jira/browse/KAFKA-16893 ]
Fan Yang deleted comment on KAFKA-16893:
--
was (Author: JIRAUSER305427):
Here's the KIP:
[KIP-1055: Introducing Round-Robin Assignment Strategy to ConnectorUtils -
Apache Kafka - Apache Softwar
fanyang commented on PR #16208:
URL: https://github.com/apache/kafka/pull/16208#issuecomment-2156073280
Here's the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1055%3A+Introducing+Round-Robin+Assignment+Strategy+to+ConnectorUtils
--
This is an automated message from the A
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156084937
Hi @chia7712, I have replace some `UnmodifiableMap` with `HashMap`, PTAL 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
gaurav-narula commented on PR #16252:
URL: https://github.com/apache/kafka/pull/16252#issuecomment-2156087544
Thanks for the feedback! Force pushed a commit with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
chia7712 commented on code in PR #16250:
URL: https://github.com/apache/kafka/pull/16250#discussion_r1632066886
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3649,7 +3652,7 @@ public DeleteConsumerGroupOffsetsResult
deleteConsumerGroupOff
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632067288
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +38,109 @@ public class ConsumerRecordsTest {
@Test
publi
chia7712 commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156091519
failed tests pass on my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
chia7712 merged PR #16236:
URL: https://github.com/apache/kafka/pull/16236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16878.
Fix Version/s: 3.9.0
Resolution: Fixed
> Remove powermock and easymock from code ba
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-14132.
Fix Version/s: 3.9.0
(was: 3.8.0)
Resolution: Fixed
> Remain
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853397#comment-17853397
]
Chia-Ping Tsai commented on KAFKA-16921:
There are many files which will get inv
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853398#comment-17853398
]
黃竣陽 commented on KAFKA-16921:
-
I'm interesting in this issue, I can handle it. Thank you
>
ijuma commented on PR #16236:
URL: https://github.com/apache/kafka/pull/16236#issuecomment-2156096105
> Wow, we're finally doing it! According to
[KAFKA-7438](https://issues.apache.org/jira/browse/KAFKA-7438), it looks like
it almost took us 6 years to do it.
Well done team, this was
pasharik commented on PR #15830:
URL: https://github.com/apache/kafka/pull/15830#issuecomment-2156108598
> Could you please take a look at failed tests?
`AclCommandTest` seems to be fixed, but there are some other failing tests
for jdk8 and jdk21
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/KAFKA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-7438.
---
Fix Version/s: 3.9.0
Resolution: Fixed
> Replace EasyMock and PowerMock with Mockito
>
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156112376
The junit 4 assertions are not compatible to junit 5, so you ought to fix
the conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156112524
Also, please remove dependency "JUnit Vintage Engine" from connect module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
brandboat commented on PR #16231:
URL: https://github.com/apache/kafka/pull/16231#issuecomment-2156132892
Modified a couple of things in the latest commit:
1. Add computeIfAbsent in each benchmark since in the code base we use both
get and computeIfAbsent in CopyOnWriteMap, and we want to
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
kamalcph commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632086340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -954,7 +953,9 @@ public boolean
isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat
dajac commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156186787
Out of curiosity, what’s the reason for not returning unmodifiable maps? I
think that we should actually ensure that the admin client does not return
modifiable maps.
--
This is an autom
chia7712 commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2156189050
> Out of curiosity, what’s the reason for not returning unmodifiable maps? I
think that we should actually ensure that the admin client does not return
modifiable maps.
I prefer t
Chia-Ping Tsai created KAFKA-16922:
--
Summary: add unit test for NewTopic
Key: KAFKA-16922
URL: https://issues.apache.org/jira/browse/KAFKA-16922
Project: Kafka
Issue Type: Test
R
chia7712 merged PR #16172:
URL: https://github.com/apache/kafka/pull/16172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-10787:
---
Fix Version/s: 3.9.0
> Introduce an import order in Java sources
> -
[
https://issues.apache.org/jira/browse/KAFKA-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12572:
--
Assignee: xuanzhang gong (was: Dongjin Lee)
> Add import ordering checkstyle rule an
[
https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-10787:
--
Assignee: xuanzhang gong (was: Dongjin Lee)
> Introduce an import order in Java sour
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1632118232
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,88 +16,100 @@
*/
package org.apache.kafka.tools.consumer.grou
[
https://issues.apache.org/jira/browse/KAFKA-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853438#comment-17853438
]
Muralidhar Basani commented on KAFKA-16922:
---
[~chia7712] seems like there is n
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1632119543
##
core/src/test/scala/unit/kafka/admin/AclCommandTest.scala:
##
@@ -325,11 +349,15 @@ class AclCommandTest extends QuorumTestHarness with
Logging {
private def
chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632120413
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory,
private final Te
[
https://issues.apache.org/jira/browse/KAFKA-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853439#comment-17853439
]
Chia-Ping Tsai commented on KAFKA-16922:
sure, please feel free to take over thi
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853441#comment-17853441
]
Hector Geraldino commented on KAFKA-12199:
--
Hey [~chia7712],
Now that all conn
abhijeetk88 commented on PR #15820:
URL: https://github.com/apache/kafka/pull/15820#issuecomment-2156212270
@kamalcph I have addressed your comments, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1632125146
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedExcepti
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853443#comment-17853443
]
Chia-Ping Tsai commented on KAFKA-16921:
the streams module can be addressed by
[
https://issues.apache.org/jira/browse/KAFKA-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-15623:
--
Assignee: 黃竣陽
> Migrate remaining tests in streams module to JUnit 5
> --
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16921:
---
Summary: Migrate all junit 4 assert to junit 5 for connect module (was:
Migrate all junit 4
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853444#comment-17853444
]
Hector Geraldino commented on KAFKA-12199:
--
Sorry, what I meant is that the Moc
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127500
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1166,7 +1166,9 @@ class DynamicRemoteLogConfig(server: KafkaBroker) extends
BrokerReconfigura
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127666
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1195,13 +1214,19 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
soarez merged PR #16252:
URL: https://github.com/apache/kafka/pull/16252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632133058
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1179,14 +1181,31 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
abhijeetk88 commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2156228028
@satishd I have addressed your comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1632136201
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -211,178 +220,52 @@ public void testResetPositionsProcessFa
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1632143665
##
build.gradle:
##
@@ -3248,7 +3248,6 @@ project(':connect:runtime') {
testImplementation project(':group-coordinator')
testImplementation libs.junitJ
[
https://issues.apache.org/jira/browse/KAFKA-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16921:
---
Description:
# replace all "org.junit.Assert." by "org.junit.jupiter.api.Assertions.".
# re
1 - 100 of 117 matches
Mail list logo
