gongxuanzhang opened a new pull request, #16277:
URL: https://github.com/apache/kafka/pull/16277
The original author added a note in `BuiltInPartitioner`
> Visible and used for testing only
I think this will break the scope.
After compilation, the test module and the source cod
chia7712 merged PR #16262:
URL: https://github.com/apache/kafka/pull/16262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2159863343
Hi @chia7712, I have do a small change based on your feedback, PTAL 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
omkreddy merged PR #16238:
URL: https://github.com/apache/kafka/pull/16238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gongxuanzhang commented on PR #16262:
URL: https://github.com/apache/kafka/pull/16262#issuecomment-2159837707
@chia7712 plz take a look,think you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gongxuanzhang commented on PR #16262:
URL: https://github.com/apache/kafka/pull/16262#issuecomment-2159836214
# Failed test
## JDK 21 and Scala 2.13
| test | jira |
|---|---|
| testOutdatedCoordinatorAssignment |
https://issues.apache.org/jira/browse/KAFKA-15900 |
kamalcph commented on PR #16203:
URL: https://github.com/apache/kafka/pull/16203#issuecomment-2159792782
> @kamalcph Can you raise a PR against 3.8 branch as I would like those
changes to be reviewed in PR as it has conflicts with that branch?
Opened #16275 and #16276 to cherry-pick t
kamalcph commented on PR #16276:
URL: https://github.com/apache/kafka/pull/16276#issuecomment-2159792056
This PR is built on top of #16275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kamalcph opened a new pull request, #16276:
URL: https://github.com/apache/kafka/pull/16276
Reviewers: Satish Duggana , Luke Chen
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [
kamalcph opened a new pull request, #16275:
URL: https://github.com/apache/kafka/pull/16275
KIP-1018, part1, Introduce remote.fetch.max.timeout.ms to configure
DelayedRemoteFetch timeout
Reviewers: Luke Chen
### Committer Checklist (excluded from commit message)
- [ ] V
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1634156488
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1634155239
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetMapTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
gharris1727 commented on PR #16273:
URL: https://github.com/apache/kafka/pull/16273#issuecomment-2159746582
I still see some remaining flakiness in this test.
It fails ~10% of the time at 30% CPU, rising to ~70% of the time at 15% CPU.
The failures are mostly this one:
```
cau
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1634144659
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,155 @@
import org.apache.kafka.common.record.TimestampType;
i
chia7712 commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1634135771
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,432 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1634131546
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1634130364
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,833 +16,962 @@
*/
package org.apache.kafka.tools.consumer.gro
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853873#comment-17853873
]
Chia-Ping Tsai commented on KAFKA-16929:
{quote}
Therefore, we can try to add s
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853874#comment-17853874
]
Chia-Ping Tsai commented on KAFKA-16929:
{quote}
We could consider something li
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853863#comment-17853863
]
dujian0068 commented on KAFKA-16929:
I agree you point that need unify the "usage"
kirktrue commented on code in PR #16241:
URL: https://github.com/apache/kafka/pull/16241#discussion_r1634066822
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -514,10 +514,11 @@ private void fetchOffsetsWithRetries(final
Of
kirktrue commented on code in PR #16241:
URL: https://github.com/apache/kafka/pull/16241#discussion_r1634062217
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1132,12 +1133,26 @@ private CompletableFuture> addOffsetFetch
kirktrue commented on code in PR #16241:
URL: https://github.com/apache/kafka/pull/16241#discussion_r1634061316
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1132,12 +1133,26 @@ private CompletableFuture> addOffsetFetch
chia7712 commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2159632052
> That said, slf4j 2.0 moves to a different approach that seems much simpler:
that is a interesting suggestion. In order to address that, we need to
complete following tasks:
[ https://issues.apache.org/jira/browse/KAFKA-15630 ]
Ganesh Sadanala deleted comment on KAFKA-15630:
-
was (Author: JIRAUSER305566):
[~mimaison] PR raised: [https://github.com/apache/kafka/pull/16080] Please
review it.
> Improve documentat
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853857#comment-17853857
]
Chia-Ping Tsai commented on KAFKA-16929:
{quote}
Unifying the way of assertions
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853856#comment-17853856
]
Ismael Juma commented on KAFKA-16929:
-
We could consider something like
[https://do
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853855#comment-17853855
]
Ismael Juma commented on KAFKA-16929:
-
"third-party assertion does not offer good er
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853851#comment-17853851
]
dujian0068 commented on KAFKA-16929:
hello
Unifying the way of assertions is a valu
ijuma commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2159577302
The problem with this approach is that it forces the choice of logging
library for users that use `tools` as a library, which is inconsistent with the
approach we picked for the `core` modu
chia7712 commented on code in PR #16255:
URL: https://github.com/apache/kafka/pull/16255#discussion_r1634021872
##
clients/src/test/java/org/apache/kafka/clients/admin/NewTopicTest.java:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
showuon commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2159575190
Thanks for the review. I've merged it to make `./gradlew jar` works as
before. We can always improve it later.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16929:
---
Issue Type: Wish (was: New Feature)
> Conside defining kafka-specified assertion to unify t
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853847#comment-17853847
]
Chia-Ping Tsai commented on KAFKA-16929:
[~ijuma] thanks for your response!
{q
showuon commented on code in PR #16264:
URL: https://github.com/apache/kafka/pull/16264#discussion_r1634018574
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -556,10 +557,15 @@ public static Set
generateRandomTopicPartitions(int numTopic, in
* @retur
showuon commented on code in PR #16264:
URL: https://github.com/apache/kafka/pull/16264#discussion_r1634016604
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -556,10 +557,15 @@ public static Set
generateRandomTopicPartitions(int numTopic, in
* @retur
chia7712 commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r163401
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1018,8 +1018,8 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853845#comment-17853845
]
Ismael Juma commented on KAFKA-16929:
-
Isn't there an existing library that does thi
[
https://issues.apache.org/jira/browse/KAFKA-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16924.
---
Resolution: Fixed
> No log output when running kafka
> -
>
>
showuon merged PR #16260:
URL: https://github.com/apache/kafka/pull/16260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1634010611
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##
@@ -1508,25 +1545,25 @@ private List
allocat
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16929:
---
Description:
There are many contributors who trying to fix chaos of kafka testing. That
inc
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16929:
---
Description:
There are many contributors who trying to fix chaos of kafka testing. That
inc
appchemist commented on PR #16043:
URL: https://github.com/apache/kafka/pull/16043#issuecomment-2159551660
Thanks for review @lucasbru
Thank you again for taking the time to review. @philipnee @lianetm @kirktrue
--
This is an automated message from the Apache Git Service.
To respond t
appchemist commented on code in PR #16043:
URL: https://github.com/apache/kafka/pull/16043#discussion_r1634006443
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##
@@ -199,4 +234,4 @@ public void prepareFindCoordinatorRespons
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1634004534
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,155 @@
import org.apache.kafka.common.record.TimestampType;
imp
[
https://issues.apache.org/jira/browse/KAFKA-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853841#comment-17853841
]
PoAn Yang commented on KAFKA-16929:
---
Hi [~chia7712], thanks for the good suggestion. I
chia7712 commented on code in PR #16231:
URL: https://github.com/apache/kafka/pull/16231#discussion_r1633997795
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Chia-Ping Tsai created KAFKA-16929:
--
Summary: Conside defining kafka-specified assertion to unify
testing style
Key: KAFKA-16929
URL: https://issues.apache.org/jira/browse/KAFKA-16929
Project: Kafka
apoorvmittal10 opened a new pull request, #16274:
URL: https://github.com/apache/kafka/pull/16274
The implementation for share-fetch `next-fetch-offset` in share partition
and acquiring records from log.
The Next Fetch Offset (NFO) determines where the Share Partition should
initiate
cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1633905881
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -29,19 +32,22 @@ public class QuorumInfo {
private final long highWatermark;
pr
ableegoldman commented on code in PR #16269:
URL: https://github.com/apache/kafka/pull/16269#discussion_r1633870091
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -920,8 +919,8 @@ private boolean populateClientStatesMap
[
https://issues.apache.org/jira/browse/KAFKA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853823#comment-17853823
]
Greg Harris commented on KAFKA-16225:
-
This PR: [https://github.com/apache/kafka/pul
[
https://issues.apache.org/jira/browse/KAFKA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16225:
Attachment: Screenshot 2024-06-10 at 2.39.54 PM.png
> Flaky test suite LogDirFailureTest
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-9228:
-
Fix Version/s: 3.7.1
> Reconfigured converters and clients may not be propagated to connector tas
[
https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-14567.
-
Assignee: (was: Kirk True)
Resolution: Fixed
Not 100% sure either, but I feel
[
https://issues.apache.org/jira/browse/KAFKA-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853815#comment-17853815
]
Matthias J. Sax commented on KAFKA-16925:
-
Thanks for filing this ticket – it's
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-9228:
-
Fix Version/s: 3.8.0
(was: 4.0.0)
> Reconfigured converters and clients ma
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-9228:
-
Fix Version/s: (was: 3.9.0)
> Reconfigured converters and clients may not be propagated to co
[
https://issues.apache.org/jira/browse/KAFKA-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-16837:
--
Fix Version/s: (was: 3.9.0)
> Kafka Connect fails on update connector for incorrect previo
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-16838:
--
Fix Version/s: (was: 3.9.0)
> Kafka Connect loads old tasks from removed connectors
>
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-9228:
-
Fix Version/s: 4.0.0
> Reconfigured converters and clients may not be propagated to connector tas
jolshan commented on PR #16229:
URL: https://github.com/apache/kafka/pull/16229#issuecomment-2159278838
> producer.beginTransaction()
try {
producer.send(record).get()
fail("expected ProducerFencedException") // <- test failed here
Interesting. I tho
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-9228.
--
Fix Version/s: 3.9.0
Resolution: Fixed
> Reconfigured converters and clients may not be
C0urante merged PR #16053:
URL: https://github.com/apache/kafka/pull/16053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on PR #16053:
URL: https://github.com/apache/kafka/pull/16053#issuecomment-2159277004
Last changes are trivial and build and unit tests passed locally, as well as
the newly-introduced integration test. Merging...
--
This is an automated message from the Apache Git Servi
gharris1727 commented on PR #16143:
URL: https://github.com/apache/kafka/pull/16143#issuecomment-2159265832
Okay thank you for the clarification @anton-liauchuk . While avoiding
confusing one operation for another by turning off all-but-one operation avoids
the ambiguity, it still leaves th
edoardocomar commented on PR #16229:
URL: https://github.com/apache/kafka/pull/16229#issuecomment-2159263370
Hi @jolshan would you like any further changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
C0urante commented on code in PR #16053:
URL: https://github.com/apache/kafka/pull/16053#discussion_r1633815726
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/AppliedConnectorConfig.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (
C0urante opened a new pull request, #16273:
URL: https://github.com/apache/kafka/pull/16273
This test has been flaky since it was merged to trunk. To date, there have
been 566 successful runs and 8 flaky failures (see [Gradle Enterprise
analysis](https://ge.apache.org/scans/tests?search.rel
mjsax commented on code in PR #16265:
URL: https://github.com/apache/kafka/pull/16265#discussion_r1633793710
##
docs/streams/upgrade-guide.html:
##
@@ -134,11 +134,44 @@ <
Streams API changes in 3.8.0
+
+
+Kafka Streams now supports customizable task ass
ganesh-sadanala commented on PR #16080:
URL: https://github.com/apache/kafka/pull/16080#issuecomment-2159220165
@gharris1727 Thank you! I totally understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/KAFKA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-15630:
---
Assignee: (was: Ganesh Sadanala)
> Improve documentation of offset.lag.max
> --
gharris1727 commented on PR #16080:
URL: https://github.com/apache/kafka/pull/16080#issuecomment-2159216114
Hi @ganesh-sadanala Unfortunately I don't think we can move forward with
this PR.
You've linked and mis-represented two pieces of documentation that are not
Apache-2.0 license
gharris1727 closed pull request #16080: KAFKA-15630 Improve documentation of
offset.lag.max
URL: https://github.com/apache/kafka/pull/16080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1633783863
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
gharris1727 commented on code in PR #16053:
URL: https://github.com/apache/kafka/pull/16053#discussion_r1633644553
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/AppliedConnectorConfig.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundatio
wernerdv commented on PR #16077:
URL: https://github.com/apache/kafka/pull/16077#issuecomment-2159017044
@soarez @pprovenzano @chia7712 Hello, please, take a look this small fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jolshan commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1633660092
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -711,8 +752,16 @@ private void flushCurrentBatch() {
jolshan commented on PR #16215:
URL: https://github.com/apache/kafka/pull/16215#issuecomment-2159004801
@dajac makes sense. I guess I just didn't know if there was a case where we
had one in a batch so it wasn't written to the log yet, but we tried to commit
offsets.
Thanks for clar
mjsax closed pull request #16271: Merge trunk
URL: https://github.com/apache/kafka/pull/16271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsub
mjsax opened a new pull request, #16271:
URL: https://github.com/apache/kafka/pull/16271
Resolved merge conflict in `gradle/dependencies.gradle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
brandboat commented on code in PR #16231:
URL: https://github.com/apache/kafka/pull/16231#discussion_r1633639458
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
dajac commented on PR #16215:
URL: https://github.com/apache/kafka/pull/16215#issuecomment-2158967828
@jolshan Committing offsets above the last written offset is not allowed so
it is probably not necessary. We already have tests to validate the logic to
commit offsets up to the last writte
José Armando GarcÃa Sancio created KAFKA-16928:
--
Summary: Test all of the request and response methods in RaftUtil
Key: KAFKA-16928
URL: https://issues.apache.org/jira/browse/KAFKA-16928
P
adixitconfluent commented on code in PR #16268:
URL: https://github.com/apache/kafka/pull/16268#discussion_r1633612948
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1455,6 +1487,30 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dyna
jolshan commented on PR #16215:
URL: https://github.com/apache/kafka/pull/16215#issuecomment-2158928929
Looks pretty good. I was wondering -- do we want to test the behavior of
when we commit before a batch is flushed? (Is this possible)
--
This is an automated message from the Apache Git
rajinisivaram commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2158922004
@ivanyu Also need to fix unit tests that are failing because of the change
from Node to LeastLoadedNode and resolve merge conflicts.
--
This is an automated message from the Apach
rajinisivaram commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1633579132
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1122,13 +1141,26 @@ public long maybeUpdate(long now) {
// Beware that
jolshan commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1633578691
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -583,11 +674,330 @@ private void unload() {
}
jolshan commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1631442094
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -583,11 +674,330 @@ private void unload() {
}
jolshan commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1633578691
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -583,11 +674,330 @@ private void unload() {
}
Alyssa Huang created KAFKA-16927:
Summary: Adding tests for restarting followers receiving leader
endpoint correctly
Key: KAFKA-16927
URL: https://issues.apache.org/jira/browse/KAFKA-16927
Project: Ka
[
https://issues.apache.org/jira/browse/KAFKA-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang updated KAFKA-16926:
-
Component/s: kraft
> Optimize BeginQuorumEpoch heartbeat
> ---
>
[
https://issues.apache.org/jira/browse/KAFKA-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang updated KAFKA-16926:
-
Description:
Instead of sending out BeginQuorum requests to every voter on a cadence, we can
sa
Alyssa Huang created KAFKA-16926:
Summary: Optimize BeginQuorumEpoch heartbeat
Key: KAFKA-16926
URL: https://issues.apache.org/jira/browse/KAFKA-16926
Project: Kafka
Issue Type: Sub-task
omkreddy commented on code in PR #16268:
URL: https://github.com/apache/kafka/pull/16268#discussion_r1633540628
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1455,6 +1487,30 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
muralibasani commented on PR #16255:
URL: https://github.com/apache/kafka/pull/16255#issuecomment-2158838080
@chia7712 looks like the failed tests in the ci are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jolshan commented on code in PR #16215:
URL: https://github.com/apache/kafka/pull/16215#discussion_r1633532863
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -583,11 +674,339 @@ private void unload() {
}
AndrewJSchofield commented on PR #16212:
URL: https://github.com/apache/kafka/pull/16212#issuecomment-2158830511
@omkreddy We need KIP-1014 (under discussion) to do this. I'll leave this PR
in draft state for now. We need to find another way to turn KIP-932 on and off
for now.
--
This is
1 - 100 of 203 matches
Mail list logo
