Re: [PR] MINOR: Remove outdated KafkaRaftClient javadoc [kafka]

2025-07-12 Thread via GitHub
fvaleri closed pull request #20160: MINOR: Remove outdated KafkaRaftClient javadoc URL: https://github.com/apache/kafka/pull/20160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] MINOR: Remove outdated KafkaRaftClient javadoc [kafka]

2025-07-12 Thread via GitHub
fvaleri opened a new pull request, #20160: URL: https://github.com/apache/kafka/pull/20160 Remove outdated KafkaRaftClient javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-19070: add taskId to consumer override clientId [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] commented on PR #19382: URL: https://github.com/apache/kafka/pull/19382#issuecomment-3066542553 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] closed pull request #19082: KAFKA-17014: ScramFormatter should not use String for password URL: https://github.com/apache/kafka/pull/19082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] commented on PR #19082: URL: https://github.com/apache/kafka/pull/19082#issuecomment-3066541896 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Support keystore with multiple alias entries [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] commented on PR #17560: URL: https://github.com/apache/kafka/pull/17560#issuecomment-3066541006 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17444: fix high memory allocation rate for FetchSession.update [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] commented on PR #17052: URL: https://github.com/apache/kafka/pull/17052#issuecomment-3066540787 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Cleanup Connect Module (2/n) [kafka]

2025-07-12 Thread via GitHub
github-actions[bot] commented on PR #19871: URL: https://github.com/apache/kafka/pull/19871#issuecomment-3066499609 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Upgrade log4j to version 2.25.0 [kafka]

2025-07-12 Thread via GitHub
ijuma commented on code in PR #20132: URL: https://github.com/apache/kafka/pull/20132#discussion_r2202883294 ## gradle/dependencies.gradle: ## @@ -104,7 +104,7 @@ versions += [ kafka_38: "3.8.1", kafka_39: "3.9.1", kafka_40: "4.0.0", - log4j2: "2.24.3", + log4j2: "2.2

Re: [PR] MINOR: Upgrade log4j to version 2.25.0 [kafka]

2025-07-12 Thread via GitHub
ijuma commented on code in PR #20132: URL: https://github.com/apache/kafka/pull/20132#discussion_r2202883431 ## gradle/dependencies.gradle: ## @@ -104,7 +104,7 @@ versions += [ kafka_38: "3.8.1", kafka_39: "3.9.1", kafka_40: "4.0.0", - log4j2: "2.24.3", + log4j2: "2.2

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-12 Thread via GitHub
lucliu1108 commented on code in PR #20157: URL: https://github.com/apache/kafka/pull/20157#discussion_r2202883337 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -830,6 +831,21 @@ Map> retrieveInternalTopics(List groupIds) {

Re: [PR] MINOR: Upgrade log4j to version 2.25.0 [kafka]

2025-07-12 Thread via GitHub
ijuma commented on code in PR #20132: URL: https://github.com/apache/kafka/pull/20132#discussion_r2202883294 ## gradle/dependencies.gradle: ## @@ -104,7 +104,7 @@ versions += [ kafka_38: "3.8.1", kafka_39: "3.9.1", kafka_40: "4.0.0", - log4j2: "2.24.3", + log4j2: "2.2

Re: [PR] MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used [kafka]

2025-07-12 Thread via GitHub
squah-confluent commented on code in PR #20024: URL: https://github.com/apache/kafka/pull/20024#discussion_r2202026091 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -421,6 +452,27 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterI

Re: [PR] MINOR Fix: API Responses missing latest version in Kafka protocol guide [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on PR #19769: URL: https://github.com/apache/kafka/pull/19769#issuecomment-3065869429 > would be good to add a test so we don't regress in the future. agree. @andy1li Do you have bandwidth to file a PR? If not, we could take over it :) -- This is an automated me

Re: [PR] MINOR Fix: API Responses missing latest version in Kafka protocol guide [kafka]

2025-07-12 Thread via GitHub
ijuma commented on PR #19769: URL: https://github.com/apache/kafka/pull/19769#issuecomment-3065866080 Thanks for the fix. Ir would be good to add a test so we don't regress in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (reset-offsets) [1/N] [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2202821239 ## tools/src/main/java/org/apache/kafka/tools/OffsetsUtils.java: ## @@ -0,0 +1,474 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] KAFKA-19435: Optimize `kafka-consumer-groups.sh` to return the offset info when some partitions without leaders [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #20064: URL: https://github.com/apache/kafka/pull/20064#discussion_r2202816352 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java: ## @@ -631,7 +635,34 @@ else if (logEndOffsetResult.getValue() instanceof Offs

Re: [PR] MINOR: Cleanups in storage module [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on PR #20087: URL: https://github.com/apache/kafka/pull/20087#issuecomment-3065841506 @mimaison could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Migrate CoordinatorLoaderImplTest from Scala to Java [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #20089: URL: https://github.com/apache/kafka/pull/20089#discussion_r2202813959 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorLoaderImpl.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] MINOR: Move ClientQuotasRequestTest to server module [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #20053: URL: https://github.com/apache/kafka/pull/20053#discussion_r2202778210 ## server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java: ## @@ -0,0 +1,727 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2202770861 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(ClientTe

Re: [PR] KAFKA-19305 Ensure all image classes are immutable [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on PR #19847: URL: https://github.com/apache/kafka/pull/19847#issuecomment-3065619353 @jim0987795064 could you please use `record` class to rewrite `ClientQuotaImage` and `TopicImage`? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-12 Thread via GitHub
chia7712 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2202705619 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2963,9 +2981,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-12 Thread via GitHub
chickenchickenlove commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2202465423 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionalRequestResult.java: ## @@ -48,15 +49,24 @@ public void done() { }

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-12 Thread via GitHub
karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2202454037 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,16 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetChec

Re: [PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-12 Thread via GitHub
frankvicky commented on code in PR #20157: URL: https://github.com/apache/kafka/pull/20157#discussion_r2202450911 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -830,6 +831,21 @@ Map> retrieveInternalTopics(List groupIds) {

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-12 Thread via GitHub
frankvicky commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2202438506 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionalRequestResult.java: ## @@ -48,15 +49,24 @@ public void done() { } publi

Re: [PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-12 Thread via GitHub
frankvicky commented on code in PR #20159: URL: https://github.com/apache/kafka/pull/20159#discussion_r2202438506 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionalRequestResult.java: ## @@ -48,15 +49,24 @@ public void done() { } publi