Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2275659257 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3271,13 +3317,56 @@ private long pollFollowerAsVoter(FollowerState state, long currentTimeMs)

[jira] [Created] (KAFKA-19605) Fix the busy loop occurring in the broker observer

2025-08-13 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19605: -- Summary: Fix the busy loop occurring in the broker observer Key: KAFKA-19605 URL: https://issues.apache.org/jira/browse/KAFKA-19605 Project: Kafka Issue

[jira] [Updated] (KAFKA-19605) Fix the busy loop occurring in the broker observer

2025-08-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19605: --- Fix Version/s: 4.2.0 > Fix the busy loop occurring in the broker observer >

Re: [PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
see-quick commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2275559588 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ## @@ -143,6 +143,7 @@ public static void main(String[] args) throws Exception {

Re: [PR] KAFKA-18699: Cleanup Metadata Module [kafka]

2025-08-13 Thread via GitHub
sjhajharia commented on PR #20346: URL: https://github.com/apache/kafka/pull/20346#issuecomment-3187041066 Thanks @mingyen066 I have assigned the JIRA to myself and as per your suggestion got rid of some of the toString() methods as well. I did not touch the ones which use Stringify in

[jira] [Commented] (KAFKA-18699) Migrate suitable classes to records in metadata

2025-08-13 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013837#comment-18013837 ] Sanskar Jhajharia commented on KAFKA-18699: --- Hey [~mingyen066]  Assigning this

[jira] [Assigned] (KAFKA-18699) Migrate suitable classes to records in metadata

2025-08-13 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanskar Jhajharia reassigned KAFKA-18699: - Assignee: Sanskar Jhajharia (was: Ming-Yen Chung) > Migrate suitable classes t

[jira] [Commented] (KAFKA-18701) Migrate suitable classes to records in trogdor and tools module

2025-08-13 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013834#comment-18013834 ] Sanskar Jhajharia commented on KAFKA-18701: --- Hey [~mingdaoy] , If you have not

[jira] (KAFKA-18701) Migrate suitable classes to records in trogdor and tools module

2025-08-13 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18701 ] Sanskar Jhajharia deleted comment on KAFKA-18701: --- was (Author: JIRAUSER303707): Hey [~mingdaoy] , if you have not started working on the same, can I take up the same? I have a PR alre

[jira] [Commented] (KAFKA-18701) Migrate suitable classes to records in trogdor and tools module

2025-08-13 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013833#comment-18013833 ] Sanskar Jhajharia commented on KAFKA-18701: --- Hey [~mingdaoy] , if you have not

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-08-13 Thread via GitHub
sjhajharia commented on code in PR #20180: URL: https://github.com/apache/kafka/pull/20180#discussion_r2275435455 ## server/src/main/java/org/apache/kafka/server/purgatory/DelayedDeleteRecords.java: ## @@ -57,7 +56,7 @@ public DelayedDeleteRecords(long delayMs,

Re: [PR] MINOR: Cleanup Connect Module (3/n) [kafka]

2025-08-13 Thread via GitHub
sjhajharia commented on code in PR #20156: URL: https://github.com/apache/kafka/pull/20156#discussion_r2275311819 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -4188,12 +4186,12 @@ private void expectRebalance(fin

Re: [PR] KAFKA-15853: Move static functions from KafkaConfig to AbstractKafkaConfig (wip) [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] closed pull request #19466: KAFKA-15853: Move static functions from KafkaConfig to AbstractKafkaConfig (wip) URL: https://github.com/apache/kafka/pull/19466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15853: Move static functions from KafkaConfig to AbstractKafkaConfig (wip) [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] commented on PR #19466: URL: https://github.com/apache/kafka/pull/19466#issuecomment-3186705431 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Return friendly prompt when no quota configs found [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] commented on PR #18808: URL: https://github.com/apache/kafka/pull/18808#issuecomment-3186705328 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15038: Replace topicIdByPartitionMap with MetadataCache instance in RemoteLogManager [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] commented on PR #20256: URL: https://github.com/apache/kafka/pull/20256#issuecomment-3186663045 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] PoC: Add `rewrite` support for `RemoveUnusedImports` [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] commented on PR #20314: URL: https://github.com/apache/kafka/pull/20314#issuecomment-3186662877 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16926: Optimize BeginQuorumEpoch heartbeat [kafka]

2025-08-13 Thread via GitHub
github-actions[bot] commented on PR #20318: URL: https://github.com/apache/kafka/pull/20318#issuecomment-3186662831 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-19168) MirrorMaker kafka_metrics_count metric is always incorrect

2025-08-13 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013823#comment-18013823 ] Jhen-Yung Hsu commented on KAFKA-19168: --- Here is the KIP: https://cwiki.apache.org

Re: [PR] KAFKA-19168: MirrorMaker kafka_metrics_count metric is always incorrect [kafka]

2025-08-13 Thread via GitHub
Yunyung commented on PR #19573: URL: https://github.com/apache/kafka/pull/19573#issuecomment-3186609003 Here is the KIP: https://cwiki.apache.org/confluence/x/vomKFQ. I also created the discussion thread a few days ago: https://lists.apache.org/thread/vdhfxlzkb8z7gpgky69y9qxw9cqjpog8. Th

Re: [PR] KAFKA-19042: Move AdminClientWithPoliciesIntegrationTest to clients-integration-tests module [kafka]

2025-08-13 Thread via GitHub
Yunyung commented on PR #20339: URL: https://github.com/apache/kafka/pull/20339#issuecomment-3186577144 > @Yunyung : Could you please merge the trunk to trigger ci again? Done. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KAFKA-19596) Log auto topic creation failures more visibly

2025-08-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-19596. --- Fix Version/s: 4.2.0 Resolution: Fixed > Log auto topic creation failures more visibly >

Re: [PR] KAFKA-19596: Improve visibility when topic auto-creation fails [kafka]

2025-08-13 Thread via GitHub
showuon merged PR #20340: URL: https://github.com/apache/kafka/pull/20340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Cleanup Metadata Module [kafka]

2025-08-13 Thread via GitHub
mingyen066 commented on code in PR #20346: URL: https://github.com/apache/kafka/pull/20346#discussion_r2275191518 ## metadata/src/main/java/org/apache/kafka/controller/BrokerControlStates.java: ## @@ -17,37 +17,7 @@ package org.apache.kafka.controller; -import java.util.Obj

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2275149725 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -112,6 +128,45 @@ class DefaultAutoTopicCreationManager( } } + override def getTopicC

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2275159146 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2889,6 +2889,24 @@ class KafkaApis(val requestChannel: RequestChannel, } } else {

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2275144231 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -64,6 +77,9 @@ class DefaultAutoTopicCreationManager( ) extends AutoTopicCreationManager with L

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2275137991 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -64,6 +77,9 @@ class DefaultAutoTopicCreationManager( ) extends AutoTopicCreationManager with L

[jira] [Commented] (KAFKA-19430) Don't fail on RecordCorruptedException

2025-08-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013819#comment-18013819 ] Matthias J. Sax commented on KAFKA-19430: - {quote}About CONTINUE case: exception

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2274993836 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -244,8 +258,13 @@ public void shouldRestoreNullRecord()

Re: [PR] KAFKA-19447: Replace PartitionState with PartitionRegistration in makeFollower/makeLeader [kafka]

2025-08-13 Thread via GitHub
mingyen066 commented on code in PR #20335: URL: https://github.com/apache/kafka/pull/20335#discussion_r2275013842 ## core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala: ## @@ -86,31 +86,33 @@ class AssignmentStateTest extends AbstractPartitionTest { @Parameter

Re: [PR] KAFKA-19384: The passing of BrokerRegistrationRequestTest is a false positive [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20338: URL: https://github.com/apache/kafka/pull/20338#discussion_r2274997289 ## core/src/test/java/kafka/server/BrokerRegistrationRequestTest.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2274987340 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -814,29 +838,56 @@ private void createStateForRestorati

Re: [PR] KAFKA-1194: changes needed to run on Windows [kafka]

2025-08-13 Thread via GitHub
x1ng-z commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-3186300818 is it available in v4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Assigned] (KAFKA-19604) Document controller.quorum.auto.join.enable config in upgrade.html

2025-08-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19604: -- Assignee: Kevin Wu > Document controller.quorum.auto.join.enable config in upgrade.ht

Re: [PR] MINOR: Use lambda expressions instead of ImmutableValue for Gauges [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on PR #20351: URL: https://github.com/apache/kafka/pull/20351#issuecomment-3186286761 @mingyen066 please fix the build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-19604) Document controller.quorum.auto.join.enable config in upgrade.html

2025-08-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013802#comment-18013802 ] Chia-Ping Tsai commented on KAFKA-19604: [~kevinwu2412] Please feel free to unas

Re: [PR] MINOR: Cleanup Connect Module (3/n) [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20156: URL: https://github.com/apache/kafka/pull/20156#discussion_r2274910909 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -4188,12 +4186,12 @@ private void expectRebalance(final

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-13 Thread via GitHub
mjsax commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2274742917 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -815,28 +826,28 @@ private void createStateForRestorati

[jira] [Comment Edited] (KAFKA-19430) Don't fail on RecordCorruptedException

2025-08-13 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013769#comment-18013769 ] Uladzislau Blok edited comment on KAFKA-19430 at 8/13/25 8:24 PM:

[jira] [Commented] (KAFKA-19430) Don't fail on RecordCorruptedException

2025-08-13 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013769#comment-18013769 ] Uladzislau Blok commented on KAFKA-19430: - I'm not fully sure for now what would

Re: [PR] MINOR: Migrate EligibleLeaderReplicasIntegrationTest to use new test infra [kafka]

2025-08-13 Thread via GitHub
jim0987795064 commented on code in PR #20199: URL: https://github.com/apache/kafka/pull/20199#discussion_r2274402970 ## server/src/test/java/org/apache/kafka/server/EligibleLeaderReplicasIntegrationTest.java: ## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-13 Thread via GitHub
lianetm commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2274334185 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -243,8 +237,11 @@ public CompletableFuture updateFetchPositions(

Re: [PR] MINOR: Remove SPAM URL in Streams Documentation [kafka]

2025-08-13 Thread via GitHub
mjsax commented on PR #20321: URL: https://github.com/apache/kafka/pull/20321#issuecomment-3185174405 Thanks. Merged the other PR. Also took the liberty to cherry-pick this commit to 4.1, 4.0, and 3.9 branches. -- As we are getting a new RC for 4.0.1 release, it should pickup the cha

[jira] [Commented] (KAFKA-19556) [Connect] Provide a configuration to disable SNI required and SNI host checking for the REST API

2025-08-13 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013762#comment-18013762 ] oshione gabriel esiemokhai commented on KAFKA-19556: Yes exactly so

Re: [PR] MINOR: Migrate EligibleLeaderReplicasIntegrationTest to use new test infra [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20199: URL: https://github.com/apache/kafka/pull/20199#discussion_r227423 ## server/src/test/java/org/apache/kafka/server/EligibleLeaderReplicasIntegrationTest.java: ## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-19447: Replace PartitionState with PartitionRegistration in makeFollower/makeLeader [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20335: URL: https://github.com/apache/kafka/pull/20335#discussion_r2274273267 ## core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala: ## @@ -86,31 +86,33 @@ class AssignmentStateTest extends AbstractPartitionTest { @Parameteriz

[jira] [Assigned] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2025-08-13 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-10789: - Assignee: Ksolves India Limited (was: Ryan Ye) > Streamlining Tests in

[jira] [Commented] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2025-08-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013755#comment-18013755 ] Matthias J. Sax commented on KAFKA-10789: - Please go ahead. It seems Ryan had dr

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20180: URL: https://github.com/apache/kafka/pull/20180#discussion_r2274230694 ## server/src/test/java/org/apache/kafka/network/SocketServerConfigsTest.java: ## @@ -36,7 +36,7 @@ public void testDefaultNameToSecurityProto() { new

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20180: URL: https://github.com/apache/kafka/pull/20180#discussion_r2274207213 ## server/src/main/java/org/apache/kafka/server/config/ClientQuotaManagerConfig.java: ## @@ -15,6 +15,7 @@ * limitations under the License. */ package org.apache.

Re: [PR] KAFKA-18613: Auto-creation of internal topics in streams group heartbeat [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #18981: URL: https://github.com/apache/kafka/pull/18981#discussion_r2274188359 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -83,9 +89,30 @@ class DefaultAutoTopicCreationManager( uncreatableTopicResponses ++ crea

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-08-13 Thread via GitHub
junrao commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2271552627 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftLog.java: ## @@ -0,0 +1,829 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2274143020 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3271,13 +3317,56 @@ private long pollFollowerAsVoter(FollowerState state, long currentTimeMs)

[PR] MINOR: Use lambda expressions instead of ImmutableValue for Gauges [kafka]

2025-08-13 Thread via GitHub
mingyen066 opened a new pull request, #20351: URL: https://github.com/apache/kafka/pull/20351 Refactor metric gauges instantiation to use lambda expressions instead of ImmutableValue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-13 Thread via GitHub
kirktrue commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2273992582 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -120,14 +124,23 @@ public class RestoreIntegrationTe

Re: [PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2273963415 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ## @@ -143,6 +143,7 @@ public static void main(String[] args) throws Exception {

Re: [PR] KAFKA-18613: Auto-creation of internal topics in streams group heartbeat [kafka]

2025-08-13 Thread via GitHub
brandboat commented on code in PR #18981: URL: https://github.com/apache/kafka/pull/18981#discussion_r2273873010 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -83,9 +89,30 @@ class DefaultAutoTopicCreationManager( uncreatableTopicResponses ++ cre

Re: [PR] KAFKA-18613: Auto-creation of internal topics in streams group heartbeat [kafka]

2025-08-13 Thread via GitHub
brandboat commented on code in PR #18981: URL: https://github.com/apache/kafka/pull/18981#discussion_r2273873010 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -83,9 +89,30 @@ class DefaultAutoTopicCreationManager( uncreatableTopicResponses ++ cre

[PR] MINOR: [1/2] Migrate AutoTopicCreationManager.scala to java [kafka]

2025-08-13 Thread via GitHub
brandboat opened a new pull request, #20350: URL: https://github.com/apache/kafka/pull/20350 Part 1: Migrate AutoTopicCreationManager.scala to Java. No functional changes; this step only converts the implementation. Part 2 will migrate AutoTopicCreationManagerTest.scala to Java. -- This

Re: [PR] KAFKA-18613: Auto-creation of internal topics in streams group heartbeat [kafka]

2025-08-13 Thread via GitHub
brandboat commented on code in PR #18981: URL: https://github.com/apache/kafka/pull/18981#discussion_r2273873010 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -83,9 +89,30 @@ class DefaultAutoTopicCreationManager( uncreatableTopicResponses ++ cre

[jira] [Resolved] (KAFKA-19078) Implement automatic controller addition to cluster metadata partition

2025-08-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19078. Resolution: Fixed > Implement automatic controller addition to cluster metadata partition

Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-13 Thread via GitHub
chia7712 merged PR #19589: URL: https://github.com/apache/kafka/pull/19589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-13 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2273790581 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -102,6 +103,11 @@ public class QuorumConfig { public static final String QUORUM_RETRY_BACKO

[jira] [Created] (KAFKA-19604) Document controller.quorum.auto.join.enable config in upgrade.html

2025-08-13 Thread Kevin Wu (Jira)
Kevin Wu created KAFKA-19604: Summary: Document controller.quorum.auto.join.enable config in upgrade.html Key: KAFKA-19604 URL: https://issues.apache.org/jira/browse/KAFKA-19604 Project: Kafka I

Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-13 Thread via GitHub
chia7712 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2273767603 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -102,6 +103,11 @@ public class QuorumConfig { public static final String QUORUM_RETRY_BACKOFF

Re: [PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
see-quick commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2273448472 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ## @@ -143,6 +143,9 @@ public static void main(String[] args) throws Exception {

Re: [PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
see-quick commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2273447479 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ## @@ -143,6 +143,9 @@ public static void main(String[] args) throws Exception {

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273440201 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2889,6 +2889,24 @@ class KafkaApis(val requestChannel: RequestChannel, } }

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273440201 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2889,6 +2889,24 @@ class KafkaApis(val requestChannel: RequestChannel, } }

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273419281 ## core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala: ## @@ -393,4 +403,119 @@ class AutoTopicCreationManagerTest { .setNumPartitions

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273417888 ## core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala: ## @@ -393,4 +403,119 @@ class AutoTopicCreationManagerTest { .setNumPartitions

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273386686 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -263,4 +318,30 @@ class DefaultAutoTopicCreationManager( (creatableTopics, uncreat

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273380363 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -134,11 +180,20 @@ class DefaultAutoTopicCreationManager( override def onComplete(

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273377362 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -134,11 +180,20 @@ class DefaultAutoTopicCreationManager( override def onComplete(

[jira] [Commented] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2025-08-13 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013681#comment-18013681 ] Ksolves India Limited commented on KAFKA-10789: --- [~mjsax] It seems like th

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273302083 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -135,10 +190,17 @@ class DefaultAutoTopicCreationManager( clearInflightRequests(

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273282296 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -135,10 +190,17 @@ class DefaultAutoTopicCreationManager( clearInflightRequests(

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273282296 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -135,10 +190,17 @@ class DefaultAutoTopicCreationManager( clearInflightRequests(

Re: [PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
mimaison commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2273276617 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ## @@ -143,6 +143,9 @@ public static void main(String[] args) throws Exception {

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273257251 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -112,6 +128,45 @@ class DefaultAutoTopicCreationManager( } } + override def ge

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-08-13 Thread Krzysztof Barczynski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013672#comment-18013672 ] Krzysztof Barczynski commented on KAFKA-19012: -- [~junrao] We experienced th

Re: [PR] MINOR: Expose internal topic creation errors to the user [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2273217176 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -53,17 +55,34 @@ trait AutoTopicCreationManager { requestContext: RequestContext

[jira] [Commented] (KAFKA-19601) always disallow min.insync.replicas at the broker level

2025-08-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013671#comment-18013671 ] Chia-Ping Tsai commented on KAFKA-19601: Nice idea, Perhaps we could do the same

Re: [PR] MINOR: Port RestoreIntegrationTest to the new protocol [kafka]

2025-08-13 Thread via GitHub
aliehsaeedii commented on code in PR #20347: URL: https://github.com/apache/kafka/pull/20347#discussion_r2272990965 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -815,28 +828,28 @@ private void createStateForRe

[jira] [Commented] (KAFKA-19603) Change log.segment.bytes configuration type from int to long to support segments larger than 2GB

2025-08-13 Thread ally heev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013645#comment-18013645 ] ally heev commented on KAFKA-19603: --- [~proggga] you might want to create a KIP and add

Re: [PR] MINOR: Update apacheds to 2.0.0.AM25 [kafka]

2025-08-13 Thread via GitHub
tinaselenge commented on PR #20343: URL: https://github.com/apache/kafka/pull/20343#issuecomment-3183089299 thank you @sjhajharia for reviewing! @showuon can you please take a look and kick off the CI build when you get a chance? Thank you. -- This is an automated message from th

[jira] [Updated] (KAFKA-19603) Change log.segment.bytes configuration type from int to long to support segments larger than 2GB

2025-08-13 Thread Mikhail Fesenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Fesenko updated KAFKA-19603: Description: h2. Description h3. Summary Change the data type of *{{log.segment.bytes}}*

[jira] [Created] (KAFKA-19603) Change log.segment.bytes configuration type from int to long to support segments larger than 2GB

2025-08-13 Thread Mikhail Fesenko (Jira)
Mikhail Fesenko created KAFKA-19603: --- Summary: Change log.segment.bytes configuration type from int to long to support segments larger than 2GB Key: KAFKA-19603 URL: https://issues.apache.org/jira/browse/KAFKA-

[PR] MINOR: Fix TestLinearWriteSpeed class [kafka]

2025-08-13 Thread via GitHub
see-quick opened a new pull request, #20349: URL: https://github.com/apache/kafka/pull/20349 This PR fixes a problem related to `TestLinearWriteSpeed`. During my work on KIP-780, I discovered that benchmarks for `TestLinearWriteSpeed` do not account for compression algorithms. It always us

[jira] [Created] (KAFKA-19602) Kafka Streams join after unmaterialized transformValues on KTable with extra store fails

2025-08-13 Thread Florens Pauwels (Jira)
Florens Pauwels created KAFKA-19602: --- Summary: Kafka Streams join after unmaterialized transformValues on KTable with extra store fails Key: KAFKA-19602 URL: https://issues.apache.org/jira/browse/KAFKA-19602

[jira] [Updated] (KAFKA-19602) Kafka Streams join after unmaterialized transformValues on KTable with extra store fails

2025-08-13 Thread Florens Pauwels (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florens Pauwels updated KAFKA-19602: Description: I believe for this to occur you need # transformValues on a KTable, followed

[jira] [Commented] (KAFKA-19556) [Connect] Provide a configuration to disable SNI required and SNI host checking for the REST API

2025-08-13 Thread Tamas Kornai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013597#comment-18013597 ] Tamas Kornai commented on KAFKA-19556: -- We are routing by IP. > [Connect] Provide