[jira] [Commented] (KAFKA-17147) Improve KRaft add voter handling to tolerate waiting for delayed operations

2025-09-08 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018978#comment-18018978 ] TaiJuWu commented on KAFKA-17147: - Hi [~jsancio] , if you are not working on this, may I

[jira] [Updated] (KAFKA-19689) TopologyTestDriver spends most of its time forcing changes to disk with persistent state stores

2025-09-08 Thread Steven Schlansker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Schlansker updated KAFKA-19689: -- Summary: TopologyTestDriver spends most of its time forcing changes to disk with persi

Re: [PR] KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null [kafka]

2025-09-08 Thread via GitHub
chia7712 merged PR #17930: URL: https://github.com/apache/kafka/pull/17930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19692) improve the docs of "clusterId" for AddRaftVoterOptions and RemoveRaftVoterOptions

2025-09-08 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Logan Zhu reassigned KAFKA-19692: - Assignee: Logan Zhu (was: Chia-Ping Tsai) > improve the docs of "clusterId" for AddRaftVoterOp

Re: [PR] MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes [kafka]

2025-09-08 Thread via GitHub
chia7712 merged PR #20446: URL: https://github.com/apache/kafka/pull/20446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes [kafka]

2025-09-08 Thread via GitHub
chia7712 commented on PR #20446: URL: https://github.com/apache/kafka/pull/20446#issuecomment-3268892847 > If that is the case, on the one hand this is just a refactoring; on the other hand it's not an area of the code I'm familiar with. Not a huge deal to change - it seems like other usage

Re: [PR] KAFKA-19585: Avoid noisy NPE logs when closing consumer after constructor failures [kafka]

2025-09-08 Thread via GitHub
chia7712 commented on code in PR #20491: URL: https://github.com/apache/kafka/pull/20491#discussion_r2332025981 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -2029,6 +2030,28 @@ public void testRecordBackgroundEventQueue

[jira] [Resolved] (KAFKA-17255) Migrate ListOffsetsIntegrationTest to ClusterTestExtensions framework

2025-09-08 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu resolved KAFKA-17255. - Resolution: Duplicate > Migrate ListOffsetsIntegrationTest to ClusterTestExtensions framework >

[jira] [Resolved] (KAFKA-19680) NoSuchElementException (again) in Kafka Streams iterator metrics

2025-09-08 Thread Steven Schlansker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Schlansker resolved KAFKA-19680. --- Resolution: Duplicate > NoSuchElementException (again) in Kafka Streams iterator met

Re: [PR] KAFKA-19654 [WIP] test issues with GitHub actions builds <<--->> Develocity instance (for both trunk/Gradle 8 and attempted upgrade to Gradle 9) [kafka]

2025-09-08 Thread via GitHub
github-actions[bot] commented on PR #20450: URL: https://github.com/apache/kafka/pull/20450#issuecomment-3268714876 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19308: Add unit tests for OAuthBearerRefreshingLogin [kafka]

2025-09-08 Thread via GitHub
github-actions[bot] commented on PR #20454: URL: https://github.com/apache/kafka/pull/20454#issuecomment-3268714780 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-09-08 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3268714988 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Updated] (KAFKA-18191) StreamJoined name is not used for processor names

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18191: Description: The StreamJoined#as API allows you to set a name for a stream-stream join op

[jira] [Updated] (KAFKA-18191) StreamJoined name is not used for processor names

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18191: Priority: Minor (was: Major) > StreamJoined name is not used for processor names > --

[jira] [Updated] (KAFKA-19691) Add metrics corresponding to consumer rebalance listener metrics

2025-09-08 Thread travis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] travis updated KAFKA-19691: --- Affects Version/s: 4.2.0 > Add metrics corresponding to consumer rebalance listener metrics > --

[jira] [Created] (KAFKA-19691) Add metrics corresponding to consumer rebalance listener metrics

2025-09-08 Thread travis (Jira)
travis created KAFKA-19691: -- Summary: Add metrics corresponding to consumer rebalance listener metrics Key: KAFKA-19691 URL: https://issues.apache.org/jira/browse/KAFKA-19691 Project: Kafka Issue T

[jira] [Updated] (KAFKA-18191) StreamJoined name is not used for processor names

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18191: Description: The StreamJoined#as API allows you to set a name for a stream-stream join op

[jira] [Updated] (KAFKA-18191) StreamJoined name is not used for processor names

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18191: Labels: needs-kip (was: ) > StreamJoined name is not used for processor names > -

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-09-08 Thread via GitHub
mjsax commented on PR #20408: URL: https://github.com/apache/kafka/pull/20408#issuecomment-3268456014 Thanks for the PR @shashankhs11. Merged to `trunk` and cherry-picked to `4.1` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-09-08 Thread via GitHub
mjsax merged PR #20408: URL: https://github.com/apache/kafka/pull/20408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-19679) NoSuchElementException (again) in Kafka Streams iterator metrics

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018911#comment-18018911 ] Matthias J. Sax commented on KAFKA-19679: - Oh dear... :( > NoSuchElementExcepti

[jira] [Updated] (KAFKA-19690) Unexpected Fatal error InvalidTxnStateException on Kafka Streams (KIP-890)

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19690: Component/s: core streams > Unexpected Fatal error InvalidTxnStateExcepti

[jira] [Updated] (KAFKA-19690) Unexpected Fatal error InvalidTxnStateException on Kafka Streams (KIP-890)

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19690: Affects Version/s: 4.1.0 > Unexpected Fatal error InvalidTxnStateException on Kafka Stream

[jira] [Created] (KAFKA-19690) Unexpected Fatal error InvalidTxnStateException on Kafka Streams (KIP-890)

2025-09-08 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-19690: Summary: Unexpected Fatal error InvalidTxnStateException on Kafka Streams (KIP-890) Key: KAFKA-19690 URL: https://issues.apache.org/jira/browse/KAFKA-19690 Project: K

[jira] [Updated] (KAFKA-19689) TopologyTestDriver spends most of its time forcing changes to disk with persistent state stores

2025-09-08 Thread Steven Schlansker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Schlansker updated KAFKA-19689: -- Description: We are using TopologyTestDriver  It looks like the test driver is syncin

Re: [PR] KAFKA-19623: Implement KIP-1147 for console producer/consumer/share-consumer. [kafka]

2025-09-08 Thread via GitHub
Yunyung commented on code in PR #20479: URL: https://github.com/apache/kafka/pull/20479#discussion_r2331457224 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleShareConsumerOptions.java: ## @@ -58,11 +58,21 @@ public ConsoleShareConsumerOptions(String[] args) throws

[jira] [Assigned] (KAFKA-19687) MetaData log error message for SNAPSHOT_HEADER and SNAPSHOT_FOOTER

2025-09-08 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-19687: --- Assignee: TaiJuWu > MetaData log error message for SNAPSHOT_HEADER and SNAPSHOT_FOOTER > --

[jira] [Resolved] (KAFKA-19689) TopologyTestDriver spends most of its time forcing changes to disk with persistent state stores

2025-09-08 Thread Steven Schlansker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Schlansker resolved KAFKA-19689. --- Resolution: Invalid I apologize, this was actually a correlated change on our end, n

Re: [PR] MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols [kafka]

2025-09-08 Thread via GitHub
TaiJuWu commented on code in PR #20466: URL: https://github.com/apache/kafka/pull/20466#discussion_r2330873629 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1786,13 +1786,12 @@ class KafkaConfigTest { // This is OK. props.put(GroupCoordinato

[jira] [Created] (KAFKA-19689) TopologyTestDriver spends most of its time forcing changes to disk

2025-09-08 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-19689: - Summary: TopologyTestDriver spends most of its time forcing changes to disk Key: KAFKA-19689 URL: https://issues.apache.org/jira/browse/KAFKA-19689 Project:

[jira] [Assigned] (KAFKA-19638) NPE in `Processor#init()` accessing state store

2025-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-19638: --- Assignee: Eduwer Camacaro > NPE in `Processor#init()` accessing state store > -

Re: [PR] KAFKA-19638: Set dummy ProcessorRecordContext for processor init [kafka]

2025-09-08 Thread via GitHub
mjsax commented on code in PR #20403: URL: https://github.com/apache/kafka/pull/20403#discussion_r2331376906 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -1104,11 +1104,18 @@ private void initializeTopology() { // initiali

[jira] [Commented] (KAFKA-19668) processValues() must be declared as value-changing operation

2025-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018898#comment-18018898 ] ASF GitHub Bot commented on KAFKA-19668: mjsax merged PR #721: URL: https://gith

Re: [PR] MINOR: update docs for KAFKA-19668 [kafka]

2025-09-08 Thread via GitHub
mjsax merged PR #20506: URL: https://github.com/apache/kafka/pull/20506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] MINOR: update docs for KAFKA-19668 [kafka]

2025-09-08 Thread via GitHub
mjsax opened a new pull request, #20506: URL: https://github.com/apache/kafka/pull/20506 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some commen

[jira] [Commented] (KAFKA-19668) processValues() must be declared as value-changing operation

2025-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018893#comment-18018893 ] ASF GitHub Bot commented on KAFKA-19668: mjsax commented on code in PR #721: URL

[jira] [Created] (KAFKA-19688) Provide clean upgrade path from transformValues to processValues

2025-09-08 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19688: --- Summary: Provide clean upgrade path from transformValues to processValues Key: KAFKA-19688 URL: https://issues.apache.org/jira/browse/KAFKA-19688 Project: Kafka

[jira] [Commented] (KAFKA-19668) processValues() must be declared as value-changing operation

2025-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018892#comment-18018892 ] ASF GitHub Bot commented on KAFKA-19668: mjsax opened a new pull request, #721:

[PR] KAFKA-19687: MetaDataShell log error message for SNAPSHOT_HEADER and SNAPSHOT_FOOTER [kafka]

2025-09-08 Thread via GitHub
TaiJuWu opened a new pull request, #20505: URL: https://github.com/apache/kafka/pull/20505 Ignore SNAPSHOT_HEADER and SNAPSHOT_FOOTER when reading snapshots to avoid to log such error messages. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-18913: Consider removing state-updater feature flag [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on PR #20378: URL: https://github.com/apache/kafka/pull/20378#issuecomment-3264941684 @shashankhs11 can you please close the PRs that we do not want to merge now or give them a discriptive name and order? There are too many PRs and I don't know which I should look at --

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-08 Thread via GitHub
see-quick commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2329636362 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -44,7 +44,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol import org.apache.kafka.c

Re: [PR] KAFKA-19666: Clean up integration tests related to state-updater [kafka]

2025-09-08 Thread via GitHub
Copilot commented on code in PR #20465: URL: https://github.com/apache/kafka/pull/20465#discussion_r2329360565 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java: ## @@ -110,15 +110,12 @@ SmokeTestDriver.Verificati

Re: [PR] MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes [kafka]

2025-09-08 Thread via GitHub
josefk31 commented on PR #20446: URL: https://github.com/apache/kafka/pull/20446#issuecomment-3266994013 > It seems the word `maxBatchSize` is still used in code case. Should we align them in this PR? @chia7712 do you mean it's still used [here](https://github.com/apache/kafka/blob/f

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2330103941 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -193,6 +196,9 @@ private void assignActive(final

[jira] [Assigned] (KAFKA-19097) Fix order of arguments to assertEquals

2025-09-08 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-19097: - Assignee: Ksolves India Limited (was: HongYi Chen) > Fix order of argu

Re: [PR] KAFKA-19661: Streams groups sometimes describe as NOT_READY when STABLE [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20457: URL: https://github.com/apache/kafka/pull/20457#discussion_r2330119126 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4441,6 +4442,55 @@ class PlaintextAdminIntegrationTest extends BaseAdminInteg

Re: [PR] MINOR: Cleanup 'share' from group.coordinator.rebalance.protocols [kafka]

2025-09-08 Thread via GitHub
TaiJuWu commented on code in PR #20466: URL: https://github.com/apache/kafka/pull/20466#discussion_r2330871537 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1786,13 +1786,12 @@ class KafkaConfigTest { // This is OK. props.put(GroupCoordinato

[jira] [Created] (KAFKA-19687) MetaData log error message for SNAPSHOT_HEADER and SNAPSHOT_FOOTER

2025-09-08 Thread TaiJuWu (Jira)
TaiJuWu created KAFKA-19687: --- Summary: MetaData log error message for SNAPSHOT_HEADER and SNAPSHOT_FOOTER Key: KAFKA-19687 URL: https://issues.apache.org/jira/browse/KAFKA-19687 Project: Kafka Iss

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-09-08 Thread via GitHub
kirktrue commented on PR #20324: URL: https://github.com/apache/kafka/pull/20324#issuecomment-3267125924 I'm closing this PR as we have decided against going any further with this approach due to thread safety concerns. cc @lianetm @AndrewJSchofield -- This is an automated message

Re: [PR] MINOR: Move topic creation before consumer creation in testListGroups integration test [kafka]

2025-09-08 Thread via GitHub
lucliu1108 commented on PR #20496: URL: https://github.com/apache/kafka/pull/20496#issuecomment-3266940973 Added a waitUtilTrue to wait until all groups are stable before validating the listGroup contents. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] [kafka]

2025-09-08 Thread via GitHub
lucasbru merged PR #20465: URL: https://github.com/apache/kafka/pull/20465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19638: Set dummy ProcessorRecordContext for processor init [kafka]

2025-09-08 Thread via GitHub
eduwercamacaro commented on code in PR #20403: URL: https://github.com/apache/kafka/pull/20403#discussion_r2330605579 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -1104,11 +1104,18 @@ private void initializeTopology() { //

[jira] [Created] (KAFKA-19686) Trigger Docker image builds in release script

2025-09-08 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19686: -- Summary: Trigger Docker image builds in release script Key: KAFKA-19686 URL: https://issues.apache.org/jira/browse/KAFKA-19686 Project: Kafka Issue Type:

Re: [PR] MINOR: Add a command to make site-docs and Javadocs updates easier on version release [kafka]

2025-09-08 Thread via GitHub
mimaison commented on code in PR #20478: URL: https://github.com/apache/kafka/pull/20478#discussion_r2330525031 ## release/release.py: ## @@ -200,12 +200,113 @@ def command_release_announcement_email(): dev_branch = '.'.join(release_version_parts[:2]) docs_release_version = do

Re: [PR] KAFKA-19660: JoinWithIncompleteMetadataIntegrationTest fails in isolated run of one parameter [kafka]

2025-09-08 Thread via GitHub
lucasbru merged PR #20483: URL: https://github.com/apache/kafka/pull/20483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Followup KAFKA-19112 document updated [kafka]

2025-09-08 Thread via GitHub
chia7712 commented on code in PR #20492: URL: https://github.com/apache/kafka/pull/20492#discussion_r2330399941 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1658,7 +1658,7 @@ class Partition(val topicPartition: TopicPartition, def deleteRecordsOnLeader(offset:

[PR] KAFKA-19681 Optimize MetadataShell tool find command print warning message intead of throwing exception [kafka]

2025-09-08 Thread via GitHub
m1a2st opened a new pull request, #20504: URL: https://github.com/apache/kafka/pull/20504 When using the find command, it currently lists all directories and files. However, if it cannot find a child node, it throws an exception and prevents the subsequent directories from being printed. I

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-08 Thread via GitHub
bbejeck commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2330289507 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/LegacyStickyTaskAssignorTest.java: ## @@ -1263,6 +1263,119 @@ public void shouldRemain

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-08 Thread via GitHub
bbejeck commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2330287941 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignorTest.java: ## @@ -1091,6 +1091,148 @@ public void shouldHandle

Re: [PR] KAFKA-19661: Streams groups sometimes describe as NOT_READY when STABLE [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20457: URL: https://github.com/apache/kafka/pull/20457#discussion_r2330180515 ## core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala: ## @@ -239,7 +239,8 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness

Re: [PR] KAFKA-19661: Streams groups sometimes describe as NOT_READY when STABLE [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20457: URL: https://github.com/apache/kafka/pull/20457#discussion_r2330173867 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -16216,6 +16216,98 @@ barTopicName, computeTopicHash(barTopi

Re: [PR] KAFKA-19661: Streams groups sometimes describe as NOT_READY when STABLE [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20457: URL: https://github.com/apache/kafka/pull/20457#discussion_r2330172947 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -6005,7 +6010,13 @@ public void replay( if (value ==

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2330109103 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/LegacyStickyTaskAssignorTest.java: ## @@ -1263,6 +1263,119 @@ public void shouldRemai

Re: [PR] KAFKA-19661 [4/N]: Prefer range-style assignment [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on code in PR #20486: URL: https://github.com/apache/kafka/pull/20486#discussion_r2330105629 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java: ## @@ -296,9 +302,13 @@ private boolean hasUnfulfilledQ

[jira] [Assigned] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-09-08 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-19332: - Assignee: Sanskar Jhajharia (was: Apoorv Mittal) > Fix flaky test : > testAlterReadCo

[jira] [Resolved] (KAFKA-19630) LSO movement archives only the first available batch not all the ones prior to the new LSO

2025-09-08 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-19630. --- Fix Version/s: 4.2.0 Resolution: Fixed > LSO movement archives only the first availab

Re: [PR] KAFKA-18913: Consider removing state-updater feature flag - 2 [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on PR #20382: URL: https://github.com/apache/kafka/pull/20382#issuecomment-3264942101 Close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-08 Thread via GitHub
see-quick commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2329654875 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-08 Thread via GitHub
see-quick commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2329645606 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-18706: Move ScramPublisher to metadata module [kafka]

2025-09-08 Thread via GitHub
see-quick commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2329659275 ## server-common/src/main/java/org/apache/kafka/server/common/CredentialProvider.java: ## Review Comment: Yeah, I think that's a good idea. -- This is an aut

Re: [PR] Optimization of the Murmur2 hash computation [kafka]

2025-09-08 Thread via GitHub
oertl commented on PR #20359: URL: https://github.com/apache/kafka/pull/20359#issuecomment-3265152054 @mimaison, is there anything I can do to bring this PR forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-19097) Fix order of arguments to assertEquals

2025-09-08 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018759#comment-18018759 ] Ksolves India Limited commented on KAFKA-19097: --- Hi [~mjsax] / [~lorcanj],

Re: [PR] KAFKA-19301: Move and rewrite partition state classes to Java in org.apache.kafka.storage.internals.log [kafka]

2025-09-08 Thread via GitHub
joshua2519 commented on code in PR #20083: URL: https://github.com/apache/kafka/pull/20083#discussion_r2329424425 ## storage/src/main/java/org/apache/kafka/storage/internals/log/OngoingReassignmentState.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-19666: Clean up integration tests related to state-updater [kafka]

2025-09-08 Thread via GitHub
Copilot commented on code in PR #20498: URL: https://github.com/apache/kafka/pull/20498#discussion_r2329360643 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -161,8 +159,8 @@ public void createTopics(final TestI

Re: [PR] KAFKA-19666: Remove old restoration codepath from PauseResumeIntegrationTest [2/N] [kafka]

2025-09-08 Thread via GitHub
lucasbru merged PR #20463: URL: https://github.com/apache/kafka/pull/20463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19666: Clean up integration tests related to state-updater [kafka]

2025-09-08 Thread via GitHub
lucasbru commented on PR #20463: URL: https://github.com/apache/kafka/pull/20463#issuecomment-3264933777 Hey @shashankhs11 . Could you name your PRs: KAFKA-19666: {descriptive naming} [k/N] -- so that we understand which is which? This one, for example, I'll name KAFKA-1