TaiJuWu commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2330871537
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1786,13 +1786,12 @@ class KafkaConfigTest {
// This is OK.
props.put(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
"classic,consumer")
- var config = KafkaConfig.fromProps(props)
+ val config = KafkaConfig.fromProps(props)
assertEquals(Set(GroupType.CLASSIC, GroupType.CONSUMER),
config.groupCoordinatorRebalanceProtocols)
- // This is OK.
+ // Including "share" should be rejected.
props.put(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
"classic,consumer,share")
Review Comment:
Should we delete share here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
