[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-09-29 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r497049737 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-09-28 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-29 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r447162953 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446586612 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if