[GitHub] [kafka] C0urante commented on pull request #12434: KAFKA-14099 - Fix request logs in connect

2022-10-12 Thread GitBox
C0urante commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1276267039 Apologies for the delay @zigarn, and thank you for sticking with this. I'm still not sure we should be relying on the Scala `LogCaptureAppender`, but I don't want to ask you to

[GitHub] [kafka] C0urante commented on pull request #12434: KAFKA-14099 - Fix request logs in connect

2022-08-01 Thread GitBox
C0urante commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1201140686 @zigarn I think we try to avoid adding dependencies from the core module into non-broker modules with few exceptions (such as spinning up embedded Kafka clusters for integration tests),