[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-07-17 Thread via GitHub
Owen-CH-Leung commented on code in PR #13773: URL: https://github.com/apache/kafka/pull/13773#discussion_r1265218200 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -44,9 +46,30 @@ public void testSetMetadataVersion() {

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-07-17 Thread via GitHub
Owen-CH-Leung commented on code in PR #13773: URL: https://github.com/apache/kafka/pull/13773#discussion_r1265177897 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -44,9 +48,33 @@ public void testSetMetadataVersion() {

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-07-17 Thread via GitHub
Owen-CH-Leung commented on code in PR #13773: URL: https://github.com/apache/kafka/pull/13773#discussion_r1265177897 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -44,9 +48,33 @@ public void testSetMetadataVersion() {

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-06-15 Thread via GitHub
Owen-CH-Leung commented on code in PR #13773: URL: https://github.com/apache/kafka/pull/13773#discussion_r1231250401 ## metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java: ## @@ -45,6 +46,7 @@ public Builder setMetadataVersion(MetadataVersion metadataV

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-06-15 Thread via GitHub
Owen-CH-Leung commented on code in PR #13773: URL: https://github.com/apache/kafka/pull/13773#discussion_r1231247557 ## metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java: ## @@ -29,6 +29,7 @@ public final class ImageWriterOptions { public static