RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1033364540
`DynamicBrokerReconfigurationTest.testThreadPoolResize()` and
`RebalanceSourceConnectorsIntegrationTest.testRemovingWorker()`
The failed testCases are not related to this
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1033258042
@guozhangwang @showuon
In fact, I ran ConsumerBounceTest.testClose() several times locally
yesterday, and the testCase can all pass. I guess the jenkins environment is
u
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1032400190
Hi @guozhangwang
I pulled the latest code of apache:trunk and resolved the conflict.
Please help to check again,thanks.
--
This is an automated message from the Apach
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1014217819
@guozhangwang
Hi, guozhang, please help to check this PR.
Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1001976302
@showuon
Sorry, I analyzed it carefully, because in the
`ConsumerCoordinator#close(timer)` method, we changed to call
`maybeAutoCommitOffsetsAsync()`, so the following co
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1001943022
Hi @showuon
I checked out a new branch `trunk_for_uptodate` from my `trunk` branch, and
pulled the latest code of `apache:trunk`
Using Gradle 7.2, Java 11 and Scala
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1000632543
@showuon @guozhangwang
The reason why KafkaConsumerTest testCase failed seems to be "Timeout has
been exceeded", which further led to the "Shutdown in progress" excep
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-196049
@guozhangwang @showuon
Thanks for your review, I just submitted some changes.
please help check again when available. Thank you.
--
This is an automated message from
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-971202316
Hi @showuon @guozhangwang
please help check this PR when available. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-968476724
@showuon please browse the latest commit when available.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-968251877
@showuon
Thanks for your suggestion. I will add more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-966737404
Hi @guozhangwang @showuon
can you help to promote this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-960522880
@guozhangwang @showuon
Thanks for your helpful review.
I just commit a new change
If you have time, please browse it.
--
This is an automated message from the A
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-957138929
Hi @showuon and @guozhangwang
Any suggestions for my last reply?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-957138929
Hi @showuon and @guozhangwang
Any suggestions for my last reply?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-957138929
Hi @showuon and @guozhangwang
Any suggestions for my last reply?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-955202193
According to our previous discussion, I re-modified and submitted the code,
local debugging, regular expression subscription consumption, deleting or
creating a topic that con
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-949189579
@guozhangwang @showuon and @hachikuji Thank you for paying so much
attention to this issue and giving a lot of valuable discussions.
> Hence it occurs to me that, the
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that the `com
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause, `time.time
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942172371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer can be th
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212161
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer can be th
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942172371
Thank you @guozhangwang for your reply, I have added some comments above,
please check it out.
Secondly, I have conducted an end-to-end test, the consumer is running
n
27 matches
Mail list logo
