[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-23 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529101499 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -154,9 +154,9 @@ final void transitionTo(fina

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-23 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529104011 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean hasPer

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-23 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529109355 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void testRege

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-23 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529109803 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void testRege

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529796474 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void testRege

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529798140 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean hasPer

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529798216 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void testRege

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529928566 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean hasPer

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529932449 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void testRege