[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566406761 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566394059 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566379088 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -89,8 +92,23 @@ private final int appendLingerMs; private final M

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566378930 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -102,31 +120,23 @@ public boolean equals(Object obj) { ret

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566378383 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -1001,6 +1001,12 @@ class KafkaConfigTest { assertEquals(expectedVo

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566377621 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -126,9 +126,13 @@ class KafkaRaftManager[T]( case spec: InetAddressSpec =>

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566314131 ## File path: core/src/test/scala/unit/kafka/raft/KafkaNetworkChannelTest.scala ## @@ -139,6 +145,25 @@ class KafkaNetworkChannelTest { } } +

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566313405 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -76,7 +87,48 @@ private final int electionBackoffMaxMs; private f

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566312951 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -76,7 +87,48 @@ private final int electionBackoffMaxMs; private f

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r565673883 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -34,6 +34,7 @@ import scala.collection.mutable object KafkaNetworkChanne

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r565673491 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -36,7 +36,9 @@ public static final String QUORUM_VOTERS_CONFIG = QUORU

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r565673305 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -208,8 +209,9 @@ public KafkaRaftClient( int fetchMaxWaitMs,

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r565672756 ## File path: raft/src/test/java/org/apache/kafka/raft/MockNetworkChannel.java ## @@ -25,20 +25,25 @@ import java.util.List; import java.util.Map; im