aloknnikhil commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r566312951
##########
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##########
@@ -76,7 +87,48 @@
private final int electionBackoffMaxMs;
private final int fetchTimeoutMs;
private final int appendLingerMs;
- private final Map<Integer, InetSocketAddress> voterConnections;
+ private final Map<Integer, AddressSpec> voterConnections;
+
+ public static abstract class AddressSpec {
+ public abstract InetSocketAddress address();
Review comment:
Yea, I did a second pass later and figured the address defeats the
purpose of the type enforcement (especially returning an InetSocketAddress for
any address spec). I reverted to an interface and have only
InetSocketAddressSpec contain an InetSocketAddress
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
