[GitHub] [kafka] chia7712 commented on a change in pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

chia7712 commented on a change in pull request #10234: URL: https://github.com/apache/kafka/pull/10234#discussion_r586390524 ## File path: clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrRequestTest.java ## @@ -59,18 +61,41 @@ public void testUnsupportedVers

[GitHub] [kafka] chia7712 commented on a change in pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

chia7712 commented on a change in pull request #10234: URL: https://github.com/apache/kafka/pull/10234#discussion_r586289230 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -145,24 +145,21 @@ public LeaderAndIsrResponse getEr

[GitHub] [kafka] chia7712 commented on a change in pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

chia7712 commented on a change in pull request #10234: URL: https://github.com/apache/kafka/pull/10234#discussion_r586270002 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -145,24 +145,21 @@ public LeaderAndIsrResponse getEr

[GitHub] [kafka] chia7712 commented on a change in pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

chia7712 commented on a change in pull request #10234: URL: https://github.com/apache/kafka/pull/10234#discussion_r585723099 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -145,24 +145,22 @@ public LeaderAndIsrResponse getEr