[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580571155 ## File path: tests/kafkatest/tests/core/round_trip_fault_test.py ## @@ -47,32 +55,48 @@ def __init__(self, test_context):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580570954 ## File path: tests/kafkatest/services/performance/end_to_end_latency.py ## @@ -74,12 +74,15 @@ def __init__(self, context, num_nodes, kafka, topic,

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580489004 ## File path: tests/kafkatest/tests/core/round_trip_fault_test.py ## @@ -47,32 +55,48 @@ def __init__(self, test_context):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580486218 ## File path: tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py ## @@ -46,13 +47,16 @@ def __init__(self, test_context):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580485952 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -120,10 +123,9 @@ def invoke_compatibility_program(self,

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580485479 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -107,7 +108,9 @@ def invoke_compatibility_program(self, features):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580485073 ## File path: tests/kafkatest/services/performance/end_to_end_latency.py ## @@ -74,12 +74,15 @@ def __init__(self, context, num_nodes, kafka, topic,

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580483780 ## File path: tests/kafkatest/services/console_consumer.py ## @@ -151,7 +151,10 @@ def prop_file(self, node): def start_cmd(self, node):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580402234 ## File path: build.gradle ## @@ -1029,6 +1029,7 @@ project(':metadata') { compile project(':clients') compile libs.jacksonDatabind