[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r623286027 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -356,7 +367,9 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r621639045 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618138592 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -957,22 +890,27 @@ ApiError electLeader(String

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618138346 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618135556 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618133367 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618133367 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618132526 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -356,7 +369,8 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618131621 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -957,22 +890,27 @@ ApiError electLeader(String

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617785244 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,62 @@ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617507396 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,62 @@ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617505731 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617160661 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,61 @@ void