[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r876238453 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -231,6 +252,10 @@ object StorageTool extends Logging { val metaPropertiesPath = Paths.get(directory, "

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875109535 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -231,6 +252,10 @@ object StorageTool extends Logging { val metaPropertiesPath = Paths.get(directory, "

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875109074 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875083085 ## metadata/src/main/java/org/apache/kafka/controller/util/SnapshotFileReader.java: ## @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.ka

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875080655 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875080655 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875075852 ## metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java: ## @@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) { public void replay(Fea

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875070799 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -17,32 +17,94 @@ package org.apache.kafka.controller; +import org.apache.kafka.clie

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875064356 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -233,6 +250,19 @@ public String version() { return ibpVersion; }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874258218 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt: Option

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874257133 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -91,19 +95,11 @@ public static NodeApiVersions create(short apiKey, short minVersion, shor

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871910034 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -927,6 +984,29 @@ private void appendRaftEvent(String name, Runnable runnable) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871908541 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -53,7 +55,7 @@ public class ClusterConfig { ClusterConfig(Type type, int brokers, int controllers, Stri

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871856970 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -17,32 +17,73 @@ package org.apache.kafka.controller; +import org.apache.kafka.clie

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871853134 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -324,7 +324,8 @@ class BrokerServer( time,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871852945 ## core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala: ## @@ -102,6 +102,10 @@ class RawMetaProperties(val props: Properties = new Properties()) { } ob

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698 ## core/src/main/scala/kafka/server/BrokerFeatures.scala: ## @@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var supportedFeatures: Features[Supporte object

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698 ## core/src/main/scala/kafka/server/BrokerFeatures.scala: ## @@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var supportedFeatures: Features[Supporte object

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869639379 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -233,4 +256,8 @@ public ApiVersion apiVersion(ApiKeys apiKey) { public Map allSupporte