[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r951937315 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -229,6 +243,12 @@ private ApiError updateMetadataVersion( return inv

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950399632 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950388163 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) { } }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949694015 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -952,6 +966,7 @@ public void testEarlyControllerResults() throws Throwable {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949694015 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -952,6 +966,7 @@ public void testEarlyControllerResults() throws Throwable {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693455 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949687749 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1142,15 +1142,19 @@ private void renounce() { purgatory.failAll(newNotCo

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949687350 ## metadata/src/main/java/org/apache/kafka/controller/LogReplayTracker.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949686749 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -72,20 +71,18 @@ import static org.junit.jupiter.api.Assertions.assertTrue

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949685089 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -188,12 +182,16 @@ private ApiError updateFeature( } } -

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949680410 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) { } }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949679883 ## metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileReader.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949678938 ## metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileReader.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949676920 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949674532 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949671940 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949670514 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949668350 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949666958 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949665682 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949665053 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde