[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746870544 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746852321 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746826740 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746805054 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746803000 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746461644 ## File path: clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746423986 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746420015 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746404173 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746376488 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive one

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746051435 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive one

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745965419 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive one

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745963579 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,125 @@ class FetchSessionTest { } @Test - def

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745871819 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745869793 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745060151 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745050475 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -238,11 +237,13 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745050242 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744942958 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744892585 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744877634 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744875433 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744104240 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744103895 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743574922 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742933244 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743909554 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic:

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743908454 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743836225 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743764793 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743763229 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic:

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic:

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic:

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743756690 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +178,37 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743755936 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743753874 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743753319 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743044369 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743751246 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -242,65 +244,68 @@ public void testIncrementals() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743750508 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -314,8 +356,7 @@ public int maxBytes() { // For

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743749915 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -199,26 +235,31 @@ public FetchRequest build(short version) {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743745314 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743578530 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -3530,37 +3534,37 @@ class KafkaApisTest { def

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743578382 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743578252 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743577292 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -4814,6 +4842,7 @@ private void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743576928 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743575635 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743574922 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743046927 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -66,16 +69,28 @@ public PartitionData( int

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743046003 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743044970 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743044369 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743041695 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743011890 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -1361,102 +1542,113 @@ class FetchSessionTest { val resp4 =

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742933244 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r741789472 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r741789472 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r741789472 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r727909392 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728132912 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728115288 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728124707 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728115288 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r727996093 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r727909392 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r727155822 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r727155822 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r715684131 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -672,29 +672,22 @@ class KafkaApis(val requestChannel: RequestChannel, val