[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-11-26 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r531123360 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1862,23 +1864,51 @@ class ReplicaManager(val config: KafkaConfig, } } -

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-11-26 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r531123780 ## File path: core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala ## @@ -78,7 +80,19 @@ class ReplicaFetcherMockBlockingSen

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-11-30 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r53221 ## File path: core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala ## @@ -78,7 +80,19 @@ class ReplicaFetcherMockBlockingSen

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-02 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r533975842 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1862,23 +1864,51 @@ class ReplicaManager(val config: KafkaConfig, } } -

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-02 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r533980942 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -3727,15 +3733,24 @@ public void testOffsetValidationR

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-02 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r533999715 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -3727,15 +3733,24 @@ public void testOffsetValidationR

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r534900872 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1839,20 +1839,17 @@ private OffsetsForLeaderEpochRespons