dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1017672302
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String,
logAppendInfo
}
+ private def
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1016427264
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1102,67 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1016425287
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String,
logAppendInfo
}
+ private def
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1015152908
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3455,6 +3455,21 @@ class UnifiedLogTest {
assertFalse(newDir.exists())
}
+ @Test
+ def
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1013705694
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -433,6 +432,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ /**
+ * Update high
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1012620903
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -433,6 +433,22 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ /**
Review Comment:
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1011539416
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -379,7 +379,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* @param hw the suggested new value
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007698554
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007700113
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007698554
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007696954
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007243845
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007243383
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007153544
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1007133812
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1006845821
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1006836805
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1006834496
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1006833685
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1006823247
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1004162782
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
21 matches
Mail list logo