[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591121500 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +102,24 @@ public static Path createTempFile(Path logDir, Offset

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591116450 ## File path: core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala ## @@ -32,13 +32,13 @@ import org.apache.kafka.common.utils.Utils import org.a

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591084650 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -16,16 +16,21 @@ */ package org.apache.kafka.snapshot; +import org

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r590923649 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotsTest.java ## @@ -74,5 +79,44 @@ public void testInvalidSnapshotFilenames() {

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r590923649 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotsTest.java ## @@ -74,5 +79,44 @@ public void testInvalidSnapshotFilenames() {

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r583343987 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,30 +250,62 @@ final class KafkaMetadataLog private ( } } - ov

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582587511 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -299,7 +290,16 @@ final class KafkaMetadataLog private ( // If snapsho

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582587332 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -341,7 +342,7 @@ object KafkaMetadataLog { } } -val rep

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582479381 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +100,22 @@ public static Path createTempFile(Path logDir, Offset

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582477733 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +100,22 @@ public static Path createTempFile(Path logDir, Offset

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r581579008 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +100,22 @@ public static Path createTempFile(Path logDir, Offset

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r580761072 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +93,13 @@ public static Path createTempFile(Path logDir, OffsetA

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r578168685 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,30 +259,45 @@ final class KafkaMetadataLog private ( } } - ov