[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r865580075 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1751,13 +1777,32 @@ class PlaintextAdminIntegrationTest extends BaseAdminInt

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r865581359 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -215,13 +215,17 @@ private void incrementalAlterConfigResource(ConfigRe

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r865580075 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1751,13 +1777,32 @@ class PlaintextAdminIntegrationTest extends BaseAdminInt

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r867294432 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -1127,6 +1127,23 @@ object TestUtils extends Logging { throw new IllegalStateException(s"Cannot

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r867294879 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -1127,6 +1127,23 @@ object TestUtils extends Logging { throw new IllegalStateException(s"Cannot

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r867297325 ## core/src/main/scala/kafka/server/ConfigAdminManager.scala: ## @@ -499,7 +499,8 @@ object ConfigAdminManager { .orElse(Option(ConfigDef.convertToStrin

[GitHub] [kafka] dengziming commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

dengziming commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r868771983 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -118,6 +118,11 @@ class BrokerMetadataPublisher(conf: KafkaConfig, */ var _fi