[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862906685 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -68,28 +63,61 @@ public double measure(MetricConfig config, long now) { }

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908032 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -87,8 +103,9 @@ public Sample oldest(long now) { Sample oldest = this

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908241 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,25 +127,40 @@ public String toString() { protected void purgeObsolet

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908720 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -52,10 +51,6 @@ public Rate(TimeUnit unit, SampledStat stat) { this.unit = u

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862909115 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -138,6 +170,46 @@ public boolean isComplete(long timeMs, MetricConfig config)

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862915029 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,22 +34,38 @@ */ public abstract class SampledStat implements Measurable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897721779 ## clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java: ## @@ -149,13 +149,14 @@ private void verifyStats(Function metricValueFunc) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897724922 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -68,24 +68,55 @@ public double measure(MetricConfig config, long now) { }

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897724648 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -84,13 +106,7 @@ public Sample current(long timeMs) { public Sample oldes

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897733191 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,35 +35,56 @@ */ public abstract class SampledStat implements Measurable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897733191 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,35 +35,56 @@ */ public abstract class SampledStat implements Measurable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897722547 ## clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java: ## @@ -608,14 +609,14 @@ public void testRateWindowing() throws Exception { time.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r897838652 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,35 +35,56 @@ */ public abstract class SampledStat implements Measurable