[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-03 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1282860735 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -122,8 +123,6 @@ public class RemoteLogManager implements Closeable { private static

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-03 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1282856425 ## core/src/test/scala/integration/kafka/api/MetricsTest.scala: ## @@ -54,6 +57,12 @@ class MetricsTest extends IntegrationTestHarness with SaslSetup {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-02 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281718684 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-02 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281642972 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-01 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280583213 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-01 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280395279 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-07-31 Thread via GitHub
divijvaidya commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1279101884 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -227,7 +227,7 @@ class KafkaRequestHandlerPool(val brokerId: Int, } } -class