[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-10 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r649135659 ## File path: README.md ## @@ -207,6 +207,20 @@ You can run checkstyle using: The checkstyle warnings will be found in

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-09 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r648435365 ## File path: README.md ## @@ -207,6 +207,20 @@ You can run checkstyle using: The checkstyle warnings will be found in

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-09 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r648427370 ## File path: build.gradle ## @@ -604,6 +625,9 @@ subprojects { description = 'Run checkstyle on all main Java sources' } +

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-07 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r646430052 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-05 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r646056035 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-05-26 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r640273965 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,60 @@ + + + + + + + + + + + + + + + + + + + +

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-05-26 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r640273794 ## File path: core/src/test/java/kafka/test/junit/ClusterTestExtensions.java ## @@ -175,7 +175,7 @@ private void processClusterTest(ExtensionContext

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-05-26 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r640273422 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,60 @@ + + + + + + + + + + + + + + + + + + + +

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-20 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r616452256 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,52 @@ + Review comment: OMG, I omitted it in the last update. :sweat: -- This is an

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-13 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r612430080 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,52 @@ + + + + Review comment: Let me have a try.  -- This is an automated

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-13 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r612429317 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,52 @@ + + + + + + + + + + + Review comment: Agree. It seems

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-13 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r612426941 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,52 @@ + Review comment: Agree. -- This is an automated message from the Apache Git