dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r649135659
##
File path: README.md
##
@@ -207,6 +207,20 @@ You can run checkstyle using:
The checkstyle warnings will be found in
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r648435365
##
File path: README.md
##
@@ -207,6 +207,20 @@ You can run checkstyle using:
The checkstyle warnings will be found in
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r648427370
##
File path: build.gradle
##
@@ -604,6 +625,9 @@ subprojects {
description = 'Run checkstyle on all main Java sources'
}
+
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r646430052
##
File path: core/src/test/java/kafka/test/MockController.java
##
@@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r646056035
##
File path: core/src/test/java/kafka/test/MockController.java
##
@@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273965
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273794
##
File path: core/src/test/java/kafka/test/junit/ClusterTestExtensions.java
##
@@ -175,7 +175,7 @@ private void processClusterTest(ExtensionContext
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273422
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r616452256
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,52 @@
+
Review comment:
OMG, I omitted it in the last update. :sweat:
--
This is an
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r612430080
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,52 @@
+
+
+
+
Review comment:
Let me have a try.
--
This is an automated
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r612429317
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,52 @@
+
+
+
+
+
+
+
+
+
+
+
Review comment:
Agree. It seems
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r612426941
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,52 @@
+
Review comment:
Agree.
--
This is an automated message from the Apache Git
12 matches
Mail list logo