[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-08-08 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1669994084 Flaky test failures appear unrelated, and the tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-08-01 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1660818460 > LGTM assuming the two small remaining comments (tweaking language in Plugins::maybeReportHybridDiscoveryIssue and using lowercase values in docs for plugin.discovery.mode property)

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-26 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1652619220 > The question of plugins that are installed directly onto the classpath might be a bit tricky... let me know if I've missed something. My current understanding is that these plugins

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-21 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1646086669 > The question of plugins that are installed directly onto the classpath might be a bit tricky... let me know if I've missed something. My current understanding is that these plugins

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-19 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1642919694 Here's an example error log output when in HYBRID_FAIL mode (I shortened the listing for brevity; the actual prints include every non-migrated plugin) ``` Plugins are missing