[GitHub] [kafka] guozhangwang commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

2023-02-16 Thread via GitHub
guozhangwang commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1109175366 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -3159,7 +3159,7 @@ private void addRecord(final MockConsumer

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

2023-02-14 Thread via GitHub
guozhangwang commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1102201605 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -258,21 +269,27 @@ private List getTasksAndActions() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

2023-01-31 Thread via GitHub
guozhangwang commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1092598270 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ReadOnlyTask.java: ## @@ -190,7 +190,7 @@ public void clearTaskTimeout() { @Override