[GitHub] [kafka] guozhangwang commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

2023-02-22 Thread via GitHub
guozhangwang commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1114660400 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -151,9 +202,18 @@ private void resumeTasks() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

2023-02-22 Thread via GitHub
guozhangwang commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1114660189 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -598,6 +685,12 @@ public Set getUpdatingStandbyTasks() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

2023-02-21 Thread via GitHub
guozhangwang commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1113677550 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -109,17 +136,41 @@ public void run() {