hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565634630
##
File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala
##
@@ -34,6 +34,7 @@ import scala.collection.mutable
object KafkaNetworkChannel
hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565643848
##
File path: raft/src/test/java/org/apache/kafka/raft/MockNetworkChannel.java
##
@@ -25,20 +25,25 @@
import java.util.List;
import java.util.Map;
impo
hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565722046
##
File path: core/src/test/scala/unit/kafka/raft/KafkaNetworkChannelTest.scala
##
@@ -139,6 +145,25 @@ class KafkaNetworkChannelTest {
}
}
+ @
hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r566373256
##
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##
@@ -126,9 +126,13 @@ class KafkaRaftManager[T](
case spec: InetAddressSpec => {
hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r566390451
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -99,7 +99,7 @@
public final InetSocketAddress address;
pu
hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r566405275
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -99,7 +99,7 @@
public final InetSocketAddress address;
pu
