hachikuji commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565643848
##########
File path: raft/src/test/java/org/apache/kafka/raft/MockNetworkChannel.java
##########
@@ -25,20 +25,25 @@
import java.util.List;
import java.util.Map;
import java.util.Optional;
+import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.function.Function;
+import java.util.stream.Collectors;
public class MockNetworkChannel implements NetworkChannel {
private final AtomicInteger correlationIdCounter;
+ private final Map<Integer, InetSocketAddress> addressCache;
Review comment:
On second thought, it seems worth keeping this as a set. It helps us
ensure that no requests are sent to non-voters. I would just change the field
name to `Set<Integer> voterIds`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
