hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324144439
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1129,3 +1132,50 @@ class DynamicProducerStateManagerConfig(val
producerStateManagerConfig: Produce
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324144171
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -89,7 +90,8 @@ object DynamicBrokerConfig {
Set(KafkaConfig.MetricReporterClassesProp) ++
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324143711
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -129,7 +129,7 @@ class KafkaServer(
var logDirFailureChannel: LogDirFailureChannel = _
@volatile pri
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324143156
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -230,7 +231,7 @@ class RemoteIndexCacheTest {
// close existing cache created in test
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324142703
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,6 +526,50 @@ class RemoteIndexCacheTest {
}
}
+ @Test
+ def testClearCach
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324142042
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -598,4 +644,16 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+ p
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324079681
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -112,27 +115,54 @@ public class RemoteIndexCache implements Closeable {
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324077576
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -197,7 +197,7 @@ public final class RemoteLogManagerConfig {
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324014567
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -700,4 +700,5 @@ class BrokerServer(
override def boundPort(listenerName: ListenerName): Int =
socket
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1320999054
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1320948713
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1320595706
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -787,6 +788,31 @@ class DynamicBrokerConfigTest {
verifyIncorrectLogLocalRetentionProp
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319841547
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -594,4 +575,16 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+ p
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319696030
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -171,21 +178,24 @@ class RemoteIndexCacheTest {
// Calling getIndex on the same entry
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319695234
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -159,9 +159,16 @@ class RemoteIndexCacheTest {
@Test
def testCacheEntryExpiry(): Uni
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319642559
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -494,6 +518,19 @@ public boolean isMarkedForCleanup() {
return
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319608604
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -125,12 +126,39 @@ public RemoteIndexCache(RemoteStorageManager
remoteStora
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319582065
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -77,6 +77,7 @@ public class RemoteIndexCache implements Closeable {
pri
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1312846642
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -406,9 +417,16 @@ class RemoteIndexCacheTest {
@Test
def testReloadCacheAfterClose()
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1312845121
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -669,4 +705,8 @@ public static String
remoteTransactionIndexFileName(Remote
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1310125666
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -669,4 +689,10 @@ public static String
remoteTransactionIndexFileName(Remot
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1310123945
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -125,12 +126,37 @@ public RemoteIndexCache(RemoteStorageManager
remoteStora
22 matches
Mail list logo
