[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-02 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r818341161 ## File path: config/server.properties ## @@ -102,18 +102,19 @@ transaction.state.log.min.isr=1 # from the end of the log. # The minimum age of a log fi

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-02 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r818340881 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -216,21 +216,22 @@ private static final String MAX_IN_

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-02 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r818184023 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -216,21 +216,22 @@ private static final String MAX_IN_

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816997743 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -202,25 +208,31 @@ /** metric.reporters */ public

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816997743 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -202,25 +208,31 @@ /** metric.reporters */ public

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-01 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r816996953 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -205,25 +208,31 @@ /** metric.reporters */ public

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-25 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r814763487 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +467,53 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812992120 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,56 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812999106 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -361,6 +369,20 @@ public void testInflightRequestsAndId

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-22 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812221236 ## File path: docs/upgrade.html ## @@ -24,7 +24,8 @@ Notable changes in 3 Idempotence for the producer is enabled by default. In 3.0.0 and 3.1.0,

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-22 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812220909 ## File path: docs/upgrade.html ## @@ -24,7 +24,8 @@ Notable changes in 3 Idempotence for the producer is enabled by default. In 3.0.0 and 3.1.0,

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-22 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812219037 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -276,8 +276,8 @@

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-17 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r809370789 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem