[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r944910841 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -29,22 +32,72 @@ * NOTE: This class is intended for INTERNAL usage only within Kafka. */

[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r900196059 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -30,21 +36,74 @@ */ public final class Checksums { +private static final Logger LOGGE

[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r900170120 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -30,21 +36,74 @@ */ public final class Checksums { +private static final Logger LOGGE

[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r900153506 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -30,21 +36,74 @@ */ public final class Checksums { +private static final Logger LOGGE

[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r872799071 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -40,10 +55,32 @@ public static void update(Checksum checksum, ByteBuffer buffer, int length)

[GitHub] [kafka] ijuma commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r872795794 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -40,10 +55,32 @@ public static void update(Checksum checksum, ByteBuffer buffer, int length)