[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284145024 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1282989826 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -81,6 +81,13 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1282971156 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1282941966 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -623,10 +632,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281763529 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281701101 ## core/src/main/java/kafka/log/remote/CustomMetadataSizeLimitExceededException.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281661247 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281646428 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -572,6 +573,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281602105 ## storage/api/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadataTest.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1281591602 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -239,96 +240,186 @@ void testStartup() { assertEquals(logDir,

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280742713 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280718946 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -393,6 +413,7 @@ public boolean equals(Object o) {

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280718863 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -169,6 +176,11 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280710406 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280708300 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1280704854 ## core/src/main/java/kafka/log/remote/CustomMetadataSizeLimitExceededException.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1258358905 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -239,96 +240,186 @@ void testStartup() { assertEquals(logDir,