[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680401984 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677941027 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677933885 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677933885 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677932954 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -303,7 +303,33 @@ default DescribeTopicsResult describeTopics(Collectio

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677932361 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -42,6 +34,14 @@ import org.apache.kafka.common.quota.ClientQuotaFilter;

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r665479977 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r665476219 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -303,7 +303,33 @@ default DescribeTopicsResult describeTopics(Collectio

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664075804 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664078161 ## File path: core/src/main/scala/kafka/api/ApiVersion.scala ## @@ -116,7 +116,9 @@ object ApiVersion { // Introduce AllocateProducerIds (KIP-730)

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664077354 ## File path: clients/src/main/resources/common/message/MetadataResponse.json ## @@ -65,7 +66,7 @@ "about": "Each topic in the response.", "fields":

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664076833 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java ## @@ -65,6 +65,20 @@ public Builder(List topics, boolean allowA

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664075804 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r611214209 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1165,16 +1189,23 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r611214209 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1165,16 +1189,23 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r566227520 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r566227520 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r566222319 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r565575532 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r565575532 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r564664073 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -313,42 +314,59 @@ object TopicCommand extends Logging { } override def d

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r564639774 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1194,9 +1194,13 @@ class KafkaApis(val requestChannel: RequestChannel, // Check

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r564638290 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563861257 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -313,42 +313,57 @@ object TopicCommand extends Logging { } override def d

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563969840 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563872705 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563955092 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563955092 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563872705 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563872442 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563903351 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563894054 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563880732 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563872705 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel, Set.emp

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563872442 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1213,8 +1238,7 @@ class KafkaApis(val requestChannel: RequestChannel, } va

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563870325 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1190,8 +1192,31 @@ class KafkaApis(val requestChannel: RequestChannel, val metada

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563861257 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -313,42 +313,57 @@ object TopicCommand extends Logging { } override def d

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r555923055 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1816,7 +1823,103 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551633181 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1816,7 +1823,103 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551607061 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1238,8 +1239,21 @@ class KafkaApis(val requestChannel: RequestChannel, val metada

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551607061 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1238,8 +1239,21 @@ class KafkaApis(val requestChannel: RequestChannel, val metada

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r546862700 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -287,7 +288,23 @@ default DescribeTopicsResult describeTopics(Collectio

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r546861997 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -31,29 +31,29 @@ * The API of this class is evolving,

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r546860091 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -31,29 +31,29 @@ * The API of this class is evolving,

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r546292513 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -343,7 +344,8 @@ INVALID_UPDATE_VERSION(95, "The given update ve