[GitHub] [kafka] jolshan commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

jolshan commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235803368 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock import org.mockito.stubbing.An

[GitHub] [kafka] jolshan commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

jolshan commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1232797807 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -342,9 +347,7 @@ class ReplicaManagerTest { rm.becomeLeaderOrFollower(1, leaderAndIsrReq

[GitHub] [kafka] jolshan commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

jolshan commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1232796642 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -84,7 +84,7 @@ import scala.jdk.CollectionConverters._ class ReplicaManagerTest { val top