[GitHub] [kafka] jolshan commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-19 Thread via GitHub
jolshan commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268535712 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-19 Thread via GitHub
jolshan commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268526325 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -386,6 +386,18 @@ public short groupMetadataValueVersion() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-19 Thread via GitHub
jolshan commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268525603 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -386,6 +386,18 @@ public short groupMetadataValueVersion() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-19 Thread via GitHub
jolshan commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268514084 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation