jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-830445376
Ok, updated the code. One thing I assumed here is that we don't switch from
not using topic IDs in the session (requests versions 12 or below) to using
13+. I ensure this in the F
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-828663698
Thanks @junrao for taking another look
> A lot of the complexity is the additional logic for propagating unresolved
partitions from FetchRequest to FetchSession and the mainte
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-814408153
currently blocked on https://github.com/apache/kafka/pull/10492
(Need to add topic IDs to the metadata topic for fetching)
--
This is an automated message from the Apache Git
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-804157913
New benchmark results: These are pretty similar to the previous results, but
thought I should include to compare to updated code (both this branch and
trunk). Note: I have modifie
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-798608479
> @jolshan Have you run both performance test and compatibility test?
I've run jmh benchmarks before but not since the merge. I plan to do so
again once I figure out how to
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-796906853
@chia7712 yes. The consumer already gets periodic metadata updates, so I use
that to get the mapping.
This is an
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-796886007
@chia7712 There was a lot of back and forth about whether we should simply
include the topic ID in the protocol (to uniquely identify the topic--which is
something we may want to
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-796317046
@chia7712 here's the commit. As mentioned in the commit message:
> Left a few todos. Still need to clean up, optimize code, and fix flaky and
broken tests in FetchRequestBetween
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-79476
Currently working on merge conflicts. Should have a first pass out in the
next day or so. There are a few changes that don't work with the previous
refactor. @chia7712, can you ta
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-790133100
waiting on https://github.com/apache/kafka/pull/9758 before proceeding since
this PR touches a lot of the same files.
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-776097476
>
> Also, it seems that for more partitions, the performance with this PR is
noticeably worse than trunk?
>
> ```
> FetchRequestBenchmark.testSerializeFetchRequestFor
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-767987726
I'm aware that the latest changes to ensure the correct fetch version is
sent seem to be causing more test timeouts. Will need to investigate further
and hopefully decrease the ti
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-767804738
Added fetch session components. Will add some versioning tests and final
cleanups, then open for review
This
13 matches
Mail list logo
