[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r637229245 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -200,7 +202,7 @@ public Builder setMetrics(ControllerMetrics

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r637228850 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -73,21 +76,33 @@ class BrokerMetadataListener(brokerId: Int,

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r621649450 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -126,10 +130,10 @@ class KafkaRaftManager[T]( private val dataDir = createDataDir(

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r621670833 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala ## @@ -108,18 +109,29 @@ class BrokerMetadataListenerTest {

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r608893213 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId: Int,

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r608891411 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2256,6 +2261,11 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] jsancio commented on a change in pull request #10497: KAFKA-12342; Merge RaftClient and MetaLogManager interfaces and remove shim

jsancio commented on a change in pull request #10497: URL: https://github.com/apache/kafka/pull/10497#discussion_r608864999 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId: Int,