[GitHub] [kafka] jsancio commented on a diff in pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-08-11 Thread GitBox
jsancio commented on code in PR #12274: URL: https://github.com/apache/kafka/pull/12274#discussion_r943618096 ## raft/src/main/java/org/apache/kafka/raft/internals/FuturePurgatory.java: ## @@ -56,7 +56,7 @@ CompletableFuture await(T threshold, long maxWaitTimeMs);

[GitHub] [kafka] jsancio commented on a diff in pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-08-11 Thread GitBox
jsancio commented on code in PR #12274: URL: https://github.com/apache/kafka/pull/12274#discussion_r943606596 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1382,7 +1383,6 @@ ControllerResult processBrokerHeartbeat(

[GitHub] [kafka] jsancio commented on a diff in pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-08-10 Thread GitBox
jsancio commented on code in PR #12274: URL: https://github.com/apache/kafka/pull/12274#discussion_r942583448 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -759,7 +759,7 @@ public void run() throws Exception { int i = 1;