[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-06-01 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r887161032 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -888,24 +975,25 @@ class ReplicaFetcherThreadTest { def shouldCatchExceptionFromBlockin

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-24 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r881046709 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-23 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r879714696 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-19 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r877600481 ## core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala: ## @@ -40,9 +42,15 @@ import scala.collection.Map * setOffsetsForNextResponse

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-19 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r877559859 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-13 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r872705006 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -51,6 +51,7 @@ import scala.math._ */ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-05 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r866389159 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -51,6 +51,7 @@ import scala.math._ */ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-05 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r866357178 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -51,6 +51,7 @@ import scala.math._ */ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-05 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r866200194 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -51,6 +51,7 @@ import scala.math._ */ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-05 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r865419210 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-13 Thread GitBox
junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r849673799 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri